Source Control Integration

master-1.2.x 38ef3244 2012-07-04 03:39 dregad Details Diff	Fix long URL formatting causing bugnote/text to be blank When MantisCoreFormatting plugin processes text (e.g. bugnote) containing a long URL, a PREG_BACKTRACK_LIMIT_ERROR may occur in string_insert_hrefs() when replacing email address links with preg_replace_callback(). When pcre.backtrack_limit = 100000, the longest URL that can be processed successfully is 152 chars. A bigger URL triggers the PCRE error and the function returns NULL. This was introduced by commit 21a3469d1039c21fbf52796f23a95ab18856254a. We now use preg_split() instead of preg_replace_callback(), which is more efficient and avoids the backtrace error issue The url replacement string was also moved to a variable to make code more readable. Fixes 0014447	Affected Issues 0014447
	mod - core/string_api.php	Diff File
master-1.2.x f9b9e2fc 2012-07-03 00:47 dregad Details Diff	Code cleanup in bug_update.php Fixes whitespace, code alignment, typos in comments, long lines
	mod - bug_update.php	Diff File
master-1.2.x 91a99d97 2012-07-03 00:29 dregad Details Diff	Add param to bug_resolve() to allow "resolution" to custom status Function bug_resolve() sets the status to bug_resolved_status_threshold. This behavior is fine with MantisBT's default status enum, but is causing issues when using a custom target status that is >= $g_bug_resolved_status_threshold & < $g_bug_closed_status_threshold. In this case, when changing status using the button on view.php, the target status selected by the user is overriden by the value of bug_resolved_status_threshold, resulting in incorrect behavior. The only way to effectively reach the custom state is by editing the issue. To address this, a new optional parameter $p_status is added to bug_resolve(). To make the function call more logical, the signature was modified: new parameter inserted in 3rd position after $p_resolution. The function's phpdoc header has been completed. Fixes 0014443	Affected Issues 0014443
	mod - bug_actiongroup.php	Diff File
	mod - bug_update.php	Diff File
	mod - core/bug_api.php	Diff File
master-1.2.x 123c2c89 2012-07-02 22:15 dregad Details Diff	Fix system warning in html_status_legend() with custom status When using custom status for which no language strings are defined, html_status_legend() triggered system warnings. MantisBT now displays the custom status' name as defined in the enum, in case there is no available translation string. Fixes 0014446	Affected Issues 0014446
	mod - core/html_api.php	Diff File
master b88e409e 2012-07-02 22:15 dregad Details Diff	Fix system warning in html_status_legend() with custom status When using custom status for which no language strings are defined, html_status_legend() triggered system warnings. MantisBT now displays the custom status' name as defined in the enum, in case there is no available translation string. Fixes 0014446	Affected Issues 0014446
	mod - core/html_api.php	Diff File
master aca7cf7d 2012-07-02 04:43 dregad Details Diff	LDAP binding calls are made even if $g_login_method <> LDAP If for some reason $g_use_ldap_email or $g_use_ldap_realname are ON with $g_login_method <> 'LDAP', binding calls are attempted when retrieving the user's e-mail or real name. Adding a check on $g_login_method to avoid this unwanted behavior. Fixes 0014442	Affected Issues 0014442
	mod - core/user_api.php	Diff File
master-1.2.x 8d35e57a 2012-07-02 04:43 dregad Details Diff	LDAP binding calls are made even if $g_login_method <> LDAP If for some reason $g_use_ldap_email or $g_use_ldap_realname are ON with $g_login_method <> 'LDAP', binding calls are attempted when retrieving the user's e-mail or real name. Adding a check on $g_login_method to avoid this unwanted behavior. Fixes 0014442	Affected Issues 0014442
	mod - core/user_api.php	Diff File
master 5273c401 2012-07-02 04:34 dregad Details Diff	SOAP API: calling mc_issue_update unduly updated bugnotes History shows 'Note View State changed' even though it has not been modified, and if time tracking is enabled the bugnote's last_updated date is changed. This was caused by a type-strict comparison of the value returned by the api (string) to an integer. Fixes 0014412	Affected Issues 0014412
	mod - api/soap/mc_issue_api.php	Diff File
master-1.2.x 802e5596 2012-07-02 04:34 dregad Details Diff	SOAP API: calling mc_issue_update unduly updated bugnotes History shows 'Note View State changed' even though it has not been modified, and if time tracking is enabled the bugnote's last_updated date is changed. This was caused by a type-strict comparison of the value returned by the api (string) to an integer. Fixes 0014412	Affected Issues 0014412
	mod - api/soap/mc_issue_api.php	Diff File
master e7b24a6f 2012-06-30 05:17 nextgens Details Diff	Remove the seed parameter of auth_generate_* functions The following functions shouldn't take a seed; random is random! - auth_generate_random_password() - auth_generate_unique_cookie_string Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
	mod - core/authentication_api.php	Diff File
	mod - core/user_api.php	Diff File
	mod - manage_user_create.php	Diff File
master-1.2.x 23c71412 2012-06-30 00:09 siebrand Details Diff	Localisation updates from http://translatewiki.net.
	mod - lang/strings_dutch.txt	Diff File
	mod - lang/strings_korean.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_dutch.txt	Diff File
master-1.2.x 4a6c8456 2012-06-28 01:35 dregad Details Diff	Fix 0011687: use of incorrect error constant	Affected Issues 0011687
	mod - core/file_api.php	Diff File
master 21e1a24b 2012-06-28 01:35 dregad Details Diff	Fix 0011687: use of incorrect error constant	Affected Issues 0011687
	mod - core/file_api.php	Diff File
master-1.2.x cdf383bd 2012-06-27 12:22 jchoover Details Diff	Fix 0011687: Bugs with attachments that are moved will lose attachments Backporting 08c027af59b88a6934377d71d19a86edfd7d12dd to 1.2.x branch. When a bug is logged and assigned to a project which has a project path assigned, and later a mantis "administrator" moves the bug from the initial project to a new project, the attachments are lost. Signed-off-by: Damien Regad <damien.regad@merckgroup.com>	Affected Issues 0011687
	mod - core/bug_api.php	Diff File
	mod - core/file_api.php	Diff File
master-1.2.x ef24c0f3 2012-06-27 01:30 dregad Details Diff	Fix PostgreSQL error when updating a project Release 1.2.11 (see commit b8d4b5039598248d0b0c78619450c51d4dc98df2 and issue 0014288) introduced a regression preventing the user from updating an existing project. This commit is a workaround for the problem (sending an int to the DB instead of a bool if using PostgreSQL), as fixing the root cause would require a schema change which is not possible in 1.2.x. Fixes 0014385	Affected Issues 0014288, 0014385
	mod - core/project_api.php	Diff File
master-1.2.x 1b79a041 2012-06-25 23:42 dregad Details Diff	Fix 0014420: system warning in make_captcha Per PHP documentation [1], second param of imagejpeg() should be set to null to output the image directly. Thanks to Andrew Kovalenko for noticing and providing fix for the issue [1] http://php.net/imagejpeg	Affected Issues 0014420
	mod - make_captcha_img.php	Diff File
master 15251868 2012-06-25 23:42 dregad Details Diff	Fix 0014420: system warning in make_captcha Per PHP documentation [1], second param of imagejpeg() should be set to null to output the image directly. Thanks to Andrew Kovalenko for noticing and providing fix for the issue [1] http://php.net/imagejpeg	Affected Issues 0014420
	mod - make_captcha_img.php	Diff File
master-2.0.x 2d3abb1b 2012-06-25 10:11 Paul Richards Details Diff	add echo's missed by previous update
	mod - bug_report_page.php	Diff File
master 65d5f1a0 2012-06-25 09:35 atrol Details Diff	Fix 0014418: Alternate text for logo image is hardcoded	Affected Issues 0014418
	mod - core/html_api.php	Diff File
master-1.2.x 3de78aa1 2012-06-25 09:29 atrol Details Diff	Fix 0014418: Alternate text for logo image is hardcoded	Affected Issues 0014418
	mod - core/html_api.php	Diff File
master-1.2.x 9d406ad5 2012-06-24 07:24 siebrand Details Diff	Localisation updates from http://translatewiki.net.
	mod - lang/strings_belarusian_tarask.txt	Diff File
	mod - lang/strings_chinese_traditional.txt	Diff File
	mod - lang/strings_czech.txt	Diff File
	mod - lang/strings_galician.txt	Diff File
	mod - lang/strings_japanese.txt	Diff File
	mod - lang/strings_spanish.txt	Diff File
	mod - lang/strings_swedish.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_belarusian_tarask.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_galician.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_swedish.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_belarusian_tarask.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_galician.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_swedish.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_belarusian_tarask.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_galician.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_swedish.txt	Diff File
master 8ad7cdb3 2012-06-21 08:10 Damien Regad Details Diff	ADOdb pgsql fix: AlterColumnSQL conversion from int to bool When changing type of a column from integer to boolean, PostgreSQL does not provide implicit type cast, so the library needs to specify it via USING statement when generating the SQLÂ· Reverse problem of 3fc6200386a975a204f6951acba4067b40ecabd0 This issue exists in ADOdb <= 5.17. Upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=19204
	mod - library/adodb/datadict/datadict-postgres.inc.php	Diff File
master 0dfd3f06 2012-06-20 09:50 Damien Regad Details Diff	Fix PostgreSQL error when adding project/subproject (schema change) The error is caused by columns mantis_project_table.inherit_global and mantis_project_hierarchy_table.inherit_parent, which are defined as unsigned int in schema.php, but treated as boolean in the code. This is a problem with PostgreSQL due to strict type checking, but not on MySQL as type cast is done automatically. Changes in schema.php the type for the 2 fields project.inherit_global and project_hierarchy.inherit_parent from Integer to Boolean Fixes 0014385
	mod - admin/schema.php	Diff File
master 43c99ae0 2012-06-20 09:45 Damien Regad Details Diff	ADOdb pgsql fix: Allow Quoted Default Values in DataDict Allows definition of defaults e.g. timestamps Upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=17397 Porting commit 156910b5dea81fe234be37695fca926f6490fb9d by Paul Richards Fixes 0014398
	mod - library/adodb/datadict/datadict-postgres.inc.php	Diff File
master afb20d31 2012-06-20 09:27 Damien Regad Details Diff	Fix install_category_migrate() function for PostgreSQL With PostgreSQL, the function was throwing a warning due calling db_query_bound() with mismatched number of parameters to the query. It was not an issue for other DB's where the parameters are not positional.
	mod - core/install_helper_functions_api.php	Diff File

Changesets: MantisBT