Changesets: MantisBT

master-1.2.x e94e0a8a

2012-06-20 06:33

dregad


Details Diff
Fix Lack of detailed error message during schema creation

During MantisBT installation, when a schema upgrade step includes
several SQL statements (as generated by ADOdb), a detailed error message
was only reported the problem occurs while executing the last statement.

Calling ExecuteSQLArray() with the 2nd param = false forces the function
to return the error message on first failure instead of continuing with
the next statement.

Fixes 0014399
Affected Issues
0014399
mod - admin/install.php Diff File

master 1ee24f63

2012-06-20 06:33

dregad


Details Diff
Fix Lack of detailed error message during schema creation

During MantisBT installation, when a schema upgrade step includes
several SQL statements (as generated by ADOdb), a detailed error message
was only reported the problem occurs while executing the last statement.

Calling ExecuteSQLArray() with the 2nd param = false forces the function
to return the error message on first failure instead of continuing with
the next statement.

Fixes 0014399
Affected Issues
0014399
mod - admin/install.php Diff File

master 7a8d046b

2012-06-20 05:16

Damien Regad


Details Diff
ADOdb pgsql fix: system warning sprintf(): Too few arguments error

Upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=19186
mod - library/adodb/drivers/adodb-postgres64.inc.php Diff File

master 3fc62003

2012-06-20 04:17

Damien Regad


Details Diff
ADOdb pgsql fix: AlterColumnSQL conversion from bool to int

When changing type of a column from boolean to integer, PostgreSQL does
not provide implicit type cast, so the library needs to specify it via
USING statement when generating the SQL·

Porting part b) of commit 10871e5afc0bffc546b1a3d60bd7a459fa37e762

This issue exists in ADOdb <= 5.17. Upstream bug report
http://phplens.com/lens/lensforum/msgs.php?id=19204

Fixes 0014398
mod - library/adodb/datadict/datadict-postgres.inc.php Diff File

master 820560a7

2012-06-20 04:17

Damien Regad


Details Diff
ADOdb pgsql fix: AlterColumnSQL incorrect SQL generated

Fixes behavior on PostgreSQL, where the schema.php upgrade step

$dict->AlterColumnSQL('mantis_user_pref_table', "redirect_delay I
NOTNULL DEFAULT 0" ) );

Generates incorrect SQL:

ALTER TABLE mantis_user_pref_table ALTER COLUMN INTEGER SET NOT NULL
ERROR: column "integer" of relation "mantis_user_pref_table" does not
exist

Porting part a) of commit 10871e5afc0bffc546b1a3d60bd7a459fa37e762

This issue exists in ADOdb <= 5.17. Upstream bug report
http://phplens.com/lens/lensforum/msgs.php?id=19202

Fixes 0014398
mod - library/adodb/datadict/datadict-postgres.inc.php Diff File

master-1.2.x ba71cf96

2012-06-18 02:52

dregad


Details Diff
Fix PostgreSQL error when adding project/subproject

Release 1.2.11 (see commit b8d4b5039598248d0b0c78619450c51d4dc98df2 and
issue 0014288) introduced a regression preventing the user from creating
a new project or adding a subproject.

The error is caused by columns mantis_project_table.inherit_global and
mantis_project_hierarchy_table.inherit_parent, which are defined as
unsigned int in schema.php, but treated as boolean in the code. This is
a problem with PostgreSQL due to strict type checking, but not on MySQL
as type cast is done automatically.

This commit is a workaround for the problem (sending an int to the DB
instead of a bool if using PostgreSQL), as fixing the root cause would
require a schema change which is not possible in 1.2.x.

Fixes 0014385
Affected Issues
0014288, 0014385
mod - core/project_api.php Diff File
mod - core/project_hierarchy_api.php Diff File

master-1.2.x 7d2ad4fc

2012-06-17 12:26

siebrand


Details Diff
Localisation updates from http://translatewiki.net.
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_japanese.txt Diff File

master-2.0.x 7f18e584

2012-06-16 07:41

Paul Richards


Details Diff
Only use array_merge() on subproject_ids when
required

Previously, the subproject merging code unconditionally called array_merge()
for each project, even if there were no subproject_ids to merge.

For a big number of projects, these array_merge() invocations are expensive.
Tweak this to only call array_merge() if there are subproject_ids to merge.
mod - core/filter_api.php Diff File

master-2.0.x b69f896d

2012-06-16 07:18

Paul Richards


Details Diff
Remove use of 'on' and 'off' strings for storing
boolean filter states

The "sticky issue" and "use date filter" filters are boolean options
that are transmitted via use of 'on' and 'off' strings in the URL.
gpc_get_bool will take these strings and return either true or false (as
a PHP bool type). We were using 'on' and 'off' within filter_api (and
elsewhere) to internally store the state of these two boolean filter
properties.

This has now been replaced with the use of a more sane true/false
representation of the state using a PHP bool type. As a consequence,
checkboxes in the filter UI throughout MantisBT now correctly reflect
the state of the filters as either on/off.
mod - billing_inc.php Diff File
mod - bugnote_stats_inc.php Diff File
mod - core/filter_api.php Diff File
mod - view_all_inc.php Diff File
mod - view_all_set.php Diff File
mod - view_filters_page.php Diff File

master-2.0.x 0bcbaad1

2012-06-16 07:05

Paul Richards


Details Diff
Remove query execution time measurements
The move to a transactional based method for executing statements will
require a new measurement system. We'll be measuring transaction
execution time and won't have access to every sub-query execution time.

This functionality is probably better handled through use of the EXPLAIN
statement where much more detailed and useful data can be captured. This
is not defined within the SQL standard and will need to be considered
seperately for each database server type. Arguably MantisBT shouldn't be
getting involved with this level of debugging -- it is probably better
left to the tools and features provided by the database server which are
far more powerful and better supported.
mod - core/html_api.php Diff File

master-2.0.x c0f9d939

2012-06-16 03:55

Paul Richards


Details Diff
This should use CSS like helper_alternate_class was changed to
mod - core/classes/MantisError.class.php Diff File

master-1.2.x 92d2dc3b

2012-06-16 00:19

rombert


Details Diff
Fix 0013415: cloning issue with attachments doesn't work Affected Issues
0013415
mod - core/file_api.php Diff File

master d8b21506

2012-06-16 00:19

rombert


Details Diff
Fix 0013415: cloning issue with attachments doesn't work Affected Issues
0013415
mod - core/file_api.php Diff File

master 7beac566

2012-06-14 20:47

dregad


Details Diff
MantisGraph: incorrect issues count in graph by severity

When $g_bug_closed_status_threshold is not the "final" entry in
status_enum_string list, function enum_bug_group() in graph_api.php
computed the number of closed issues incorrectly due to use of '='
operator instead of '>=' in the query's where clause.

Also corrects some trailing whitespace.

Fixes 0014356
Affected Issues
0014356
mod - plugins/MantisGraph/core/graph_api.php Diff File

master-1.2.x b63e1815

2012-06-14 20:47

dregad


Details Diff
MantisGraph: incorrect issues count in graph by severity

When $g_bug_closed_status_threshold is not the "final" entry in
status_enum_string list, function enum_bug_group() in graph_api.php
computed the number of closed issues incorrectly due to use of '='
operator instead of '>=' in the query's where clause.

Also corrects some trailing whitespace.

Fixes 0014356
Affected Issues
0014356
mod - plugins/MantisGraph/core/graph_api.php Diff File

master bc462cd5

2012-06-13 09:46

rombert


Details Diff
0013900: Improve documentation for mc_project_get_issues and similar
mod - api/soap/mantisconnect.php Diff File

master-1.2.x 07cb1b5c

2012-06-13 09:46

rombert


Details Diff
0013900: Improve documentation for mc_project_get_issues and similar
mod - api/soap/mantisconnect.php Diff File

master 92d6ae21

2012-06-13 08:20

rombert


Details Diff
SOAP API: verify that creating issues with enum fields set by name works
mod - tests/soap/IssueAddTest.php Diff File

master-1.2.x 6049e599

2012-06-13 08:20

rombert


Details Diff
SOAP API: verify that creating issues with enum fields set by name works
mod - tests/soap/IssueAddTest.php Diff File

master c10e49b8

2012-06-12 22:45

dregad


Details Diff
Fix verify.php bumping failed count instead of login count

This prevented admins to unlock a user's account by resetting their
password when $g_max_failed_login_count = 1.

See commit d306af51746bdb781d3a721d7af718eae34ffe5d

Fixes 0014387
Affected Issues
0014387
mod - verify.php Diff File

master-1.2.x f921d55d

2012-06-12 22:45

dregad


Details Diff
Fix verify.php bumping failed count instead of login count

This prevented admins to unlock a user's account by resetting their
password when $g_max_failed_login_count = 1.

See commit d306af51746bdb781d3a721d7af718eae34ffe5d

Fixes 0014387
Affected Issues
0014387
mod - verify.php Diff File

master-1.2.x dbc5ffdc

2012-06-10 12:44

siebrand


Details Diff
Localisation updates from http://translatewiki.net.
mod - lang/strings_breton.txt Diff File
mod - lang/strings_korean.txt Diff File
mod - lang/strings_tagalog.txt Diff File
mod - lang/strings_ukrainian.txt Diff File

master-2.0.x 1af836e4

2012-06-10 03:48

Paul Richards


Details Diff
format confirmation message
mod - core/helper_api.php Diff File
mod - css/default.css Diff File

master-2.0.x f72852b4

2012-06-10 01:55

Paul Richards


Details Diff
db_now in database does not require a timezone boolean to be added - we always want to store unix timestamp in the DB
mod - core/database_api.php Diff File

master-2.0.x 19c6a53c

2012-06-10 01:52

Paul Richards


Details Diff
remove todo item - this should stay in cf api
mod - core/custom_field_api.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 350 ... 353 354 355 356 357 358 359 ... 420 ... 490 ... 560 ... 630 ... 700 ... 730 731 732  Next  Last