Changesets: MantisBT

master 5d80a1f5

2012-11-01 17:14

rombert


Details Diff
Fixes 0011230: High-ascii characters in fields will cause invalidity in
XML.

Also apply fix to data returned from the filter and project api.
Affected Issues
0011230
mod - api/soap/mc_issue_api.php Diff File

master-1.2.x 559205e2

2012-11-01 17:14

rombert


Details Diff
Fixes 0011230: High-ascii characters in fields will cause invalidity in
XML.

Also apply fix to data returned from the filter and project api.
Affected Issues
0011230
mod - api/soap/mc_issue_api.php Diff File

master-1.2.x fa811c1d

2012-11-01 16:07

rombert


Details Diff
Fixes 0011230: High-ascii characters in fields will cause invalidity in
XML.

Code from commit 2b5d66217bd4ecf5e7271f1a4b2b339d7681e91c is used to
clean invalid characters.
Affected Issues
0011230
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_issue_api.php Diff File

master 745a0bf0

2012-11-01 16:07

rombert


Details Diff
Fixes 0011230: High-ascii characters in fields will cause invalidity in
XML.

Code from commit 2b5d66217bd4ecf5e7271f1a4b2b339d7681e91c is used to
clean invalid characters.
Affected Issues
0011230
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_issue_api.php Diff File

master-1.2.x 3a69063a

2012-11-01 13:33

dregad


Details Diff
Added .mailmap file

This allows to coalesce commits by the same person in the git shortlog,
where their name and/or email address was spelled differently.

The git shortlog can then be used to populate the CREDITS file's
"Contributors" section
add - .mailmap Diff File

master-1.2.x 243112f8

2012-10-30 08:34

dregad


Details Diff
Bump version and update doc/RELEASE for 1.2.12.
mod - core/constant_inc.php Diff File
mod - doc/RELEASE Diff File

master-1.2.x 361089d2

2012-10-28 19:00

dregad


Details Diff
Define default $g_set_status_threshold for NEW to REPORTER

This prevents incorrect highlighting of NEW status as an override in the
Access Levels section of manage_config_workflow_page.php, when
$g_bug_submit_status is different from default.

Fixes 0014496 (see atrol's bugnote 0014496:0033192 and my follow up in 0014496:0033325)
Affected Issues
0014496
mod - config_defaults_inc.php Diff File

master 7c46e287

2012-10-28 19:00

dregad


Details Diff
Define default $g_set_status_threshold for NEW to REPORTER

This prevents incorrect highlighting of NEW status as an override in the
Access Levels section of manage_config_workflow_page.php, when
$g_bug_submit_status is different from default.

Fixes 0014496 (see atrol's bugnote 0014496:0033192 and my follow up in 0014496:0033325)
Affected Issues
0014496
mod - config_defaults_inc.php Diff File

master-1.2.x d982fc99

2012-10-28 18:47

dregad


Details Diff
Workflow config: delete override if identical to parent

The code in manage_config_workflow_set.php now deletes the config
override for the current project if the new settings are identical to
the parent's (ALL_PROJECTS level if project, or file-level if all
projects).

Follow-up fix for issue 0014496
Affected Issues
0014496
mod - manage_config_workflow_set.php Diff File

master c96ca214

2012-10-28 18:47

dregad


Details Diff
Workflow config: delete override if identical to parent

The code in manage_config_workflow_set.php now deletes the config
override for the current project if the new settings are identical to
the parent's (ALL_PROJECTS level if project, or file-level if all
projects).

Follow-up fix for issue 0014496
Affected Issues
0014496
mod - manage_config_workflow_set.php Diff File

master-2.0.x 159be15d

2012-10-28 18:45

Paul Richards


Details Diff
Add new Locale i18n/l10n API to replace lang_api

Commit: 4deea44ed36cb4dcdd028be3a9f7cf3786e6e741

This is some initial work towards replacing lang_api with a new Locale
API that makes use of PHP's gettext support for translation.

gettext offers the following advantages:
a) Greater performance
b) Better supporting tools for translation work
c) Import/export support at MediaWiki.net that doesn't require
MantisBT-specific hacks
d) Pluralisation (1 thing vs 1 things)
e) en-US language is embedded in the source code and acts as a key --
this makes the source code easier to read and sections of code easier to
find upon searching for UI strings
f) Easy plugin support via loading of new text domains
g) Ability to perform more specific translations (en-US, en-GB,
en-AU...) rather than "one English fits all"
h) Support for context aware translations

There is lot of negativity in the wild regarding gettext and PHP.
Typical arguments include:

1. Lack of thread safety - this is no longer an issue with php-fpm (or
earlier Fast CGI methods) because each script will execute in a separate
process. Threaded execution of PHP under mod_php (Apache) or an IIS
equivalent is thoroughly deprecated and not recommended for numerous
reasons.

2. gettext is difficult to install with PHP - Linux distributions of PHP
will most likely have gettext enabled by default. If not, packages are
readily available in all the major distribution repositories. Windows
users are given php_gettext.dll in the .zip distribution of PHP and
simple instructions at [1] can be followed to get things up and running
quickly.

3. The gettext API is "inconsistent" or doesn't support xyz - it's
trivial to create a new wrapper function around these APIs that allows
us to implement enhanced functionality or make the API easier to use.

Don't be tricked by the outdated negativity from the early 2000's.
gettext is an "industry standard" and is not going away any time soon.

[1] http://php.net/manual/en/install.windows.extensions.php
add - core/classes/Exception/Locale/LocaleNotProvidedByUserAgent.php Diff File
add - core/classes/Exception/Locale/LocalesNotSupported.php Diff File
add - core/classes/Locale/LocaleManager.php Diff File
add - core/classes/Locale/locale_support_functions.php Diff File

master-2.0.x 6a165ba5

2012-10-28 15:27

Paul Richards


Details Diff
Replace PHP UTF-8 library with PHP's mbstring extension

Git Commit ID: beb4c5b8381c0f0eca99de23e1021fcebdc51c7a

For MantisBT 1.2.x, the PHP UTF-8 library at [1] was selected to provide
proper Unicode support to MantisBT. This library wraps around PHP's
mbstring extension and provides an alternative implemented-in-PHP
approach where the mbstring extension is not available on a server
running MantisBT. mbstring is a PHP extension that is not bundled with
PHP by default. Linux distributions already package the extension and it
is trivial to install. The extension is also bundled with the Windows
.zip distribution of PHP for Windows users and is also trivial to
install.

The need to support platform configurations where mbstring isn't
available and can't be installed stems from the days when shared hosting
was popular. With the popularisation of virtualisation (virtual private
servers) as a cheap replacement to shared hosting, administrators once
again have control over their own platform, allowing them to install PHP
extensions whenever they please. Popular Linux distributions have been
packaging and making the mbstring PHP extension available for a long
time. Installation on Windows platforms is also trivial (relative to the
complexity of Windows platforms due to a lack of software package
management functionality).

Removal of the PHP UTF-8 wrapper simplifies MantisBT's code base and
likely improves performance (no need to wrap function calls and compile
and load an entire UTF-8 library into memory). More importantly,
MantisBT no longer depends on a small library that hasn't seen updates
since 2007. Reliance on mbstring is a less risky option because it is
more widely used and ties in with PHP's official infrastructure and
support/documentation system.

MantisBT's documentation has been updated and expanded to reflect the
new installation requirement. Links to external documentation on php.net
have also been provided to guide new users in performing the simple
action of adding the mbstring extension.

[1] http://sourceforge.net/projects/phputf8/
mod - bug_actiongroup_ext_page.php Diff File
mod - bug_actiongroup_page.php Diff File
mod - bugnote_view_inc.php Diff File
mod - changelog_page.php Diff File
mod - core/authentication_api.php Diff File
mod - core/cfdefs/cfdef_standard.php Diff File
mod - core/classes/MantisUser.class.php Diff File
mod - core/columns_api.php Diff File
mod - core/custom_field_api.php Diff File
mod - core/custom_function_api.php Diff File
mod - core/database_api.php Diff File
mod - core/date_api.php Diff File
mod - core/email_api.php Diff File
mod - core/file_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/form_api.php Diff File
mod - core/install_helper_functions_api.php Diff File
mod - core/lang_api.php Diff File
mod - core/plugin_api.php Diff File
mod - core/print_api.php Diff File
mod - core/relationship_api.php Diff File
mod - core/session_api.php Diff File
mod - core/string_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/user_api.php Diff File
mod - core/version_api.php Diff File
mod - core/xmlhttprequest_api.php Diff File
add - js/jquery.iviewer.min.js Diff File
add - js/jquery.mousewheel.min.js Diff File
add - js/jquery.panzoom.js Diff File
add - js/jquery.splitter.js Diff File
add - js/jquery.tools.min.js Diff File
add - js/jquery.treeview.js Diff File
add - js/menu.js Diff File
add - js/prettify/lang-apollo.js Diff File
add - js/prettify/lang-clj.js Diff File
add - js/prettify/lang-css.js Diff File
add - js/prettify/lang-go.js Diff File
add - js/prettify/lang-hs.js Diff File
add - js/prettify/lang-lisp.js Diff File
add - js/prettify/lang-lua.js Diff File
add - js/prettify/lang-ml.js Diff File
add - js/prettify/lang-n.js Diff File
add - js/prettify/lang-proto.js Diff File
add - js/prettify/lang-scala.js Diff File
add - js/prettify/lang-sql.js Diff File
add - js/prettify/lang-tex.js Diff File
add - js/prettify/lang-vb.js Diff File
add - js/prettify/lang-vhdl.js Diff File
add - js/prettify/lang-wiki.js Diff File
add - js/prettify/lang-xq.js Diff File
add - js/prettify/lang-yaml.js Diff File
add - js/prettify/prettify.min.js Diff File
add - js/sidebar.js Diff File
add - js/template.js Diff File
rm - library/utf8/ChangeLog Diff
rm - library/utf8/LICENSE Diff
rm - library/utf8/README Diff
rm - library/utf8/TODO.tsk Diff
rm - library/utf8/exp/regexunicode.php Diff
rm - library/utf8/index.html Diff
rm - library/utf8/mbstring/core.php Diff
rm - library/utf8/native/core.php Diff
rm - library/utf8/ord.php Diff
rm - library/utf8/readme_mantis.txt Diff
rm - library/utf8/str_ireplace.php Diff
rm - library/utf8/str_pad.php Diff
rm - library/utf8/str_split.php Diff
rm - library/utf8/strcasecmp.php Diff
rm - library/utf8/strcspn.php Diff
rm - library/utf8/stristr.php Diff
rm - library/utf8/strrev.php Diff
rm - library/utf8/strspn.php Diff
rm - library/utf8/substr_replace.php Diff
rm - library/utf8/trim.php Diff
rm - library/utf8/ucfirst.php Diff
rm - library/utf8/ucwords.php Diff
rm - library/utf8/utf8.php Diff
rm - library/utf8/utils/ascii.php Diff
rm - library/utf8/utils/bad.php Diff
rm - library/utf8/utils/patterns.php Diff
rm - library/utf8/utils/position.php Diff
rm - library/utf8/utils/specials.php Diff
rm - library/utf8/utils/unicode.php Diff
rm - library/utf8/utils/validation.php Diff
mod - manage/proj_cat_update.php Diff File
mod - manage/proj_edit_page.php Diff File
mod - manage/tags_page.php Diff File
mod - manage/user_page.php Diff File
mod - news_rss.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bystatus.php Diff File
mod - print_all_bug_options_update.php Diff File
mod - print_all_bug_page_word.php Diff File
mod - print_bugnote_inc.php Diff File
mod - return_dynamic_filters.php Diff File
mod - roadmap_page.php Diff File
mod - search.php Diff File
mod - signup.php Diff File

master 1792dbb4

2012-10-27 23:17

rombert


Details Diff
Fixes 0014869: Provide a simple API for outputting JSON

Conflicts:
core/json_api.php
Affected Issues
0014869
mod - core/json_api.php Diff File

master-1.2.x 0a4fbbe5

2012-10-27 23:17

rombert


Details Diff
Fixes 0014869: Provide a simple API for outputting JSON Affected Issues
0014869
mod - core/json_api.php Diff File

master-1.2.x 2193b5c7

2012-10-27 02:35

siebrand


Details Diff
Localisation updates from http://translatewiki.net.
mod - lang/strings_breton.txt Diff File
mod - lang/strings_korean.txt Diff File
mod - lang/strings_macedonian.txt Diff File
mod - lang/strings_russian.txt Diff File
mod - lang/strings_turkish.txt Diff File
mod - plugins/XmlImportExport/lang/strings_russian.txt Diff File
mod - plugins/XmlImportExport/lang/strings_turkish.txt Diff File

master-2.0.x 82d615b8

2012-10-20 20:13

Paul Richards


Details Diff
Further work on Exceptions
mod - core/bug_api.php Diff File
mod - core/category_api.php Diff File
add - core/classes/Exception/Access/InsufficientAccessLevel.class.php Diff File
add - core/classes/Exception/Configuration/OptionInvalidValue.class.php Diff File
add - core/classes/Exception/Configuration/OptionNotFound.class.php Diff File
add - core/classes/Exception/CustomField/NotLinkedToProject.class.php Diff File
add - core/classes/Exception/File/FileNoUpload.class.php Diff File
add - core/classes/Exception/File/FileTooBig.class.php Diff File
add - core/classes/Exception/File/FileUploadFailed.class.php Diff File
add - core/classes/Exception/Filter/FilterNotFound.class.php Diff File
add - core/classes/Exception/Issue/Tag/TagAlreadyAttached.class.php Diff File
add - core/classes/Exception/Issue/Tag/TagNotAttached.class.php Diff File
add - core/classes/Exception/Issue/Version/VersionDuplicate.class.php Diff File
add - core/classes/Exception/Issue/Version/VersionNotFound.class.php Diff File
add - core/classes/Exception/Language/LanguageStringNotFound.class.php Diff File
add - core/classes/Exception/PHP/HeadersAlreadySent.class.php Diff File
add - core/classes/Exception/Plugin/EventNotDeclared.class.php Diff File
add - core/classes/Exception/Plugin/PluginAlreadyInstalled.class.php Diff File
add - core/classes/Exception/Plugin/PluginUpgradeFailed.class.php Diff File
add - core/classes/Exception/Project/Category/CategoryNotFound.class.php Diff File
add - core/classes/Exception/Project/ProjectNameNotUnique.class.php Diff File
add - core/classes/Exception/Project/ProjectNameNotValid.class.php Diff File
add - core/classes/Exception/Project/ProjectNotFound.class.php Diff File
add - core/classes/Exception/Project/RecursiveHierarchyNotAllowed.class.php Diff File
add - core/classes/Exception/Security/CSPRNGNotAvailable.class.php Diff File
add - core/classes/Exception/Security/MasterSaltInvalid.class.php Diff File
add - core/classes/Exception/Session/SessionHandlerInvalid.class.php Diff File
add - core/classes/Exception/Session/SessionVariableNotFound.class.php Diff File
add - core/classes/Exception/Sponsorship/SponsorshipNotFound.class.php Diff File
add - core/classes/Exception/Tag/TagNameNotValid.class.php Diff File
add - core/classes/Exception/Tag/TagNotFound.class.php Diff File
add - core/classes/Exception/Token/TokenNotFound.class.php Diff File
add - core/classes/Exception/Validation/DateFormatInvalid.class.php Diff File
mod - core/classes/MantisBug.class.php Diff File
mod - core/classes/MantisLanguage.class.php Diff File
mod - core/config_api.php Diff File
mod - core/crypto_api.php Diff File
mod - core/custom_field_api.php Diff File
mod - core/database_api.php Diff File
mod - core/email_api.php Diff File
mod - core/event_api.php Diff File
mod - core/file_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/gpc_api.php Diff File
mod - core/helper_api.php Diff File
mod - core/plugin_api.php Diff File
mod - core/print_api.php Diff File
mod - core/project_api.php Diff File
mod - core/project_hierarchy_api.php Diff File
mod - core/session_api.php Diff File
mod - core/sponsorship_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/tokens_api.php Diff File
mod - core/user_api.php Diff File
mod - core/version_api.php Diff File
mod - plugins/XmlImportExport/ImportXml/Issue.php Diff File

master-1.2.x 7602c68e

2012-10-20 05:16

siebrand


Details Diff
Localisation updates from http://translatewiki.net.
mod - lang/strings_arabic.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_serbian.txt Diff File
mod - lang/strings_serbian_latin.txt Diff File
mod - plugins/XmlImportExport/lang/strings_ripoarisch.txt Diff File
mod - plugins/XmlImportExport/lang/strings_serbian.txt Diff File
mod - plugins/XmlImportExport/lang/strings_serbian_latin.txt Diff File

master-1.2.x 14560348

2012-10-18 02:54

dregad


Details Diff
Fix 0014842: Incorrect matching of versions in print_version_option_list

When comparing versions to determine which ones have already been added
to the select list, a loose comparison is performed, so '1' matches
'1.0'.

This causes issues when editing a bug having a version currently
obsolete matching another, previously displayed version. In that case
the obsolete version is not added to the selection list, causing data
loss when the bug is saved (see issue 0013096).
Affected Issues
0013096, 0014842
mod - core/print_api.php Diff File

master 62a24e93

2012-10-18 02:54

dregad


Details Diff
Fix 0014842: Incorrect matching of versions in print_version_option_list

When comparing versions to determine which ones have already been added
to the select list, a loose comparison is performed, so '1' matches
'1.0'.

This causes issues when editing a bug having a version currently
obsolete matching another, previously displayed version. In that case
the obsolete version is not added to the selection list, causing data
loss when the bug is saved (see issue 0013096).
Affected Issues
0013096, 0014842
mod - core/print_api.php Diff File

master-1.2.x 21cbaef4

2012-10-15 00:47

siebrand


Details Diff
Localisation updates from http://translatewiki.net.
mod - lang/strings_french.txt Diff File
mod - lang/strings_galician.txt Diff File
mod - lang/strings_german.txt Diff File
mod - lang/strings_hebrew.txt Diff File
mod - lang/strings_italian.txt Diff File
mod - lang/strings_japanese.txt Diff File
mod - lang/strings_macedonian.txt Diff File
mod - lang/strings_spanish.txt Diff File
mod - lang/strings_swissgerman.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_spanish.txt Diff File
mod - plugins/XmlImportExport/lang/strings_hebrew.txt Diff File

master-2.0.x 6c79f5d3

2012-10-14 12:12

Paul Richards


Details Diff
exceptions
add - core/classes/Exception/Email/AddressInvalid.class.php Diff File
add - core/classes/Exception/Email/DisposableAddressNotAllowed.class.php Diff File
add - core/classes/Exception/PHP/TimezoneUpdateFailed.class.php Diff File
add - core/classes/Exception/User/UserPreferencesNotFound.class.php Diff File
mod - core/classes/MantisBug.class.php Diff File
mod - core/date_api.php Diff File
mod - core/email_api.php Diff File
mod - core/user_pref_api.php Diff File

master-1.2.x 8488106a

2012-10-13 12:34

dregad


Details Diff
Simplify and improve code in manage_config_workflow_page.php

- Avoid code duplication with a function set_color_override to determine
override of cells bgcolors attribute
- Use a single loop over the status enum in access_row()
- Removed unnecessary assignments and useless code
mod - manage_config_workflow_page.php Diff File

master 2d417534

2012-10-13 12:34

dregad


Details Diff
Simplify and improve code in manage_config_workflow_page.php

- Avoid code duplication with a function set_color_override to determine
override of cells bgcolors attribute
- Use a single loop over the status enum in access_row()
- Removed unnecessary assignments and useless code
mod - manage_config_workflow_page.php Diff File

master-1.2.x 7512b038

2012-10-13 12:09

dregad


Details Diff
Improve access level check to reopen issues
mod - core/access_api.php Diff File

master 85c132d3

2012-10-13 12:09

dregad


Details Diff
Improve access level check to reopen issues
mod - core/access_api.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 350 ... 355 356 357 358 359 360 361 ... 420 ... 490 ... 560 ... 630 ... 700 ... 746 747 748  Next  Last