Changesets: MantisBT

master 15db187c

2013-02-07 06:34

dregad


Details Diff
bug_reminder.php does not handle unsent reminders

Reminders are not logged in history (or the bugnote) if the e-mail was not
actually sent to the recipient.

The function now uses email_bug_reminder()'s return value instead of the
full user-provided list of recipients for inclusion in the reminder's
bugnote and to add history entries.

Fixes 0015471
Affected Issues
0015471
mod - bug_reminder.php Diff File

master-1.2.x 1002f8aa

2013-02-07 06:20

dregad


Details Diff
Fix return value of email_bug_reminder()

The function now returns an array containing only the users to whom the
reminder e-mail was actually sent (i.e. excludes failures, blank e-mails,
etc).

In addition, the return value is now an array of user id's instead of
user names, which indeed makes more sense from an API perspective, as
mentioned by Julian Fitzell in 5ea3d0bc837ef14fd66b63d63e5481ea3addcf29,
since the function's only caller is bug_reminder.php which exclusively
relies on user id's.

Fixes 0015472
Affected Issues
0015472
mod - core/email_api.php Diff File

master 389b2a65

2013-02-07 06:20

dregad


Details Diff
Fix return value of email_bug_reminder()

The function now returns an array containing only the users to whom the
reminder e-mail was actually sent (i.e. excludes failures, blank e-mails,
etc).

In addition, the return value is now an array of user id's instead of
user names, which indeed makes more sense from an API perspective, as
mentioned by Julian Fitzell in 5ea3d0bc837ef14fd66b63d63e5481ea3addcf29,
since the function's only caller is bug_reminder.php which exclusively
relies on user id's.

Fixes 0015472
Affected Issues
0015472
mod - core/email_api.php Diff File

master-1.2.x de4e0fac

2013-02-07 06:15

dregad


Details Diff
Optimize code to add reminder recipients to monitoring list
mod - bug_reminder.php Diff File

master 19131496

2013-02-07 06:15

dregad


Details Diff
Optimize code to add reminder recipients to monitoring list
mod - bug_reminder.php Diff File

master-1.2.x bf6f0c6a

2013-02-07 05:56

dregad


Details Diff
Improve handling of reminders' recipients list truncation

Replaced the previous method of truncating the list to a hardcoded
number of entries (50), to a more robust approach based on the size of
the underlying database field (250 chars, note_attr in bugnote table).

Added a message on the REMINDER bugnote, to inform user that the list of
recipients stored with the note, was actually truncated (Users should
refer to the issue's history to see who actually received the reminder).

This functionality relies on a hack, i.e. to indicate that the list was
truncated, bug_reminder.php is not storing the trailing delimiter in the
note_attr field, and this is picked up in bugnote_view_inc.php to
display the note to the user's attention.

Fixes 0015470
Affected Issues
0015470
mod - bug_reminder.php Diff File
mod - bugnote_view_inc.php Diff File
mod - lang/strings_english.txt Diff File

master 4429c8f7

2013-02-07 05:56

dregad


Details Diff
Improve handling of reminders' recipients list truncation

Replaced the previous method of truncating the list to a hardcoded
number of entries (50), to a more robust approach based on the size of
the underlying database field (250 chars, note_attr in bugnote table).

Added a message on the REMINDER bugnote, to inform user that the list of
recipients stored with the note, was actually truncated (Users should
refer to the issue's history to see who actually received the reminder).

This functionality relies on a hack, i.e. to indicate that the list was
truncated, bug_reminder.php is not storing the trailing delimiter in the
note_attr field, and this is picked up in bugnote_view_inc.php to
display the note to the user's attention.

Fixes 0015470
Affected Issues
0015470
mod - bug_reminder.php Diff File
mod - bugnote_view_inc.php Diff File
mod - lang/strings_english.txt Diff File

master-1.2.x 611b6f7b

2013-02-06 12:36

dregad


Details Diff
Removed trailing ':' from reminder_sent_to language string

This is for consistency, as except for error messages punctuation is
generally added by the code.

Issue 0002971
Affected Issues
0002971
mod - bugnote_view_inc.php Diff File
mod - lang/strings_english.txt Diff File
mod - print_bugnote_inc.php Diff File

master 97eb148f

2013-02-06 12:36

dregad


Details Diff
Removed trailing ':' from reminder_sent_to language string

This is for consistency, as except for error messages punctuation is
generally added by the code.

Issue 0002971
Affected Issues
0002971
mod - bugnote_view_inc.php Diff File
mod - lang/strings_english.txt Diff File
mod - print_all_bug_page_word.php Diff File
mod - print_bugnote_inc.php Diff File

master-1.2.x f4753ec5

2013-02-06 12:28

dregad


Details Diff
Fix 0002971: add reminder events to the bug history Affected Issues
0002971
mod - bug_reminder.php Diff File
mod - core/constant_inc.php Diff File
mod - core/history_api.php Diff File

master 3d34fba1

2013-02-06 12:28

dregad


Details Diff
Fix 0002971: add reminder events to the bug history Affected Issues
0002971
mod - bug_reminder.php Diff File
mod - core/constant_inc.php Diff File
mod - core/history_api.php Diff File

master da3362de

2013-02-06 11:24

dregad


Details Diff
Documentation: custom fields localization

The indications in the Custom Fields localization section contained an
incorrect reference to lang_get_current() to determine the current
language in custom_strings_inc.php. Using this function will cause the
code to return incorrect translations if the default language is
different from English.

Fixes 0010118
Affected Issues
0010118
mod - docbook/Admin_Guide/en-US/Customizing.xml Diff File

master-1.2.x 4490a54b

2013-02-06 11:24

dregad


Details Diff
Documentation: custom fields localization

The indications in the Custom Fields localization section contained an
incorrect reference to lang_get_current() to determine the current
language in custom_strings_inc.php. Using this function will cause the
code to return incorrect translations if the default language is
different from English.

Fixes 0010118
Affected Issues
0010118
mod - docbook/administration_guide/en/customizing_mantis.sgml Diff File

master-1.2.x d85e69fe

2013-02-06 03:37

dregad


Details Diff
Fix 0015453: Only display Close button if workflow allows Closed status Affected Issues
0015453
mod - core/html_api.php Diff File

master 562db4f4

2013-02-06 03:37

dregad


Details Diff
Fix 0015453: Only display Close button if workflow allows Closed status Affected Issues
0015453
mod - core/html_api.php Diff File

master-2.0.x b97cdba1

2013-02-04 17:54

Paul Richards


Details Diff
Further lang_get updates
mod - core.php Diff File
mod - core/classes/MantisError.class.php Diff File
mod - core/filter_api.php Diff File
mod - core/string_api.php Diff File
rm - lang/strings_english.txt Diff
mod - login_page.php Diff File
mod - my_view_inc.php Diff File

master-2.0.x 52c646c8

2013-02-04 17:50

Paul Richards


Details Diff
Replace plugin_lang_get with new gettext approach (part 2)
mod - core/plugin_api.php Diff File
mod - plugins/MantisCoreFormatting/MantisCoreFormatting.php Diff File
mod - plugins/MantisCoreFormatting/pages/config.php Diff File
mod - plugins/MantisGraph/MantisGraph.php Diff File
mod - plugins/MantisGraph/core/Period.php Diff File
mod - plugins/MantisGraph/core/graph_api.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bystatus.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_page.php Diff File
mod - plugins/MantisGraph/pages/config.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bycategory_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bypriority_mix.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bypriority_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_byresolution_mix.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_byresolution_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_byseverity_mix.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_byseverity_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bystatus_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_category.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_priority.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_resolution.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_severity.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_status.php Diff File
mod - plugins/XmlImportExport/XmlImportExport.php Diff File
mod - plugins/XmlImportExport/pages/import.php Diff File
mod - plugins/XmlImportExport/pages/import_action.php Diff File

master-1.2.x 37631b83

2013-01-31 06:23

cybd


Details Diff
Fix 0015451: Incorrect invocations of SoapObjectsFactory::newSoapFault

Signed-off-by: Robert Munteanu <robert@lmn.ro>
Affected Issues
0015451
mod - api/soap/mc_project_api.php Diff File
mod - api/soap/mc_project_attachment_api.php Diff File

master 1f65ba49

2013-01-31 06:23

cybd


Details Diff
Fix 0015451: Incorrect invocations of SoapObjectsFactory::newSoapFault

Signed-off-by: Robert Munteanu <robert@lmn.ro>
Affected Issues
0015451
mod - api/soap/mc_project_api.php Diff File
mod - api/soap/mc_project_attachment_api.php Diff File

master-1.2.x 4ea08bf0

2013-01-30 04:05

dregad


Details Diff
Remove call to realpath() when setting BASE_PATH in core.php

Per PHP documentation [1], since version 4.0.2 __FILE__ always contains
an absolute path with symlinks resolved; considering that MantisBT's
minimum requirement is PHP 5.1 we therefore do not need to call
realpath().

This avoids problems with the function returning FALSE when the running
script does not have executable permissions on all directories in the
hierarchy, which can happen e.g. with shared hosting on Windows.

Fixes 0015357

[1] http://php.net/language.constants.predefined.php
Affected Issues
0015357
mod - core.php Diff File

master-1.2.x a685ee50

2013-01-30 04:04

dregad


Details Diff
Changed version to 1.2.15dev
mod - core/constant_inc.php Diff File

master-1.2.x ee3695f8

2013-01-29 04:46

dregad


Details Diff
Revised release notes for 1.2.14

Based on atrol's feedback, added info about 0015415.
mod - doc/RELEASE Diff File

master 3d20e9a9

2013-01-28 07:01

Damien Regad

Committer: dregad


Details Diff
Install: fix logic to retry a failed install

Instead of having a single form spanning the entire page, we have one
to display input fields for user to submit new or modified data, and one
with hidden fields to retry failed steps.

With this, the retry button now works as expected.
mod - admin/install.php Diff File

master 5346341a

2013-01-28 06:54

Damien Regad

Committer: dregad


Details Diff
Install: fix problem with db_password when retrying after failure

The logic to avoid divulgation of db password was flawed, forcing user
to re-enter the password when retrying after a failed install/upgrade.
mod - admin/install.php Diff File

master 1c828e68

2013-01-28 06:49

Damien Regad

Committer: dregad


Details Diff
Install: Code cleanup, remove useless if statements

It's not necessary to individually test the same variable to
conditionally display install-only fields
mod - admin/install.php Diff File
 First  Prev  1 2 3 ... 80 ... 160 ... 240 ... 320 ... 364 365 366 367 368 369 370 ... 400 ... 480 ... 560 ... 640 ... 720 ... 763 764 765  Next  Last