Changesets: MantisBT

master-1.2.x 123c2c89

2012-07-02 22:15

dregad


Details Diff
Fix system warning in html_status_legend() with custom status

When using custom status for which no language strings are defined,
html_status_legend() triggered system warnings.

MantisBT now displays the custom status' name as defined in the enum,
in case there is no available translation string.

Fixes 0014446
Affected Issues
0014446
mod - core/html_api.php Diff File

master b88e409e

2012-07-02 22:15

dregad


Details Diff
Fix system warning in html_status_legend() with custom status

When using custom status for which no language strings are defined,
html_status_legend() triggered system warnings.

MantisBT now displays the custom status' name as defined in the enum,
in case there is no available translation string.

Fixes 0014446
Affected Issues
0014446
mod - core/html_api.php Diff File

master aca7cf7d

2012-07-02 04:43

dregad


Details Diff
LDAP binding calls are made even if $g_login_method <> LDAP

If for some reason $g_use_ldap_email or $g_use_ldap_realname are ON with
$g_login_method <> 'LDAP', binding calls are attempted when retrieving
the user's e-mail or real name.

Adding a check on $g_login_method to avoid this unwanted behavior.

Fixes 0014442
Affected Issues
0014442
mod - core/user_api.php Diff File

master-1.2.x 8d35e57a

2012-07-02 04:43

dregad


Details Diff
LDAP binding calls are made even if $g_login_method <> LDAP

If for some reason $g_use_ldap_email or $g_use_ldap_realname are ON with
$g_login_method <> 'LDAP', binding calls are attempted when retrieving
the user's e-mail or real name.

Adding a check on $g_login_method to avoid this unwanted behavior.

Fixes 0014442
Affected Issues
0014442
mod - core/user_api.php Diff File

master 5273c401

2012-07-02 04:34

dregad


Details Diff
SOAP API: calling mc_issue_update unduly updated bugnotes

History shows 'Note View State changed' even though it has not been
modified, and if time tracking is enabled the bugnote's last_updated
date is changed.

This was caused by a type-strict comparison of the value returned by the
api (string) to an integer.

Fixes 0014412
Affected Issues
0014412
mod - api/soap/mc_issue_api.php Diff File

master-1.2.x 802e5596

2012-07-02 04:34

dregad


Details Diff
SOAP API: calling mc_issue_update unduly updated bugnotes

History shows 'Note View State changed' even though it has not been
modified, and if time tracking is enabled the bugnote's last_updated
date is changed.

This was caused by a type-strict comparison of the value returned by the
api (string) to an integer.

Fixes 0014412
Affected Issues
0014412
mod - api/soap/mc_issue_api.php Diff File

master e7b24a6f

2012-06-30 05:17

nextgens


Details Diff
Remove the seed parameter of auth_generate_* functions

The following functions shouldn't take a seed; random is random!
- auth_generate_random_password()
- auth_generate_unique_cookie_string

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
mod - core/authentication_api.php Diff File
mod - core/user_api.php Diff File
mod - manage_user_create.php Diff File

master-1.2.x 23c71412

2012-06-30 00:09

siebrand


Details Diff
Localisation updates from http://translatewiki.net.
mod - lang/strings_dutch.txt Diff File
mod - lang/strings_korean.txt Diff File
mod - plugins/MantisGraph/lang/strings_dutch.txt Diff File

master-1.2.x 4a6c8456

2012-06-28 01:35

dregad


Details Diff
Fix 0011687: use of incorrect error constant Affected Issues
0011687
mod - core/file_api.php Diff File

master 21e1a24b

2012-06-28 01:35

dregad


Details Diff
Fix 0011687: use of incorrect error constant Affected Issues
0011687
mod - core/file_api.php Diff File

master-1.2.x cdf383bd

2012-06-27 12:22

jchoover


Details Diff
Fix 0011687: Bugs with attachments that are moved will lose attachments

Backporting 08c027af59b88a6934377d71d19a86edfd7d12dd to 1.2.x branch.

When a bug is logged and assigned to a project which has a project path
assigned, and later a mantis "administrator" moves the bug from the
initial project to a new project, the attachments are lost.

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
Affected Issues
0011687
mod - core/bug_api.php Diff File
mod - core/file_api.php Diff File

master-1.2.x ef24c0f3

2012-06-27 01:30

dregad


Details Diff
Fix PostgreSQL error when updating a project

Release 1.2.11 (see commit b8d4b5039598248d0b0c78619450c51d4dc98df2 and
issue 0014288) introduced a regression preventing the user from updating
an existing project.

This commit is a workaround for the problem (sending an int to the DB
instead of a bool if using PostgreSQL), as fixing the root cause would
require a schema change which is not possible in 1.2.x.

Fixes 0014385
Affected Issues
0014288, 0014385
mod - core/project_api.php Diff File

master-1.2.x 1b79a041

2012-06-25 23:42

dregad


Details Diff
Fix 0014420: system warning in make_captcha

Per PHP documentation [1], second param of imagejpeg() should be set to
null to output the image directly.

Thanks to Andrew Kovalenko for noticing and providing fix for the issue

[1] http://php.net/imagejpeg
Affected Issues
0014420
mod - make_captcha_img.php Diff File

master 15251868

2012-06-25 23:42

dregad


Details Diff
Fix 0014420: system warning in make_captcha

Per PHP documentation [1], second param of imagejpeg() should be set to
null to output the image directly.

Thanks to Andrew Kovalenko for noticing and providing fix for the issue

[1] http://php.net/imagejpeg
Affected Issues
0014420
mod - make_captcha_img.php Diff File

master-2.0.x 2d3abb1b

2012-06-25 10:11

Paul Richards


Details Diff
add echo's missed by previous update
mod - bug_report_page.php Diff File

master 65d5f1a0

2012-06-25 09:35

atrol


Details Diff
Fix 0014418: Alternate text for logo image is hardcoded Affected Issues
0014418
mod - core/html_api.php Diff File

master-1.2.x 3de78aa1

2012-06-25 09:29

atrol


Details Diff
Fix 0014418: Alternate text for logo image is hardcoded Affected Issues
0014418
mod - core/html_api.php Diff File

master-1.2.x 9d406ad5

2012-06-24 07:24

siebrand


Details Diff
Localisation updates from http://translatewiki.net.
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_chinese_traditional.txt Diff File
mod - lang/strings_czech.txt Diff File
mod - lang/strings_galician.txt Diff File
mod - lang/strings_japanese.txt Diff File
mod - lang/strings_spanish.txt Diff File
mod - lang/strings_swedish.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_belarusian_tarask.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_galician.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_swedish.txt Diff File
mod - plugins/MantisGraph/lang/strings_belarusian_tarask.txt Diff File
mod - plugins/MantisGraph/lang/strings_galician.txt Diff File
mod - plugins/MantisGraph/lang/strings_swedish.txt Diff File
mod - plugins/XmlImportExport/lang/strings_belarusian_tarask.txt Diff File
mod - plugins/XmlImportExport/lang/strings_galician.txt Diff File
mod - plugins/XmlImportExport/lang/strings_swedish.txt Diff File

master 8ad7cdb3

2012-06-21 08:10

Damien Regad


Details Diff
ADOdb pgsql fix: AlterColumnSQL conversion from int to bool

When changing type of a column from integer to boolean, PostgreSQL does
not provide implicit type cast, so the library needs to specify it via
USING statement when generating the SQL·

Reverse problem of 3fc6200386a975a204f6951acba4067b40ecabd0

This issue exists in ADOdb <= 5.17. Upstream bug report
http://phplens.com/lens/lensforum/msgs.php?id=19204
mod - library/adodb/datadict/datadict-postgres.inc.php Diff File

master 0dfd3f06

2012-06-20 09:50

Damien Regad


Details Diff
Fix PostgreSQL error when adding project/subproject (schema change)

The error is caused by columns mantis_project_table.inherit_global and
mantis_project_hierarchy_table.inherit_parent, which are defined as
unsigned int in schema.php, but treated as boolean in the code. This is
a problem with PostgreSQL due to strict type checking, but not on MySQL
as type cast is done automatically.

Changes in schema.php the type for the 2 fields project.inherit_global
and project_hierarchy.inherit_parent from Integer to Boolean

Fixes 0014385
mod - admin/schema.php Diff File

master 43c99ae0

2012-06-20 09:45

Damien Regad


Details Diff
ADOdb pgsql fix: Allow Quoted Default Values in DataDict

Allows definition of defaults e.g. timestamps

Upstream bug report
http://phplens.com/lens/lensforum/msgs.php?id=17397

Porting commit 156910b5dea81fe234be37695fca926f6490fb9d by Paul Richards

Fixes 0014398
mod - library/adodb/datadict/datadict-postgres.inc.php Diff File

master afb20d31

2012-06-20 09:27

Damien Regad


Details Diff
Fix install_category_migrate() function for PostgreSQL

With PostgreSQL, the function was throwing a warning due calling
db_query_bound() with mismatched number of parameters to the query.

It was not an issue for other DB's where the parameters are not
positional.
mod - core/install_helper_functions_api.php Diff File

master 1ee24f63

2012-06-20 06:33

dregad


Details Diff
Fix Lack of detailed error message during schema creation

During MantisBT installation, when a schema upgrade step includes
several SQL statements (as generated by ADOdb), a detailed error message
was only reported the problem occurs while executing the last statement.

Calling ExecuteSQLArray() with the 2nd param = false forces the function
to return the error message on first failure instead of continuing with
the next statement.

Fixes 0014399
Affected Issues
0014399
mod - admin/install.php Diff File

master-1.2.x e94e0a8a

2012-06-20 06:33

dregad


Details Diff
Fix Lack of detailed error message during schema creation

During MantisBT installation, when a schema upgrade step includes
several SQL statements (as generated by ADOdb), a detailed error message
was only reported the problem occurs while executing the last statement.

Calling ExecuteSQLArray() with the 2nd param = false forces the function
to return the error message on first failure instead of continuing with
the next statement.

Fixes 0014399
Affected Issues
0014399
mod - admin/install.php Diff File

master 7a8d046b

2012-06-20 05:16

Damien Regad


Details Diff
ADOdb pgsql fix: system warning sprintf(): Too few arguments error

Upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=19186
mod - library/adodb/drivers/adodb-postgres64.inc.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 350 ... 368 369 370 371 372 373 374 ... 420 ... 490 ... 560 ... 630 ... 700 ... 746 747 748  Next  Last