Source Control Integration

master 21e1a24b 2012-06-28 01:35 dregad Details Diff	Fix 0011687: use of incorrect error constant	Affected Issues 0011687
	mod - core/file_api.php	Diff File
master-1.2.x cdf383bd 2012-06-27 12:22 jchoover Details Diff	Fix 0011687: Bugs with attachments that are moved will lose attachments Backporting 08c027af59b88a6934377d71d19a86edfd7d12dd to 1.2.x branch. When a bug is logged and assigned to a project which has a project path assigned, and later a mantis "administrator" moves the bug from the initial project to a new project, the attachments are lost. Signed-off-by: Damien Regad <damien.regad@merckgroup.com>	Affected Issues 0011687
	mod - core/bug_api.php	Diff File
	mod - core/file_api.php	Diff File
master-1.2.x ef24c0f3 2012-06-27 01:30 dregad Details Diff	Fix PostgreSQL error when updating a project Release 1.2.11 (see commit b8d4b5039598248d0b0c78619450c51d4dc98df2 and issue 0014288) introduced a regression preventing the user from updating an existing project. This commit is a workaround for the problem (sending an int to the DB instead of a bool if using PostgreSQL), as fixing the root cause would require a schema change which is not possible in 1.2.x. Fixes 0014385	Affected Issues 0014288, 0014385
	mod - core/project_api.php	Diff File
master-1.2.x 1b79a041 2012-06-25 23:42 dregad Details Diff	Fix 0014420: system warning in make_captcha Per PHP documentation [1], second param of imagejpeg() should be set to null to output the image directly. Thanks to Andrew Kovalenko for noticing and providing fix for the issue [1] http://php.net/imagejpeg	Affected Issues 0014420
	mod - make_captcha_img.php	Diff File
master 15251868 2012-06-25 23:42 dregad Details Diff	Fix 0014420: system warning in make_captcha Per PHP documentation [1], second param of imagejpeg() should be set to null to output the image directly. Thanks to Andrew Kovalenko for noticing and providing fix for the issue [1] http://php.net/imagejpeg	Affected Issues 0014420
	mod - make_captcha_img.php	Diff File
master-2.0.x 2d3abb1b 2012-06-25 10:11 Paul Richards Details Diff	add echo's missed by previous update
	mod - bug_report_page.php	Diff File
master 65d5f1a0 2012-06-25 09:35 atrol Details Diff	Fix 0014418: Alternate text for logo image is hardcoded	Affected Issues 0014418
	mod - core/html_api.php	Diff File
master-1.2.x 3de78aa1 2012-06-25 09:29 atrol Details Diff	Fix 0014418: Alternate text for logo image is hardcoded	Affected Issues 0014418
	mod - core/html_api.php	Diff File
master-1.2.x 9d406ad5 2012-06-24 07:24 siebrand Details Diff	Localisation updates from http://translatewiki.net.
	mod - lang/strings_belarusian_tarask.txt	Diff File
	mod - lang/strings_chinese_traditional.txt	Diff File
	mod - lang/strings_czech.txt	Diff File
	mod - lang/strings_galician.txt	Diff File
	mod - lang/strings_japanese.txt	Diff File
	mod - lang/strings_spanish.txt	Diff File
	mod - lang/strings_swedish.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_belarusian_tarask.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_galician.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_swedish.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_belarusian_tarask.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_galician.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_swedish.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_belarusian_tarask.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_galician.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_swedish.txt	Diff File
master 8ad7cdb3 2012-06-21 08:10 Damien Regad Details Diff	ADOdb pgsql fix: AlterColumnSQL conversion from int to bool When changing type of a column from integer to boolean, PostgreSQL does not provide implicit type cast, so the library needs to specify it via USING statement when generating the SQLÂ· Reverse problem of 3fc6200386a975a204f6951acba4067b40ecabd0 This issue exists in ADOdb <= 5.17. Upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=19204
	mod - library/adodb/datadict/datadict-postgres.inc.php	Diff File
master 0dfd3f06 2012-06-20 09:50 Damien Regad Details Diff	Fix PostgreSQL error when adding project/subproject (schema change) The error is caused by columns mantis_project_table.inherit_global and mantis_project_hierarchy_table.inherit_parent, which are defined as unsigned int in schema.php, but treated as boolean in the code. This is a problem with PostgreSQL due to strict type checking, but not on MySQL as type cast is done automatically. Changes in schema.php the type for the 2 fields project.inherit_global and project_hierarchy.inherit_parent from Integer to Boolean Fixes 0014385
	mod - admin/schema.php	Diff File
master 43c99ae0 2012-06-20 09:45 Damien Regad Details Diff	ADOdb pgsql fix: Allow Quoted Default Values in DataDict Allows definition of defaults e.g. timestamps Upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=17397 Porting commit 156910b5dea81fe234be37695fca926f6490fb9d by Paul Richards Fixes 0014398
	mod - library/adodb/datadict/datadict-postgres.inc.php	Diff File
master afb20d31 2012-06-20 09:27 Damien Regad Details Diff	Fix install_category_migrate() function for PostgreSQL With PostgreSQL, the function was throwing a warning due calling db_query_bound() with mismatched number of parameters to the query. It was not an issue for other DB's where the parameters are not positional.
	mod - core/install_helper_functions_api.php	Diff File
master 1ee24f63 2012-06-20 06:33 dregad Details Diff	Fix Lack of detailed error message during schema creation During MantisBT installation, when a schema upgrade step includes several SQL statements (as generated by ADOdb), a detailed error message was only reported the problem occurs while executing the last statement. Calling ExecuteSQLArray() with the 2nd param = false forces the function to return the error message on first failure instead of continuing with the next statement. Fixes 0014399	Affected Issues 0014399
	mod - admin/install.php	Diff File
master-1.2.x e94e0a8a 2012-06-20 06:33 dregad Details Diff	Fix Lack of detailed error message during schema creation During MantisBT installation, when a schema upgrade step includes several SQL statements (as generated by ADOdb), a detailed error message was only reported the problem occurs while executing the last statement. Calling ExecuteSQLArray() with the 2nd param = false forces the function to return the error message on first failure instead of continuing with the next statement. Fixes 0014399	Affected Issues 0014399
	mod - admin/install.php	Diff File
master 7a8d046b 2012-06-20 05:16 Damien Regad Details Diff	ADOdb pgsql fix: system warning sprintf(): Too few arguments error Upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=19186
	mod - library/adodb/drivers/adodb-postgres64.inc.php	Diff File
master 820560a7 2012-06-20 04:17 Damien Regad Details Diff	ADOdb pgsql fix: AlterColumnSQL incorrect SQL generated Fixes behavior on PostgreSQL, where the schema.php upgrade step $dict->AlterColumnSQL('mantis_user_pref_table', "redirect_delay I NOTNULL DEFAULT 0" ) ); Generates incorrect SQL: ALTER TABLE mantis_user_pref_table ALTER COLUMN INTEGER SET NOT NULL ERROR: column "integer" of relation "mantis_user_pref_table" does not exist Porting part a) of commit 10871e5afc0bffc546b1a3d60bd7a459fa37e762 This issue exists in ADOdb <= 5.17. Upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=19202 Fixes 0014398
	mod - library/adodb/datadict/datadict-postgres.inc.php	Diff File
master 3fc62003 2012-06-20 04:17 Damien Regad Details Diff	ADOdb pgsql fix: AlterColumnSQL conversion from bool to int When changing type of a column from boolean to integer, PostgreSQL does not provide implicit type cast, so the library needs to specify it via USING statement when generating the SQLÂ· Porting part b) of commit 10871e5afc0bffc546b1a3d60bd7a459fa37e762 This issue exists in ADOdb <= 5.17. Upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=19204 Fixes 0014398
	mod - library/adodb/datadict/datadict-postgres.inc.php	Diff File
master-1.2.x ba71cf96 2012-06-18 02:52 dregad Details Diff	Fix PostgreSQL error when adding project/subproject Release 1.2.11 (see commit b8d4b5039598248d0b0c78619450c51d4dc98df2 and issue 0014288) introduced a regression preventing the user from creating a new project or adding a subproject. The error is caused by columns mantis_project_table.inherit_global and mantis_project_hierarchy_table.inherit_parent, which are defined as unsigned int in schema.php, but treated as boolean in the code. This is a problem with PostgreSQL due to strict type checking, but not on MySQL as type cast is done automatically. This commit is a workaround for the problem (sending an int to the DB instead of a bool if using PostgreSQL), as fixing the root cause would require a schema change which is not possible in 1.2.x. Fixes 0014385	Affected Issues 0014288, 0014385
	mod - core/project_api.php	Diff File
	mod - core/project_hierarchy_api.php	Diff File
master-1.2.x 7d2ad4fc 2012-06-17 12:26 siebrand Details Diff	Localisation updates from http://translatewiki.net.
	mod - lang/strings_belarusian_tarask.txt	Diff File
	mod - lang/strings_japanese.txt	Diff File
master-2.0.x 7f18e584 2012-06-16 07:41 Paul Richards Details Diff	Only use array_merge() on subproject_ids when required Previously, the subproject merging code unconditionally called array_merge() for each project, even if there were no subproject_ids to merge. For a big number of projects, these array_merge() invocations are expensive. Tweak this to only call array_merge() if there are subproject_ids to merge.
	mod - core/filter_api.php	Diff File
master-2.0.x b69f896d 2012-06-16 07:18 Paul Richards Details Diff	Remove use of 'on' and 'off' strings for storing boolean filter states The "sticky issue" and "use date filter" filters are boolean options that are transmitted via use of 'on' and 'off' strings in the URL. gpc_get_bool will take these strings and return either true or false (as a PHP bool type). We were using 'on' and 'off' within filter_api (and elsewhere) to internally store the state of these two boolean filter properties. This has now been replaced with the use of a more sane true/false representation of the state using a PHP bool type. As a consequence, checkboxes in the filter UI throughout MantisBT now correctly reflect the state of the filters as either on/off.
	mod - billing_inc.php	Diff File
	mod - bugnote_stats_inc.php	Diff File
	mod - core/filter_api.php	Diff File
	mod - view_all_inc.php	Diff File
	mod - view_all_set.php	Diff File
	mod - view_filters_page.php	Diff File
master-2.0.x 0bcbaad1 2012-06-16 07:05 Paul Richards Details Diff	Remove query execution time measurements The move to a transactional based method for executing statements will require a new measurement system. We'll be measuring transaction execution time and won't have access to every sub-query execution time. This functionality is probably better handled through use of the EXPLAIN statement where much more detailed and useful data can be captured. This is not defined within the SQL standard and will need to be considered seperately for each database server type. Arguably MantisBT shouldn't be getting involved with this level of debugging -- it is probably better left to the tools and features provided by the database server which are far more powerful and better supported.
	mod - core/html_api.php	Diff File
master-2.0.x c0f9d939 2012-06-16 03:55 Paul Richards Details Diff	This should use CSS like helper_alternate_class was changed to
	mod - core/classes/MantisError.class.php	Diff File
master-1.2.x 92d2dc3b 2012-06-16 00:19 rombert Details Diff	Fix 0013415: cloning issue with attachments doesn't work	Affected Issues 0013415
	mod - core/file_api.php	Diff File

Changesets: MantisBT