Changesets: MantisBT

master-2.27 e2886aea

2025-02-23 11:17

dregad


Details Diff
Install: don't execute SET NAMES UTF8 when printing queries

The installer always executes the query, regardless of $f_log_queries.
When true, the query should be printed, not executed.

Fixes 0035431
Affected Issues
0035431
mod - admin/install.php Diff File

master-2.27 6d9b53dd

2025-02-23 10:24

dregad


Details Diff
Fix filters with date custom fields on PHP 8

In PHP < 8.0, comparing a string to 0 evaluates to true when the string
is empty, but starting with 8.0 it returns false [1].

As a result, when BugFilterQuery::build_prop_custom_fields() checks the
filter (`$t_field[0] == CUSTOM_FIELD_DATE_ANY`, line 1470), it fails on
PHP 8.0+.

To fix this behavior, we ensure that a date custom fields's filter type
is always an int:

- When processing it in filter_gpc_get(), use gpc_get_int() instead of
gpc_get_string() to retrieve the filter's type
- When validating a filter, add special handling for date custom fields
to ensure that the values (control, timestamp 1 & 2) are treated as
integers.

Fixes 0035291

[1]: https://wiki.php.net/rfc/string_to_number_comparison
Affected Issues
0035291
mod - core/filter_api.php Diff File

master-2.27 726961e1

2025-02-23 10:04

dregad


Details Diff
Fix PHP 8.1 deprecation warning in gpc_get_int()

When function is called with null default:
DEPRECATED: 'trim(): Passing null to parameter 1 ($string) of type
string is deprecated' in '.../core/gpc_api.php' line 134

Fixes 0035428
Affected Issues
0035428
mod - core/gpc_api.php Diff File

master a7e5e498

2025-02-22 17:49

dregad


Details Diff
Inconsistent display in navbar user menu

When using avatar ($g_show_avatar = ON), the username is displayed in a
span with user-info class, but when OFF the span and class were not
present.

With this commit, the span and class are always used.

Fixes 0035425
Affected Issues
0035425
mod - core/layout_api.php Diff File

master-2.27 c55d891a

2025-02-22 03:43

raspopov

Committer: dregad


Details Diff
Increase navbar user name width

The max-width increased from 100px to 270px, this is the maximum size at
which the navbar menu does not collapse on narrow screens.

Fixes 0023593.

Signed-off-by: raspopov <raspopov@cherubicsoft.com>
Affected Issues
0023593
mod - css/ace-mantis.css Diff File

master 5ac7ac60

2025-02-21 18:49

dregad


Details Diff
Merge branch 'master-2.27'

master-2.27 a498179e

2025-02-21 18:49

dregad


Details Diff
Remove HtmlApiTest.php

Messed up the cherry-pick :-/

Partial revert of commit aeaf1e1d360c3dcb1e2a82434178e3c3c488be6d.

Issue 0035322
Affected Issues
0035322
rm - tests/Mantis/HtmlApiTest.php Diff

master 2c34f191

2025-02-21 18:42

dregad


Details Diff
Merge branch 'master-2.27'
mod - core/filter_api.php Diff File
mod - core/filter_form_api.php Diff File
mod - core/html_api.php Diff File
mod - core/layout_api.php Diff File
mod - core/string_api.php Diff File
mod - images/avatar.png Diff File
mod - library/README.md Diff File
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File
mod - library/rssbuilder/class.ObjectList.inc.php Diff File
mod - library/rssbuilder/class.RSSBase.inc.php Diff File
mod - library/rssbuilder/class.RSSBuilder.inc.php Diff File
mod - library/rssbuilder/class.RSSItem.inc.php Diff File
mod - library/rssbuilder/class.RSSItemList.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_091.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_100.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_200.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_abstract.inc.php Diff File
mod - library/rssbuilder/interface.RSS.inc.php Diff File
mod - library/rssbuilder/rss_sample_script.php Diff File
mod - login_page.php Diff File
mod - login_password_page.php Diff File
mod - lost_pwd_page.php Diff File
mod - manage_proj_create_page.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_page.php Diff File
mod - manage_tags_page.php Diff File
mod - my_view_inc.php Diff File
mod - print_all_bug_page_word.php Diff File
mod - signup.php Diff File
mod - signup_page.php Diff File
mod - verify.php Diff File

master-2.27 aacb4357

2025-02-21 18:06

raspopov

Committer: community


Details Diff
Add appropriate titles to login pages

Improvements for issue 0035180.

PR https://github.com/mantisbt/mantisbt/pull/2095
Affected Issues
0035180
mod - login_page.php Diff File
mod - login_password_page.php Diff File
mod - lost_pwd_page.php Diff File
mod - signup.php Diff File
mod - signup_page.php Diff File
mod - verify.php Diff File

master-2.27 7d097dd7

2025-02-21 17:49

dregad

Committer: community


Details Diff
Fix HTML errors and warnings

Issues reported by Nu Html Checker:

- Error: Stray end tag i in filter_print_view_type_toggle()
- Error: Element option without attribute label must not be empty in
filter_draw_selection_area()
- Error: Row 7 of a row group established by a tbody element has no
cells beginning on it
- Warning: A table row was 0 columns wide, which is less than the column
count established by the first row (8) in filter_form_draw_inputs()
- Warning: The type attribute is unnecessary for JavaScript resources in
html_javascript_link(), - html_javascript_cdn_link() and
html_head_javascript()
- Error: Illegal character in query: [ is not allowed in my_view_inc.php
- Error: End tag for body seen, but there were unclosed elements in
lost_pwd_page.php
- Error: Unclosed element div
- Warning: Consider avoiding viewport values that prevent users from
resizing documents in layout_head_meta()
- Error: An img element must have an alt attribute, except under certain
conditions in layout_login_page_logo()
- Error: Element div not allowed as child of element ul in this context
in layout_breadcrumbs()

Add a new method TableGridLayout::render_spacer() to print a HTML code
for a spacer row of current table.

Add new function string_build_query() to string_api.php, a unified call
of http_build_query().

Moved the extra code from layout_page_begin() and layout_page_end() to
new paired functions layout_main_content_row_begin() and
layout_main_content_row_end().

Fixes 0035180, PR https://github.com/mantisbt/mantisbt/pull/2096
Affected Issues
0035180
mod - core/filter_api.php Diff File
mod - core/filter_form_api.php Diff File
mod - core/html_api.php Diff File
mod - core/layout_api.php Diff File
mod - core/string_api.php Diff File
mod - lost_pwd_page.php Diff File
mod - manage_proj_create_page.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_page.php Diff File
mod - manage_tags_page.php Diff File
mod - my_view_inc.php Diff File

master-2.27 1c0e653e

2025-02-21 17:40

raspopov

Committer: community


Details Diff
Disable javascript inclusion to printed pages

JavaScripts must not be part of the print page, especially not in doc
format.

Fixes 0035314, PR https://github.com/mantisbt/mantisbt/pull/2098
Affected Issues
0035314
mod - print_all_bug_page_word.php Diff File

master-2.27 41dc1b54

2025-02-21 17:35

dregad


Details Diff
Merge branch 'pr2094' into master-2.27

PR https://github.com/mantisbt/mantisbt/pull/2094
mod - library/README.md Diff File
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File
mod - library/rssbuilder/class.ObjectList.inc.php Diff File
mod - library/rssbuilder/class.RSSBase.inc.php Diff File
mod - library/rssbuilder/class.RSSBuilder.inc.php Diff File
mod - library/rssbuilder/class.RSSItem.inc.php Diff File
mod - library/rssbuilder/class.RSSItemList.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_091.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_100.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_200.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_abstract.inc.php Diff File
mod - library/rssbuilder/interface.RSS.inc.php Diff File
mod - library/rssbuilder/rss_sample_script.php Diff File

master-2.27 efd7f6a0

2025-02-21 17:34

dregad


Details Diff
Convert RSSBuilder scripts from ISO-8859-1 to UTF-8
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File
mod - library/rssbuilder/class.RSSBase.inc.php Diff File
mod - library/rssbuilder/class.RSSBuilder.inc.php Diff File
mod - library/rssbuilder/class.RSSItem.inc.php Diff File
mod - library/rssbuilder/class.RSSItemList.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_091.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_100.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_200.inc.php Diff File
mod - library/rssbuilder/class.RSS_V_abstract.inc.php Diff File
mod - library/rssbuilder/interface.RSS.inc.php Diff File

master-2.27 eb496f31

2025-02-21 17:18

raspopov

Committer: community


Details Diff
Fix avatar.png to be a real PNG

And smaller.

Fixes 0035403, PR https://github.com/mantisbt/mantisbt/pull/2101
Affected Issues
0035403
mod - images/avatar.png Diff File

master 0a08ab12

2025-02-21 11:26

raspopov

Committer: dregad


Details Diff
Move changes from ACE to custom files

Move the "ace-mantis.css" inclusion to be last, to override ACE.

Signed-off-by: raspopov <raspopov@cherubicsoft.com>
mod - js/common.js Diff File
mod - js/ace.min.js Diff File
mod - js/ace.js Diff File
mod - css/ace.css Diff File
mod - css/ace.min.css Diff File
mod - css/ace-skins.min.css Diff File
mod - css/ace-skins.css Diff File
mod - css/ace-mantis.css Diff File
mod - core/layout_api.php Diff File

master a9a1f35e

2025-02-21 08:36

raspopov

Committer: dregad


Details Diff
Remove extra event namespace

The leftover after merging code snippets.
mod - js/ace.min.js Diff File
mod - js/ace.js Diff File

master 14af5ca4

2025-02-20 10:42

raspopov

Committer: dregad


Details Diff
Restore included pages functionality

- Restored working of top_include_page and bottom_include_page options.
- Restored generation of EVENT_LAYOUT_PAGE_HEADER event.
- Added dynamic footer resizing.

The top_include_page file is included within the navbar element, which
is fixed at the top of the page; the bottom_include_page file is
included within an existing footer or as a footer itself (on login
pages), which is also fixed at the bottom of the page. Because of this,
the include template must contain, for example, a “div” element with a
solid background.
mod - js/ace.min.js Diff File
mod - js/ace.js Diff File
mod - css/ace.css Diff File
mod - css/ace.min.css Diff File
mod - css/ace-skins.min.css Diff File
mod - css/ace-skins.css Diff File
mod - core/layout_api.php Diff File
mod - core/html_api.php Diff File

master 75f74f8a

2025-02-20 07:08

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net. [skip ci]
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_ukrainian.txt Diff File

master-2.27 d419f607

2025-02-19 10:01

raspopov


Details Diff
Restore the ordering of the page content elements

During the design of the new functions, the nesting order of the
"page-content" and "row" `div` elements was reversed. This can show up
in the appearance of unnecessary scroll bars.
mod - core/layout_api.php Diff File

master-2.27 c44a7c36

2025-02-19 09:54

raspopov


Details Diff
Revert accidentally removed "user-scalable=0"

Nu Html Checker only shows a viewport warning about "maximum-scale=1.0".

The missing "user-scalable=0" will "un-fix" the MantisBT navbar on
smartphones.
mod - core/layout_api.php Diff File

master 6d322671

2025-02-17 11:49

raspopov

Committer: dregad


Details Diff
Fix generation of incorrect absolute URL

A wrong `if` in the print_menu().

Add HtmlApiTest.

Fixes 0035322
Affected Issues
0035322
mod - core/html_api.php Diff File
add - tests/Mantis/HtmlApiTest.php Diff File

master-2.27 aeaf1e1d

2025-02-17 11:49

raspopov

Committer: dregad


Details Diff
Fix generation of incorrect absolute URL

A wrong `if` in the print_menu().

Add HtmlApiTest.

Fixes 0035322

Cherry picked from commit f8b1bc9738017ed5833ea9f501704ae40a25e76f,
without the new HtmlAPiTest.php unit test, which leverage namespacing
that is only present in the master branch.

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0035322
mod - core/html_api.php Diff File
add - tests/Mantis/HtmlApiTest.php Diff File

master-2.27 ca39eaad

2025-02-17 11:27

raspopov


Details Diff
Fix HTML error in manage_tags_page.php

Fix HTML issue reported by Nu Html Checker:

- Error: Start tag `fieldset` seen in table
mod - manage_tags_page.php Diff File

master-2.27 14953b12

2025-02-17 11:23

raspopov


Details Diff
Fix HTML errors in manage_proj_page.php

Fix HTML issues reported by Nu Html Checker:

- Error: End tag `td` seen, but there were open elements
- Error: Unclosed element `div`
mod - manage_proj_page.php Diff File

master-2.27 3acb0461

2025-02-17 10:56

raspopov


Details Diff
Fix HTML error in themanage_proj_edit_page.php

Fix HTML issue reported by Nu Html Checker:

- Error: Start tag `fieldset` seen in table.
- Error: Table column 5 established by element `th` has no cells
beginning in it
- Error: " in an unquoted attribute value.
- Warning: A table row was 7 columns wide, which is less than the column
count established by the first row (8).

Center table header cells on corresponding data cells.
mod - manage_proj_edit_page.php Diff File
 First  Prev  1 2 3 ... 36 37 38 39 40 41 42 ... 80 ... 160 ... 240 ... 320 ... 400 ... 480 ... 560 ... 640 ... 720 ... 762 763 764  Next  Last