Changesets: MantisBT

master a5aaf06b

2011-12-15 02:43

dregad


Details Diff
Fix cross-project display of custom status colors

When a custom status is defined in a different project, its custom
color was not used (displayed white) in the following cases

- view issue details page, relationship
- View Issues
- My View
- Sponsorship
- Bug group action list

This ports 1.2.x commit 7dfab37c3c79328d55aa851190a86414f5664cf0,
applying the modifications made in get_status_color() to
html_get_status_css_class().

Fixes 0013682
Affected Issues
0013682
mod - account_sponsor_page.php Diff File
mod - core/bug_group_action_api.php Diff File
mod - core/helper_api.php Diff File
mod - core/html_api.php Diff File
mod - core/relationship_api.php Diff File
mod - my_view_inc.php Diff File
mod - view_all_inc.php Diff File

master-1.2.x 7dfab37c

2011-12-15 02:43

dregad


Details Diff
Fix cross-project display of custom status colors

When a custom status is defined in a different project, its custom
color was not used (displayed white) in the following cases

- view issue details page, relationship
- View Issues
- My View
- Sponsorship
- Bug group action list

Fixes 0013682
Affected Issues
0013682
mod - account_sponsor_page.php Diff File
mod - core/bug_group_action_api.php Diff File
mod - core/helper_api.php Diff File
mod - core/relationship_api.php Diff File
mod - my_view_inc.php Diff File
mod - view_all_inc.php Diff File

master 02bd0762

2011-12-15 02:22

dregad


Details Diff
Code cleanup and optimization

- fix whitespace errors
- align to coding guidelines
- moved variable initialization out of for loop
mod - view_all_inc.php Diff File

master-1.2.x 52dbd325

2011-12-15 02:22

dregad


Details Diff
Code cleanup and optimization

- fix whitespace errors
- align to coding guidelines
- moved variable initialization out of for loop
mod - view_all_inc.php Diff File

master 57d68e4d

2011-12-15 01:31

dregad


Details Diff
Additional fixes for display of custom status

Resolves additional display issues of custom status cross-project, similar
to what was fixed in 324dbb4681255b7a1fa4cc309ab8742f028dbf43. These
can occur when "All Projects" is selected and one or more projects have
custom statuses not defined globally, in the following pages:

- View Issues
- Change Log
- Roadmap
- Sponsorship

Affects 0011323
mod - account_sponsor_page.php Diff File
mod - core/columns_api.php Diff File
mod - core/custom_function_api.php Diff File

master-1.2.x 02fed500

2011-12-15 01:31

dregad


Details Diff
Additional fixes for display of custom status

Resolves additional display issues of custom status cross-project, similar
to what was fixed in 324dbb4681255b7a1fa4cc309ab8742f028dbf43. These
can occur when "All Projects" is selected and one or more projects have
custom statuses not defined globally, in the following pages:

- View Issues
- Change Log
- Roadmap
- Sponsorship

Affects 0011323
mod - account_sponsor_page.php Diff File
mod - core/columns_api.php Diff File
mod - core/custom_function_api.php Diff File

master 3f4829c6

2011-12-14 03:20

dregad


Details Diff
Correct display custom status in cross-project relationships

In the bug relationships section in view.php, the target bug's status
was incorrectly displayed as "@X@" (where X is the status_enum id) if
the following conditions were true:
- the target bug is in a different project
- it is a custom status

This commit fixes the behavior, and displays the corresponding enum
element's language string.

2 new parameters have been added to function get_enum_element(): user
and project id (defaulted to null to preserve existing behavior). These
parameters are passed on to config_get() call, allowing to specify the
context for retrieving the enum element.

The call to get_enum_element() in function relationship_get_details()
has been altered to specify the target bug's project id.

Fixes 0011323
Affected Issues
0011323
mod - core/helper_api.php Diff File
mod - core/relationship_api.php Diff File

master-1.2.x f33c0f81

2011-12-14 03:20

dregad


Details Diff
Correct display custom status in cross-project relationships

In the bug relationships section in view.php, the target bug's status
was incorrectly displayed as "@X@" (where X is the status_enum id) if
the following conditions were true:
- the target bug is in a different project
- it is a custom status

This commit fixes the behavior, and displays the corresponding enum
element's language string.

2 new parameters have been added to function get_enum_element(): user
and project id (defaulted to null to preserve existing behavior). These
parameters are passed on to config_get() call, allowing to specify the
context for retrieving the enum element.

The call to get_enum_element() in function relationship_get_details()
has been altered to specify the target bug's project id.

Fixes 0011323
Affected Issues
0011323
mod - core/helper_api.php Diff File
mod - core/relationship_api.php Diff File

master 297c7930

2011-12-13 11:22

dregad


Details Diff
Allow mass-assign of issues to Updaters

The code handling assignment in bug_actiongroup.php had an incorrect
check for the access level of the user the issues are being assigned
to. It was checked against $t_threshold, which is the minimum access
level required of the current user to perform the action, instead of
the access level to be assigned issues to (handle_bug_threshold).

This affects MantisBT instances where Updaters (or aother role) is
allowed to handle issues (through custom Workflow Thresholds)

Fixes 0012324
Affected Issues
0012324
mod - bug_actiongroup.php Diff File

master-1.2.x 0f702d58

2011-12-13 11:22

dregad


Details Diff
Allow mass-assign of issues to Updaters

The code handling assignment in bug_actiongroup.php had an incorrect
check for the access level of the user the issues are being assigned
to. It was checked against $t_threshold, which is the minimum access
level required of the current user to perform the action, instead of
the access level to be assigned issues to (handle_bug_threshold).

This affects MantisBT instances where Updaters (or aother role) is
allowed to handle issues (through custom Workflow Thresholds)

Fixes 0012324
Affected Issues
0012324
mod - bug_actiongroup.php Diff File

master f0248c84

2011-12-11 22:22

Dentxinho


Details Diff
Removed unneeded auth check in the access API.

Some functions on the Access API (access_get_global_level,
access_get_project_level and access_has_bug_level) require an
authenticated user in order to return correct values, FALSE otherwise.

However, these functions can be used by plugins while not
authenticated, so the code was changed to allow the execution to
proceed if existing parameter $p_user_id is provided.

Fixes 0013538

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>

Original patch was modified to follow MantisBT coding guidelines and
improve the commit message
Affected Issues
0013538
mod - core/access_api.php Diff File

master-1.2.x 42eac59d

2011-12-11 22:22

Dentxinho


Details Diff
Removed unneeded auth check in the access API.

Some functions on the Access API (access_get_global_level,
access_get_project_level and access_has_bug_level) require an
authenticated user in order to return correct values, FALSE otherwise.

However, these functions can be used by plugins while not
authenticated, so the code was changed to allow the execution to
proceed if existing parameter $p_user_id is provided.

Fixes 0013538

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>

Original patch was modified to follow MantisBT coding guidelines and
improve the commit message
Affected Issues
0013538
mod - core/access_api.php Diff File

master 100dc973

2011-12-10 12:13

dregad


Details Diff
Bug actiongroup version list includes subprojects

When building the list of versions for bug group actions update fixed
in / target version, use print_version_option_list() with the flag to
retrieve versions from sub-projects.

Prior to this, whenever the group action affected bugs from more than
one project, the versions list would always be built for ALL_PROJECTS
(i.e. an empty list since there is no concept of global versions)

Fixes 0013662
Affected Issues
0013662
mod - bug_actiongroup_page.php Diff File

master-1.2.x 0923fc3a

2011-12-10 12:13

dregad


Details Diff
Bug actiongroup version list includes subprojects

When building the list of versions for bug group actions update fixed
in / target version, use print_version_option_list() with the flag to
retrieve versions from sub-projects.

Prior to this, whenever the group action affected bugs from more than
one project, the versions list would always be built for ALL_PROJECTS
(i.e. an empty list since there is no concept of global versions)

Fixes 0013662
Affected Issues
0013662
mod - bug_actiongroup_page.php Diff File

master 89ad3b25

2011-12-10 11:45

dregad


Details Diff
Improve messages when errors occur in bug group actions

Displays differentiated messages, specific to the actual error that
occured instead of always printing "You did not have appropriate
permissions to perform that action"

Thanks to mattmccutchen for the original patch.

Fixes 0013661
Affected Issues
0013661
mod - bug_actiongroup.php Diff File
mod - lang/strings_english.txt Diff File

master-1.2.x 1c7180fa

2011-12-10 11:45

dregad


Details Diff
Improve messages when errors occur in bug group actions

Displays differentiated messages, specific to the actual error that
occured instead of always printing "You did not have appropriate
permissions to perform that action"

Thanks to mattmccutchen for the original patch.

Fixes 0013661
Affected Issues
0013661
mod - bug_actiongroup.php Diff File
mod - lang/strings_english.txt Diff File

master 970fa723

2011-12-10 09:46

dregad


Details Diff
Allow clearing fixed in/target version for multiple bugs

Prior to this, trying to set the "Fixed in version" or "Target version"
fields to blank for multiple bugs at once (from the "View Issues" page)
failed with error "You did not have appropriate permissions to perform
that action", even when executed as admin. Problem does not occur when
changing to a non-empty value.

Fixes 0011801
Affected Issues
0011801
mod - bug_actiongroup.php Diff File

master-1.2.x 6afa5f78

2011-12-10 09:46

dregad


Details Diff
Allow clearing fixed in/target version for multiple bugs

Prior to this, trying to set the "Fixed in version" or "Target version"
fields to blank for multiple bugs at once (from the "View Issues" page)
failed with error "You did not have appropriate permissions to perform
that action", even when executed as admin. Problem does not occur when
changing to a non-empty value.

Fixes 0011801
Affected Issues
0011801
mod - bug_actiongroup.php Diff File

master a09e0a56

2011-12-08 09:49

rombert


Details Diff
SOAP API: proper access checks when deleting bugs

Affects 0013656 : Reporters have read/write access to existing data of other users
mod - api/soap/mc_issue_api.php Diff File

master-1.2.x df7782a6

2011-12-08 09:49

rombert


Details Diff
SOAP API: proper access checks when deleting bugs

Affects 0013656 : Reporters have read/write access to existing data of other users
mod - api/soap/mc_issue_api.php Diff File

master 0a7e866d

2011-12-08 09:46

rombert


Details Diff
SOAP API: proper access checks when deleting bugnotes

Affects 0013656 : Reporters have read/write access to existing data of other users
mod - api/soap/mc_issue_api.php Diff File

master-1.2.x 9d3f5783

2011-12-08 09:46

rombert


Details Diff
SOAP API: proper access checks when deleting bugnotes

Affects 0013656 : Reporters have read/write access to existing data of other users
mod - api/soap/mc_issue_api.php Diff File

master dd286bf8

2011-12-07 06:45

rombert


Details Diff
Fix 0012029 : minimum length of custom fields of type numeric is not checked Affected Issues
0012029
mod - core/custom_field_api.php Diff File

master-1.2.x 9c71d4f8

2011-12-07 06:45

rombert


Details Diff
Fix 0012029 : minimum length of custom fields of type numeric is not checked Affected Issues
0012029
mod - core/custom_field_api.php Diff File

master 170e9397

2011-12-07 04:55

dregad


Details Diff
Define custom field alias using id instead of name

The old method of defining a custom field alias based on the field's
name, generated SQL syntax error when trying to sort on that field in
the view issues page, if the name contains characters not valid for an
SQL identifier (e.g. '-', '(', ')', etc).

Fixes 0012404, 0012680
Affected Issues
0012404, 0012680
mod - core/filter_api.php Diff File
 First  Prev  1 2 3 ... 80 ... 160 ... 240 ... 320 ... 391 392 393 394 395 396 397 ... 400 ... 480 ... 560 ... 640 ... 720 ... 751 752 753  Next  Last