Source Control Integration

master f39d92fc 2010-03-26 08:43 dhx Details Diff	Incorrect logic in check_selected() The check_selected() function fails when the first argument is an array of strings and the second argument is an integer, float or boolean value. This patch resolves incorrect logic that led to a === type safe comparison between a string and another type. Obviously if we know the two types don't match, there is no point doing a type safe comparison on the two variables!
	mod - core/helper_api.php	Diff File
master-1.2.x 32e197f6 2010-03-21 06:37 siebrand Details Diff	Localisation updates from translatewiki.net (2010-03-21) * fixes warnings on test_langs.php for localisations with less than 40% that are not exported regularly. Signed-off-by: Siebrand Mazeland <s.mazeland@xs4all.nl>
	mod - lang/strings_norwegian_nynorsk.txt	Diff File
	mod - lang/strings_croatian.txt	Diff File
	mod - lang/strings_volapuk.txt	Diff File
	mod - lang/strings_turkish.txt	Diff File
master-1.2.x 6d940db3 2010-03-20 20:29 siebrand Details Diff	Localisation updates from translatewiki.net (2010-03-21) Signed-off-by: Siebrand Mazeland <s.mazeland@xs4all.nl>
	mod - lang/strings_swedish.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_norwegian_bokmal.txt	Diff File
	mod - lang/strings_portuguese_standard.txt	Diff File
	mod - lang/strings_hungarian.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_chinese_simplified.txt	Diff File
	mod - lang/strings_russian.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_german.txt	Diff File
	mod - lang/strings_occitan.txt	Diff File
	mod - lang/strings_japanese.txt	Diff File
	mod - lang/strings_macedonian.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_ripoarisch.txt	Diff File
	mod - lang/strings_icelandic.txt	Diff File
	mod - lang/strings_french.txt	Diff File
	mod - lang/strings_portuguese_brazil.txt	Diff File
	mod - lang/strings_slovak.txt	Diff File
	mod - lang/strings_chinese_traditional.txt	Diff File
	mod - lang/strings_ripoarisch.txt	Diff File
	mod - lang/strings_arabicegyptianspoken.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_ripoarisch.txt	Diff File
	mod - lang/strings_arabic.txt	Diff File
	mod - lang/strings_breton.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_german.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_norwegian_bokmal.txt	Diff File
	mod - lang/strings_galician.txt	Diff File
	mod - lang/strings_spanish.txt	Diff File
	mod - lang/strings_dutch.txt	Diff File
	mod - lang/strings_greek.txt	Diff File
	mod - lang/strings_chinese_simplified.txt	Diff File
	mod - lang/strings_hebrew.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_ripoarisch.txt	Diff File
	mod - lang/strings_italian.txt	Diff File
	mod - lang/strings_german.txt	Diff File
	mod - lang/strings_korean.txt	Diff File
	mod - lang/strings_urdu.txt	Diff File
	mod - lang/strings_polish.txt	Diff File
	mod - lang/strings_catalan.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_norwegian_bokmal.txt	Diff File
	mod - lang/strings_lithuanian.txt	Diff File
	mod - lang/strings_bulgarian.txt	Diff File
	mod - lang/strings_danish.txt	Diff File
	mod - lang/strings_estonian.txt	Diff File
	mod - lang/strings_norwegian_bokmal.txt	Diff File
	mod - lang/strings_ukrainian.txt	Diff File
	mod - lang/strings_finnish.txt	Diff File
	mod - lang/strings_romanian.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_chinese_simplified.txt	Diff File
	mod - lang/strings_czech.txt	Diff File
	mod - lang/strings_tagalog.txt	Diff File
	add - plugins/XmlImportExport/lang/strings_finnish.txt	Diff File
	mod - lang/strings_swissgerman.txt	Diff File
	mod - lang/strings_serbian.txt	Diff File
master-1.2.x d49073be 2010-03-20 20:11 siebrand Details Diff	Fix 0011376: New Simplified Chinese translation Please use translatewiki.net in the future. The patch in the report was quite bad. It contained faulty headers compared to the headers used in the other translation files, as well as untranslated messages. Merging these was a bitch. Still incomplete compared to what the previous version contained. Still, updated, and complete fix will come in the next translatewiki.net export. Signed-off-by: Siebrand Mazeland <s.mazeland@xs4all.nl>	Affected Issues 0011376
	mod - lang/strings_chinese_simplified.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_chinese_simplified.txt	Diff File
	add - plugins/MantisCoreFormatting/lang/strings_chinese_simplified.txt	Diff File
	add - plugins/XmlImportExport/lang/strings_chinese_simplified.txt	Diff File
master-1.2.x e573c9d8 2010-03-20 17:58 siebrand Details Diff	Fix 0011688: $s_bug_view_title missing in localization to Czech language Signed-off-by: Siebrand Mazeland <s.mazeland@xs4all.nl>	Affected Issues 0011688
	mod - lang/strings_czech.txt	Diff File
master cfc8737f 2010-03-20 17:58 siebrand Details Diff	Fix 0011688: $s_bug_view_title missing in localization to Czech language Signed-off-by: Siebrand Mazeland <s.mazeland@xs4all.nl>	Affected Issues 0011688
	mod - lang/strings_czech.txt	Diff File
master-1.2.x d087800a 2010-03-20 17:56 siebrand Details Diff	Fix 0011298: encoding bug line 841 of strings_french.txt Signed-off-by: Siebrand Mazeland <s.mazeland@xs4all.nl>	Affected Issues 0011298
	mod - lang/strings_french.txt	Diff File
master 70f8bd83 2010-03-20 17:56 siebrand Details Diff	Fix 0011298: encoding bug line 841 of strings_french.txt Signed-off-by: Siebrand Mazeland <s.mazeland@xs4all.nl>	Affected Issues 0011298
	mod - lang/strings_french.txt	Diff File
master-1.2.x e961c550 2010-03-15 11:31 jreese Details Diff	Fix 0011556: Keep category user_id during upgrade	Affected Issues 0011556
	mod - admin/install_functions.php	Diff File
master 7f21b5bd 2010-03-15 11:31 jreese Details Diff	Fix 0011556: Keep category user_id during upgrade	Affected Issues 0011556
	mod - core/install_helper_functions_api.php	Diff File
master a12b342f 2010-03-12 18:56 siebrand Details Diff	Localisation updates for from !translatewiki.net Signed-off-by: Siebrand Mazeland <s.mazeland@xs4all.nl>
	mod - lang/strings_norwegian_bokmal.txt	Diff File
	mod - lang/strings_hungarian.txt	Diff File
	mod - lang/strings_dutch.txt	Diff File
	mod - lang/strings_swissgerman.txt	Diff File
	mod - lang/strings_french.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_norwegian_bokmal.txt	Diff File
	mod - lang/strings_macedonian.txt	Diff File
	mod - lang/strings_galician.txt	Diff File
	mod - lang/strings_german.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_norwegian_bokmal.txt	Diff File
	mod - lang/strings_russian.txt	Diff File
master-1.2.x b7ca663e 2010-03-12 08:24 dhx Details Diff	Fix 0011389: set_project dropdown should return to plugin pages When the set project dropdown is used on a plugin page the user should be redirected back to the plugin page they're currently viewing. Thanks to Alexander Menk for this patch.	Affected Issues 0011389
	mod - set_project.php	Diff File
master 375a337d 2010-03-12 06:42 dhx Details Diff	Various custom field validation, filtering and performance fixes This commit is a roll-up of various bug fixes related to custom field implementations within MantisBT. In particular, multilist, checkbox and radio fields now work as expected when creating and updating bug reports as well as upon filtering on these custom field types. Fix 0011628: Checkbox custom field should allow no selections Fix 0011561: Reimplement an earlier patch to improve performance Fix 0011610: Reimplement custom field validation logic (see 0011628)	Affected Issues 0010482, 0011561, 0011610, 0011628
	mod - api/soap/mc_issue_api.php	Diff File
	mod - core/custom_field_api.php	Diff File
	mod - core/cfdefs/cfdef_standard.php	Diff File
	mod - bug_update.php	Diff File
	mod - bug_report.php	Diff File
	mod - core/filter_api.php	Diff File
master-1.2.x bbe690f3 2010-03-12 06:42 dhx Details Diff	Various custom field validation, filtering and performance fixes This commit is a roll-up of various bug fixes related to custom field implementations within MantisBT. In particular, multilist, checkbox and radio fields now work as expected when creating and updating bug reports as well as upon filtering on these custom field types. Fix 0011628: Checkbox custom field should allow no selections Fix 0011561: Reimplement an earlier patch to improve performance Fix 0011610: Reimplement custom field validation logic (see 0011628)	Affected Issues 0010482, 0011561, 0011610, 0011628
	mod - bug_report.php	Diff File
	mod - core/custom_field_api.php	Diff File
	mod - api/soap/mc_issue_api.php	Diff File
	mod - bug_update.php	Diff File
	mod - core/cfdefs/cfdef_standard.php	Diff File
	mod - core/filter_api.php	Diff File
master 4c1a2785 2010-03-12 06:34 dhx Details Diff	Fix 0011561: Database storage format of CF multilist, checkbox and radio types Once upon a time multi-select custom field types (checkbox and multiselect) were stored in the database in the format of "option1\|option2\|option3" where they should have been stored in a format of "\|option1\|option2\|option3\|". Additionally, radio custom field types were being stored in the database with an unnecessary vertical pipe prefix and suffix when there is only ever one possible value that can be assigned to a radio field. This patch introduces a new schema upgrade function that corrects the invalid storage of checkbox, multiselect and radio custom fields in the database.	Affected Issues 0011561
	mod - core/install_helper_functions_api.php	Diff File
	mod - admin/schema.php	Diff File
master-1.2.x b57e7449 2010-03-12 06:34 dhx Details Diff	Fix 0011561: Database storage format of CF multilist, checkbox and radio types Once upon a time multi-select custom field types (checkbox and multiselect) were stored in the database in the format of "option1\|option2\|option3" where they should have been stored in a format of "\|option1\|option2\|option3\|". Additionally, radio custom field types were being stored in the database with an unnecessary vertical pipe prefix and suffix when there is only ever one possible value that can be assigned to a radio field. This patch introduces a new schema upgrade function that corrects the invalid storage of checkbox, multiselect and radio custom fields in the database.	Affected Issues 0011561
	mod - admin/install_functions.php	Diff File
	mod - admin/schema.php	Diff File
master-1.2.x 402d8972 2010-03-06 12:05 jreese Details Diff	Fix 0011624: Update version refs in child projects When updating version names, we need to properly cascade those changes to child projects that are using the inherited version names. This can potentially cause an issue with child projects that have a version with the same name as the parent project, but I believe this mechanism better handles the user's intent, and prevents sites from "breaking" with the new version inheritance feature. A better solution would be to fix versions so that they are referenced by unique IDs everywhere, similar to how categories were upgraded to use IDs instead of duplicating the name everywhere. However, that solution would not be considered within the scope of 1.2 due to schema changes necessary for such a change. Also, the project hierarchy was updated slightly to allow the version API to access a full list of subprojects, including disabled projects.	Affected Issues 0011624
	mod - core/project_hierarchy_api.php	Diff File
	mod - core/version_api.php	Diff File
master fc5cb097 2010-03-06 12:05 jreese Details Diff	Fix 0011624: Update version refs in child projects When updating version names, we need to properly cascade those changes to child projects that are using the inherited version names. This can potentially cause an issue with child projects that have a version with the same name as the parent project, but I believe this mechanism better handles the user's intent, and prevents sites from "breaking" with the new version inheritance feature. A better solution would be to fix versions so that they are referenced by unique IDs everywhere, similar to how categories were upgraded to use IDs instead of duplicating the name everywhere. However, that solution would not be considered within the scope of 1.2 due to schema changes necessary for such a change. Also, the project hierarchy was updated slightly to allow the version API to access a full list of subprojects, including disabled projects.	Affected Issues 0011624
	mod - core/version_api.php	Diff File
	mod - core/project_hierarchy_api.php	Diff File
master-1.2.x b03397ad 2010-03-04 07:49 dhx Details Diff	Fix 0011561: Filtering fails for multi-select custom field types When attempting to filter bugs based on multi-select custom fields, some bugs are not returned. This is due to multi-select custom field values being stored as a string in the database with a vertical pipe character being used as a delimiter between values. We can't just check for: LIKE '%\|value\|%' We also need to check for: LIKE 'value\|%' LIKE '%\|value' = 'value' To catch all possible cases of a value being stored within a multi-select custom field string.	Affected Issues 0011561
	mod - core/database_api.php	Diff File
	mod - core/filter_api.php	Diff File
master 73d72e11 2010-03-04 07:49 dhx Details Diff	Fix 0011561: Filtering fails for multi-select custom field types When attempting to filter bugs based on multi-select custom fields, some bugs are not returned. This is due to multi-select custom field values being stored as a string in the database with a vertical pipe character being used as a delimiter between values. We can't just check for: LIKE '%\|value\|%' We also need to check for: LIKE 'value\|%' LIKE '%\|value' = 'value' To catch all possible cases of a value being stored within a multi-select custom field string.	Affected Issues 0011561
	mod - core/filter_api.php	Diff File
	mod - core/database_api.php	Diff File
master-1.2.x b7b9537d 2010-03-04 06:31 dhx Details Diff	Fix 0011610: Validate all custom field types MantisBT was only validating certain custom field types. List/checkbox style field values were not being validated making it possible for malicious users to bypass the custom field 'possible values' setting and set custom field values to be whatever they desired. All custom field types are now validated to ensure that selected values are within the bounds of the 'possible values' setting of each custom field. This patch also fixes the radio custom field type so that it no longer behaves like a field with multiple possible values. Only one value can be specified for a radio field, hence there is no need to treat it like an array within gpc_api.	Affected Issues 0011610
	mod - core/gpc_api.php	Diff File
	mod - core/cfdefs/cfdef_standard.php	Diff File
	mod - core/custom_field_api.php	Diff File
master aa2742da 2010-03-04 06:31 dhx Details Diff	Fix 0011610: Validate all custom field types MantisBT was only validating certain custom field types. List/checkbox style field values were not being validated making it possible for malicious users to bypass the custom field 'possible values' setting and set custom field values to be whatever they desired. All custom field types are now validated to ensure that selected values are within the bounds of the 'possible values' setting of each custom field. This patch also fixes the radio custom field type so that it no longer behaves like a field with multiple possible values. Only one value can be specified for a radio field, hence there is no need to treat it like an array within gpc_api.	Affected Issues 0011610
	mod - core/gpc_api.php	Diff File
	mod - core/custom_field_api.php	Diff File
	mod - core/cfdefs/cfdef_standard.php	Diff File
master-1.2.x b1e3df6a 2010-03-04 03:29 dhx Details Diff	test_langs.php references invalid variable names PHP errors were caused on admin/test_langs.php due to inconsistent naming of variables.
	mod - admin/test_langs.php	Diff File
master cf99022f 2010-03-04 03:29 dhx Details Diff	test_langs.php references invalid variable names PHP errors were caused on admin/test_langs.php due to inconsistent naming of variables.
	mod - admin/test_langs.php	Diff File
master 6dd6e7c4 2010-03-04 02:42 dhx Details Diff	Revert "Fix 0011600: Bugnote direct links include mismatched parenthesis" This reverts commit 02185e9949d512826bc4b8dc23a6c0fb495a5888.	Affected Issues 0011600
	mod - bugnote_view_inc.php	Diff File

Changesets: MantisBT