Changesets: MantisBT
|
master-1.2.x 49070ba0 2010-07-29 09:54 Details Diff |
Prepare version and release notes for 1.2.2 | ||
| mod - doc/RELEASE | Diff File | ||
| mod - core/constant_inc.php | Diff File | ||
|
master-1.2.x 19c2a492 2010-07-29 09:52 Details Diff |
Revert "Issue 0011729: Preselect next highest status in bug_change_status" This reverts commit 886dccd9a467c892a165e7a755a6b13d0d8ed365, and fixes 0011956, but does not resolve the underlying issue of needing an explicit workflow defined for the default configuration. |
Affected Issues 0011729, 0011956 |
|
| mod - core/html_api.php | Diff File | ||
|
master-1.2.x 174e0c02 2010-07-28 18:06 Details Diff |
Localisation updates from translatewiki.net. Slight file format update touching all L10n files. |
||
| mod - plugins/XmlImportExport/lang/strings_tagalog.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_hebrew.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_slovak.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_macedonian.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_swedish.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_ripoarisch.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_italian.txt | Diff File | ||
| mod - lang/strings_swedish.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_norwegian_bokmal.txt | Diff File | ||
| add - plugins/XmlImportExport/lang/strings_portuguese_brazil.txt | Diff File | ||
| mod - lang/strings_portuguese_brazil.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_russian.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_slovak.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_galician.txt | Diff File | ||
| mod - lang/strings_japanese.txt | Diff File | ||
| mod - lang/strings_danish.txt | Diff File | ||
| mod - lang/strings_urdu.txt | Diff File | ||
| mod - lang/strings_korean.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_portuguese_standard.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_french.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_arabic.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_german.txt | Diff File | ||
| mod - lang/strings_arabicegyptianspoken.txt | Diff File | ||
| mod - lang/strings_norwegian_bokmal.txt | Diff File | ||
| mod - lang/strings_spanish.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_dutch.txt | Diff File | ||
| mod - lang/strings_portuguese_standard.txt | Diff File | ||
| mod - lang/strings_bulgarian.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_galician.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_swissgerman.txt | Diff File | ||
| mod - lang/strings_chinese_simplified.txt | Diff File | ||
| mod - lang/strings_slovene.txt | Diff File | ||
| mod - lang/strings_greek.txt | Diff File | ||
| mod - lang/strings_italian.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_chinese_simplified.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_french.txt | Diff File | ||
| mod - lang/strings_slovak.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_swissgerman.txt | Diff File | ||
| mod - lang/strings_galician.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_dutch.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_occitan.txt | Diff File | ||
| mod - lang/strings_amharic.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_bulgarian.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_lithuanian.txt | Diff File | ||
| mod - lang/strings_ripoarisch.txt | Diff File | ||
| mod - lang/strings_ukrainian.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_catalan.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_spanish.txt | Diff File | ||
| mod - lang/strings_estonian.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_french.txt | Diff File | ||
| mod - lang/strings_chinese_traditional.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_breton.txt | Diff File | ||
| mod - lang/strings_lithuanian.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_estonian.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_bulgarian.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_dutch.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_hebrew.txt | Diff File | ||
| mod - lang/strings_swissgerman.txt | Diff File | ||
| mod - lang/strings_french.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_spanish.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_occitan.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_macedonian.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_occitan.txt | Diff File | ||
| mod - lang/strings_latvian.txt | Diff File | ||
| mod - lang/strings_hungarian.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_czech.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_galician.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_chinese_simplified.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_russian.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_polish.txt | Diff File | ||
| mod - lang/strings_serbian.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_portuguese_standard.txt | Diff File | ||
| mod - lang/strings_romanian.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_german.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_tagalog.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_finnish.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_russian.txt | Diff File | ||
| mod - lang/strings_breton.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_hungarian.txt | Diff File | ||
| mod - lang/strings_afrikaans.txt | Diff File | ||
| add - plugins/XmlImportExport/lang/strings_hebrew.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_spanish.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_japanese.txt | Diff File | ||
| mod - lang/strings_russian.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_norwegian_bokmal.txt | Diff File | ||
| mod - lang/strings_czech.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_finnish.txt | Diff File | ||
| mod - lang/strings_tagalog.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_ripoarisch.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_catalan.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_hungarian.txt | Diff File | ||
| mod - lang/strings_polish.txt | Diff File | ||
| mod - lang/strings_icelandic.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_ripoarisch.txt | Diff File | ||
| mod - lang/strings_occitan.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_chinese_simplified.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_swissgerman.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_breton.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_arabicegyptianspoken.txt | Diff File | ||
| mod - lang/strings_hebrew.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_portuguese_standard.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_afrikaans.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_slovak.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_macedonian.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_breton.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_japanese.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_norwegian_bokmal.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_japanese.txt | Diff File | ||
| add - plugins/MantisCoreFormatting/lang/strings_italian.txt | Diff File | ||
| mod - lang/strings_catalan.txt | Diff File | ||
| add - plugins/XmlImportExport/lang/strings_italian.txt | Diff File | ||
| mod - lang/strings_german.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_catalan.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_finnish.txt | Diff File | ||
| mod - plugins/XmlImportExport/lang/strings_arabic.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_portuguese_brazil.txt | Diff File | ||
| mod - lang/strings_macedonian.txt | Diff File | ||
| mod - lang/strings_arabic.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_hungarian.txt | Diff File | ||
| mod - lang/strings_finnish.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_portuguese_brazil.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_german.txt | Diff File | ||
| mod - lang/strings_dutch.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_tagalog.txt | Diff File | ||
| mod - plugins/MantisGraph/lang/strings_arabic.txt | Diff File | ||
|
master-1.2.x a408c89c 2010-07-03 09:41 Details Diff |
Message tweak for s_configuration_corrupted. Suggested by Nikerabbit in http://translatewiki.net/wiki/Thread:Translating_talk:MantisBT/Mantis:S_configuration_corrupted |
||
| mod - lang/strings_english.txt | Diff File | ||
|
master cef40347 2010-07-03 05:41 Committer: Paul Richards Details Diff |
Message tweak for s_configuration_corrupted. Suggested by Nikerabbit in http://translatewiki.net/wiki/Thread:Translating_talk:MantisBT/Mantis:S_configuration_corrupted |
||
| mod - lang/strings_english.txt | Diff File | ||
|
master-1.2.x a16cd8ab 2010-07-01 13:20 Details Diff |
Localisation updates from http://translatewiki.net | ||
| mod - lang/strings_swissgerman.txt | Diff File | ||
| mod - lang/strings_german.txt | Diff File | ||
| mod - lang/strings_russian.txt | Diff File | ||
| mod - lang/strings_finnish.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_portuguese_brazil.txt | Diff File | ||
| mod - lang/strings_italian.txt | Diff File | ||
|
master c5329886 2010-06-28 03:34 Details Diff |
Issue 0011826: Convert form field autofocus scripts to jQuery This commit furthers the goal of removing inline JavaScript from within the MantisBT codebase. Instead of using inline JavaScript to toggle automatic focus on form fields we can use jQuery instead. All one needs to do is place a field within a form with the "autofocus" class specified. |
Affected Issues 0011826 |
|
| mod - lost_pwd_page.php | Diff File | ||
| mod - login_page.php | Diff File | ||
| mod - signup_page.php | Diff File | ||
| mod - javascript/dev/common.js | Diff File | ||
| mod - bug_report_page.php | Diff File | ||
| mod - core/authentication_api.php | Diff File | ||
|
master 0551d94b 2010-06-28 02:57 Details Diff |
Issue 0011826: jQuery-ise stopwatch and add JavaScript translation framework This commit furthers the goal of removing inline JavaScript from within the MantisBT codebase. The time tracking stopwatch has been converted to use jQuery removing the need to insert <script> tags outside the <head> element. A new JavaScript translations framework (javascript_translations.php) has been implemented that allows translation of strings for use in scripts. Scripts can now just use the new translations[] array where the keys match those used in the lang_get() function. For now it's necessary to define which strings need to be translated in javascript_translations.php. This is currently a very simple system as we don't have many strings that need translating. |
Affected Issues 0011826 |
|
| rm - javascript/dev/time_tracking_stopwatch.js | Diff | ||
| mod - bugnote_add_inc.php | Diff File | ||
| rm - javascript/min/time_tracking_stopwatch.js | Diff | ||
| mod - javascript/dev/common.js | Diff File | ||
| mod - core/html_api.php | Diff File | ||
| mod - bug_change_status_page.php | Diff File | ||
| add - javascript_translations.php | Diff File | ||
|
master cc873851 2010-06-27 08:31 Details Diff |
Don't use symlinks in git repo's - not all OS's support them e.g. windows. | ||
| rm - javascript/dev/jquery-ui-1.8.2.js | Diff | ||
| mod - javascript/dev/jquery-ui.js | Diff File | ||
| rm - javascript/dev/jquery-1.4.2.js | Diff | ||
| mod - javascript/dev/jquery.js | Diff File | ||
|
master ea729d74 2010-06-27 08:29 Details Diff |
Remove pre-compiled jscript files - a compile.php can be used to compile these as part of build process using the google closure compiler from code.google.com/closure/compiler/ | ||
| rm - javascript/min/ajax.js | Diff | ||
| rm - javascript/min/jscalendar/calendar-setup.js | Diff | ||
| rm - javascript/min/time_tracking_stopwatch.js | Diff | ||
| rm - javascript/min/jquery-1.4.2.js | Diff | ||
| rm - javascript/min/common.js | Diff | ||
| rm - javascript/min/jscalendar/calendar-blue.css | Diff | ||
| rm - javascript/min/jquery.js | Diff | ||
| rm - javascript/min/jquery-ui-1.8.2.js | Diff | ||
| rm - javascript/min/jquery-ui.js | Diff | ||
| rm - javascript/min/dynamic_filters.js | Diff | ||
| rm - javascript/min/xmlhttprequest.js | Diff | ||
| rm - javascript/min/jscalendar/calendar.js | Diff | ||
| rm - javascript/min/addLoadEvent.js | Diff | ||
| rm - javascript/min/jscalendar/lang/calendar-en.js | Diff | ||
| rm - javascript/min/bugFilter.js | Diff | ||
|
master b77ea9cd 2010-06-23 11:00 Details Diff |
Fix 0009117: Replace Projax with jQuery UI Autocomplete Projax is an old outdated library that is no longer maintained. This commit completely removes Projax from MantisBT and replaces it with a more modern jQuery UI Autocomplete equivalent. XMLHTTPRequest now returns JSON encoded data to jQuery so plugins and other pages can perform AJAX functions using standard methods for transferring data. |
Affected Issues 0009117 |
|
| rm - javascript/min/projax/effects.js | Diff | ||
| mod - bug_report_page.php | Diff File | ||
| rm - javascript/min/projax/prototype.js | Diff | ||
| rm - javascript/dev/projax/MIT-LICENSE | Diff | ||
| rm - javascript/min/projax/MIT-LICENSE | Diff | ||
| mod - bug_update_advanced_page.php | Diff File | ||
| rm - javascript/dev/projax/scriptaculous.js | Diff | ||
| rm - javascript/dev/projax/slider.js | Diff | ||
| rm - library/projax/classes/Prototype.php | Diff | ||
| rm - javascript/min/projax/builder.js | Diff | ||
| rm - javascript/dev/projax/prototype_b.js | Diff | ||
| rm - javascript/min/projax/prototype_b.js | Diff | ||
| rm - javascript/dev/projax/license.html | Diff | ||
| rm - javascript/min/projax/license.html | Diff | ||
| rm - javascript/min/projax/slider.js | Diff | ||
| rm - library/projax/classes/Scriptaculous.php | Diff | ||
| mod - javascript/min/common.js | Diff File | ||
| rm - javascript/min/projax/scriptaculous.js | Diff | ||
| rm - core/projax_api.php | Diff | ||
| mod - library/README.libs | Diff File | ||
| rm - library/projax/readme_mantis.txt | Diff | ||
| rm - library/projax/projax.php | Diff | ||
| mod - javascript/dev/common.js | Diff File | ||
| rm - javascript/dev/projax/effects.js | Diff | ||
| rm - javascript/min/projax/dragdrop.js | Diff | ||
| mod - core/xmlhttprequest_api.php | Diff File | ||
| rm - javascript/dev/projax/builder.js | Diff | ||
| rm - javascript/dev/projax/controls.js | Diff | ||
| rm - javascript/dev/projax/prototype.js | Diff | ||
| mod - core/html_api.php | Diff File | ||
| rm - javascript/min/projax/controls.js | Diff | ||
| rm - library/projax/index.html | Diff | ||
| rm - library/projax/classes/JavaScript.php | Diff | ||
| rm - javascript/dev/projax/dragdrop.js | Diff | ||
|
master 84017535 2010-06-23 09:29 Committer: dhx Details Diff |
Issue 0012013: Improved ImportExportXml plugin Improvements made to the importing and exporting features of this plugin: * Added support for custom fields, bugnotes and attachments * Added support for dates (date submitted, last updated) - keep dates as given in import file * Added function to easily retrieve the contents of a file (file_api.php) Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0012013 |
|
| mod - core/bugnote_api.php | Diff File | ||
| mod - core/bug_api.php | Diff File | ||
| mod - plugins/XmlImportExport/pages/export.php | Diff File | ||
| mod - plugins/XmlImportExport/ImportXml.php | Diff File | ||
| mod - core/file_api.php | Diff File | ||
| mod - plugins/XmlImportExport/ImportXml/Issue.php | Diff File | ||
| mod - bug_update.php | Diff File | ||
| mod - core/constant_inc.php | Diff File | ||
| mod - lang/strings_english.txt | Diff File | ||
|
master 11fb95de 2010-06-23 00:23 Details Diff |
Fix 0011981: Factor in view status when showing user monitor list When a user attempts to send a reminder to users about an issue they're presented with a list of users from which they can select from. This list of users is generated by determining the minimum access level required to view the issue. However the view state of the issue was not taken into consideration and thus if an issue had a private view state, users without permission to view private issues would still be shown in the user list. Thanks to Sergio Del Franco for reporting this issue and providing a patch. |
Affected Issues 0011981 |
|
| mod - bug_reminder_page.php | Diff File | ||
|
master 0b6540cb 2010-06-23 00:05 Details Diff |
Fix 0011967: Fix bug update events (both pre and post commit) The bug update events have been modified to be more useful to plugin developers. EVENT_UPDATE_BUG_DATA is a chained event type which allows plugins to compare the existing and updated bug data objects and make changes to either of these objects as appropriate. This event can also be used to invalidate a bug update for not meeting more complex rules. EVENT_UPDATE_BUG has been modified to execute after the update is committed to the database and prior to email and other notifications being sent. Again the original and updated bug data objects are provided so that plugins can compare the two objects to get a list of fields that changed during the update. |
Affected Issues 0011967 |
|
| mod - bug_update.php | Diff File | ||
| mod - docbook/developers/en/event-reference-bug.sgml | Diff File | ||
| mod - core/events_inc.php | Diff File | ||
|
master 98162161 2010-06-22 23:22 Details Diff |
Fix 0012085: Remove $g_allow_close_immediately This option is superseded by both $g_set_status_threshold and $g_allow_reporter_close and is therefore no longer necessary. |
Affected Issues 0012085 |
|
| mod - lang/strings_english.txt | Diff File | ||
| mod - lang/strings_japanese.txt | Diff File | ||
| mod - lang/strings_german.txt | Diff File | ||
| mod - lang/strings_italian.txt | Diff File | ||
| mod - manage_config_work_threshold_page.php | Diff File | ||
| mod - lang/strings_occitan.txt | Diff File | ||
| mod - lang/strings_romanian.txt | Diff File | ||
| mod - lang/strings_arabicegyptianspoken.txt | Diff File | ||
| mod - lang/strings_czech.txt | Diff File | ||
| mod - lang/strings_portuguese_brazil.txt | Diff File | ||
| mod - lang/strings_arabic.txt | Diff File | ||
| mod - lang/strings_swissgerman.txt | Diff File | ||
| mod - lang/strings_finnish.txt | Diff File | ||
| mod - lang/strings_hungarian.txt | Diff File | ||
| mod - lang/strings_tagalog.txt | Diff File | ||
| mod - lang/strings_polish.txt | Diff File | ||
| mod - lang/strings_dutch.txt | Diff File | ||
| mod - lang/strings_slovak.txt | Diff File | ||
| mod - lang/strings_chinese_traditional.txt | Diff File | ||
| mod - lang/strings_danish.txt | Diff File | ||
| mod - lang/strings_korean.txt | Diff File | ||
| mod - lang/strings_chinese_simplified.txt | Diff File | ||
| mod - lang/strings_estonian.txt | Diff File | ||
| mod - lang/strings_bulgarian.txt | Diff File | ||
| mod - lang/strings_catalan.txt | Diff File | ||
| mod - lang/strings_urdu.txt | Diff File | ||
| mod - lang/strings_breton.txt | Diff File | ||
| mod - docbook/adminguide/en/page_descriptions.sgml | Diff File | ||
| mod - lang/strings_greek.txt | Diff File | ||
| mod - lang/strings_russian.txt | Diff File | ||
| mod - lang/strings_hebrew.txt | Diff File | ||
| mod - bug_change_status_page.php | Diff File | ||
| mod - manage_config_work_threshold_set.php | Diff File | ||
| mod - core/obsolete.php | Diff File | ||
| mod - lang/strings_icelandic.txt | Diff File | ||
| mod - lang/strings_norwegian_bokmal.txt | Diff File | ||
| mod - lang/strings_swedish.txt | Diff File | ||
| mod - lang/strings_spanish.txt | Diff File | ||
| mod - lang/strings_galician.txt | Diff File | ||
| mod - docbook/adminguide/en/configuration.sgml | Diff File | ||
| mod - lang/strings_french.txt | Diff File | ||
| mod - config_defaults_inc.php | Diff File | ||
| mod - lang/strings_macedonian.txt | Diff File | ||
|
master 373d998a 2010-06-22 22:53 Details Diff |
Issue 0012097: Remove usage of update_mode parameter bug_update.php no longer relies upon a hidden update_mode parameter and therefore this parameter can be removed from other parts of the MantisBT codebase. |
Affected Issues 0012097 |
|
| mod - bug_update_advanced_page.php | Diff File | ||
|
master 3436d148 2010-06-22 22:16 Details Diff |
Use insecure built-in PRNG on Windows (no other options available) There are currently performance problems with using openssl_random_pseudo_bytes() on Windows servers with the latest versions of PHP 5.3. Thus with no other options available we have to use PHP's built-in insecure PRNG for generating nonces/passwords/etc. The 1.3.x branch of MantisBT introduced changes to the way MantisBT gathers entropy from PHP's internal MT PRNG so it should still be a little bit more secure than MantisBT 1.2.x. Linux/BSD platforms should still be able to use either openssl_random_pseudo_bytes() or /dev/urandom to generate strong random numbers and thus we don't allow a fallback to the insecure built-in PRNG on these platforms. |
||
| mod - core/crypto_api.php | Diff File | ||
|
master 035a1302 2010-06-22 20:44 Details Diff |
Refactor bug_update to fix multiple bugs This is a large change to bug_update.php which refactors the code to make it clearer and easier to understand. More importantly this refactoring fixes a number of bugs including the prior ability for reporters (with allow_reporter_reopen enabled) to make any modifications to the bug in question even when they didn't have permission to make those changes. This refactoring brings about a structural change to the bug update process. Previously the update checked a field (or number of fields) and then committed changes to the database before moving on to the next field. Hence it was possible for some of the requested changes to be committed to the database before a validation error kicked in, preventing the remainder of updates from being committed. The new structure of bug_update prevents partial commits from occurring as all validation and access checks are done prior to ANY data being committed to the database. If all the validation checks pass then the user can be safe in knowing that all changes should be committed to the database. If any of the validation checks fail, none of the changes have been committed. One remaining problem with this approach is the race condition whereby the administrator updates access checks between the validation of a field and the attempted committal of a field to the database. As access checks are performed internally within bug_api (and elsewhere), these could actually fail during committal (and after the validation steps in bug_update) if the access levels have changed in the meantime. This is a problem with requires rewriting much of the MantisBT codebase - all for a problem that is unlikely to occur and which is of low severity. Email notifications also need to be sorted out correctly some time in the future as it is hard to determine what the expected course of action should be. This update tries sending an email in this order: resolved, closed, reopened, handler added, status changed, bug updated. Only one email is sent so if the handler and status of an issue are updated at once and a user has refused to receive handler notifications, they won't get any email. This is because we currently give higher priority to notifying users of the addition of a handler to an issue rather than a change of status. Issue 0012097: Refactor bug_update.php Fixes 0009828: Reopen issue access check is wrong Fixes 0010226: No email on 'update->assign' Fixes 0011396: difference between closed and resolved Fixes 0011804: allow_reporter_reopen lets reporter make any update |
Affected Issues 0009828, 0010226, 0011396, 0011782, 0011804, 0012097 |
|
| mod - bug_update.php | Diff File | ||
|
master-1.2.x 429142a6 2010-06-22 12:41 Details Diff |
Localisation updates from http://translatewiki.net | ||
| mod - lang/strings_portuguese_brazil.txt | Diff File | ||
| mod - lang/strings_macedonian.txt | Diff File | ||
| mod - lang/strings_dutch.txt | Diff File | ||
| mod - lang/strings_polish.txt | Diff File | ||
| mod - lang/strings_portuguese_standard.txt | Diff File | ||
| mod - plugins/MantisCoreFormatting/lang/strings_macedonian.txt | Diff File | ||
| mod - lang/strings_german.txt | Diff File | ||
|
master 00e60da3 2010-06-21 14:00 Details Diff |
Fix 0012092: Detect SOAP API in url sniffing |
Affected Issues 0012092 |
|
| mod - config_defaults_inc.php | Diff File | ||
|
master-1.2.x cf7f557f 2010-06-21 14:00 Details Diff |
Fix 0012092: Detect SOAP API in url sniffing |
Affected Issues 0012092 |
|
| mod - config_defaults_inc.php | Diff File | ||
|
master 532b0501 2010-06-21 13:43 Details Diff |
Migrate from existing usages to form_action_self() | ||
| mod - manage_config_workflow_page.php | Diff File | ||
| mod - manage_config_work_threshold_page.php | Diff File | ||
| mod - manage_config_email_page.php | Diff File | ||
| mod - core/helper_api.php | Diff File | ||
| mod - bugnote_stats_inc.php | Diff File | ||
| mod - billing_inc.php | Diff File | ||
| mod - core/authentication_api.php | Diff File | ||
|
master-1.2.x c98310c1 2010-06-21 13:43 Details Diff |
Migrate from existing usages to form_action_self() | ||
| mod - core/authentication_api.php | Diff File | ||
| mod - bugnote_stats_inc.php | Diff File | ||
| mod - manage_config_workflow_page.php | Diff File | ||
| mod - core/helper_api.php | Diff File | ||
| mod - billing_inc.php | Diff File | ||
| mod - manage_config_work_threshold_page.php | Diff File | ||
| mod - manage_config_email_page.php | Diff File | ||
|
master 9d357c23 2010-06-21 13:43 Details Diff |
Added form_action_self() API function Helper function to generate a form action value when forms are designed to be submitted to the same url that's is currently being used, such as helper_ensure_confirmed() or auth_reauthenticate(). Designed to fix issues with using reverse proxies that rewrite URLs for the application server. By using a standard self-relative form action, it prevents issues where SCRIPT_NAME on the application server does not match the URL that the client is using. |
||
| mod - core/form_api.php | Diff File | ||
|
master-1.2.x 193f3be7 2010-06-21 13:43 Details Diff |
Added form_action_self() API function Helper function to generate a form action value when forms are designed to be submitted to the same url that's is currently being used, such as helper_ensure_confirmed() or auth_reauthenticate(). Designed to fix issues with using reverse proxies that rewrite URLs for the application server. By using a standard self-relative form action, it prevents issues where SCRIPT_NAME on the application server does not match the URL that the client is using. |
||
| mod - core/form_api.php | Diff File | ||