Changesets: MantisBT

master 9f8516e8

2010-04-14 12:09

jreese


Details Diff
Prevent plugin init if schema upgrade needed

In cases where plugins have an updated schema list, but the system
administrator has not yet upgraded the schema from the plugin management
page, the system should fail to initialize that plugin. This will
prevent confusing and misleading errors from database_api because of
missing or incorrect table definitions.
mod - core/plugin_api.php Diff File

master-1.2.x 5ef2ad87

2010-04-08 17:13

jreese


Details Diff
Fix 0011773: Plugin init process edge case

This fixes the plugin initialization code so that it will continue to
attempt plugin init passes as long as at least one plugin was
initialized during the previous pass. This fixes the edge cases where
plugins in complex dependency chains could remain uninitialized by the
previous logic.
Affected Issues
0011773
mod - core/plugin_api.php Diff File

master b66fbc3b

2010-04-08 17:13

jreese


Details Diff
Fix 0011773: Plugin init process edge case

This fixes the plugin initialization code so that it will continue to
attempt plugin init passes as long as at least one plugin was
initialized during the previous pass. This fixes the edge cases where
plugins in complex dependency chains could remain uninitialized by the
previous logic.
Affected Issues
0011773
mod - core/plugin_api.php Diff File

master 8325b888

2010-04-07 21:10

dhx


Details Diff
Strip trailing white space from PHP files

Bundled libraries excluded.
mod - news_menu_page.php Diff File
mod - bugnote_stats_inc.php Diff File
mod - admin/index.php Diff File
mod - core/prepare_api.php Diff File
mod - core/bug_api.php Diff File
mod - api/soap/mc_enum_api.php Diff File
mod - admin/upgrade_unattended.php Diff File
mod - core/string_api.php Diff File
mod - print_all_bug_page_word.php Diff File
mod - manage_proj_create_page.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_page.php Diff File
mod - admin/check/index.php Diff File
mod - tests/soap/IssueUpdateTest.php Diff File
mod - print_all_bug_options_inc.php Diff File
mod - core/sponsorship_api.php Diff File
mod - admin/test_langs.php Diff File
mod - tests/test_config_get_set.php Diff File
mod - core/ldap_api.php Diff File
mod - main_page.php Diff File
mod - admin/email_queue.php Diff File
mod - bug_monitor_list_view_inc.php Diff File
mod - core/project_hierarchy_api.php Diff File
mod - api/soap/mc_filter_api.php Diff File
mod - plugins/MantisGraph/core/graph_api.php Diff File
mod - tests/soap/IssueAddTest.php Diff File
mod - core/columns_api.php Diff File
mod - manage_user_edit_page.php Diff File
mod - bug_sponsorship_list_view_inc.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_cumulative_bydate2.php Diff File
mod - api/soap/mc_project_api.php Diff File
mod - tests/soap/AttachmentTest.php Diff File
mod - bug_update.php Diff File
mod - summary_page.php Diff File
mod - login_page.php Diff File
mod - api/soap/mc_issue_api.php Diff File
mod - core/classes/MantisFormattingPlugin.class.php Diff File
mod - core/user_pref_api.php Diff File
mod - core/email_api.php Diff File
mod - core/classes/MantisCorePlugin.class.php Diff File
mod - core/helper_api.php Diff File
mod - manage_proj_ver_edit_page.php Diff File
mod - tests/TestConfig.php Diff File
mod - core/version_api.php Diff File
mod - tests/Mantis/StringTest.php Diff File
mod - core/profile_api.php Diff File
mod - api/soap/mc_project_attachment_api.php Diff File
mod - admin/schema.php Diff File
mod - print_all_bug_page.php Diff File
mod - lost_pwd_page.php Diff File
mod - plugins/MantisGraph/MantisGraph.php Diff File
mod - bug_update_advanced_page.php Diff File
mod - manage_overview_page.php Diff File
mod - core/graphviz_api.php Diff File
mod - api/soap/mc_issue_attachment_api.php Diff File
mod - tests/soap/FilterTest.php Diff File
mod - account_sponsor_page.php Diff File
mod - tests/soap/IssueNoteTest.php Diff File
mod - tests/soap/SoapBase.php Diff File
mod - tests/soap/LoginTest.php Diff File
mod - core/classes/MantisPlugin.class.php Diff File
mod - manage_proj_page.php Diff File
mod - account_prof_menu_page.php Diff File
mod - bugnote_add_inc.php Diff File
mod - account_page.php Diff File
mod - tests/soap/EnumTest.php Diff File
mod - api/soap/mc_file_api.php Diff File
mod - core/classes/MantisCoreWikiPlugin.class.php Diff File
mod - admin/install.php Diff File
mod - core/compress_api.php Diff File
mod - manage_plugin_page.php Diff File
mod - api/soap/mc_api.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - core/session_api.php Diff File
mod - manage_user_page.php Diff File

master abeafaa5

2010-04-07 20:45

dhx


Details Diff
Update installation minimum requirements documentation
mod - docbook/adminguide/en/installation.sgml Diff File

master b0e0795a

2010-04-07 20:24

dhx


Details Diff
Increase minimum PHP version from 5.1.0 to 5.1.2 (Hash extension)

The Hash extension is enabled by default from version 5.1.2 of PHP as
per http://www.php.net/manual/en/hash.requirements.php

It's also possible to use the PECL Hash extension with earlier versions
of PHP if someone absolutely needs to use PHP <5.1.2.
mod - doc/INSTALL Diff File
mod - core/php_api.php Diff File

master 29be32f9

2010-04-07 15:54

rombert


Details Diff
Run tests using Phing

A first, rough, version of a Phing-based build. It contains a single
real target, 'test', which runs all the PHPUnit tests, picking up a
bootstrap file as well. Two auxiliary targets, 'init' and 'clean'
are also provided.

Requires Phing > 2.4 and PHPUnit > 3.4.
mod - .gitignore Diff File
add - build.xml Diff File

master-1.2.x 749b5e65

2010-04-07 15:54

rombert


Details Diff
Run tests using Phing

A first, rough, version of a Phing-based build. It contains a single
real target, 'test', which runs all the PHPUnit tests, picking up a
bootstrap file as well. Two auxiliary targets, 'init' and 'clean'
are also provided.

Requires Phing > 2.4 and PHPUnit > 3.4.
mod - .gitignore Diff File
add - build.xml Diff File

master 9af956a3

2010-04-05 15:19

rombert


Details Diff
Verify retrieval of issues without categories

Bug 0011609: API : get issues of a project crash when category is empty reported that issues
without a category set are not retrievable using the mc_filter_get function.

A regression test is added to verify that this retrieval does indeed work.
Affected Issues
0011609
mod - tests/soap/FilterTest.php Diff File

master-1.2.x 68b7695f

2010-04-05 15:19

rombert


Details Diff
Verify retrieval of issues without categories

Bug 0011609: API : get issues of a project crash when category is empty reported that issues
without a category set are not retrievable using the mc_filter_get function.

A regression test is added to verify that this retrieval does indeed work.
Affected Issues
0011609
mod - tests/soap/FilterTest.php Diff File

master 3559cf76

2010-04-05 15:10

rombert


Details Diff
Delete issues created in testCreateIssueWithHandlerByName

IssueAddTest.testCreateIssueWithHandlerByName failed to invoke deleteAfterRun
for the created issue, which resulted in the issues existing after the test invocation
was completed.
mod - tests/soap/IssueAddTest.php Diff File

master-1.2.x a1c3192c

2010-04-05 15:10

rombert


Details Diff
Delete issues created in testCreateIssueWithHandlerByName

IssueAddTest.testCreateIssueWithHandlerByName failed to invoke deleteAfterRun
for the created issue, which resulted in the issues existing after the test invocation
was completed.
mod - tests/soap/IssueAddTest.php Diff File

master-1.2.x 0435289a

2010-04-05 01:05

dhx


Details Diff
Check if timezone functions exist for RHEL/CentOS PHP builds

RHEL/CentOS PHP 5.1 builds don't have support for PHP's timezone
functions introduced with PHP 5.1. Therefore we should check if the
timezone functions exist before using them. We already perform these
checks in other parts of the MantisBT codebase.
mod - core.php Diff File

master 2278219b

2010-04-05 01:05

dhx


Details Diff
Check if timezone functions exist for RHEL/CentOS PHP builds

RHEL/CentOS PHP 5.1 builds don't have support for PHP's timezone
functions introduced with PHP 5.1. Therefore we should check if the
timezone functions exist before using them. We already perform these
checks in other parts of the MantisBT codebase.
mod - core.php Diff File

master-1.2.x 86fc322d

2010-03-31 23:16

dhx


Details Diff
Fix 0011530: Don't expose real name and email of higher users

manage_user_threshold grants permission to users so that they can modify
user accounts which have an equal or lower access level.

Therefore we shouldn't be exposing the real name and email of users on
view_user_page.php if the target user has a higher access level. The
manage user link should also not appear when the target user has a
higher access level.
Affected Issues
0011530
mod - view_user_page.php Diff File

master 7062c677

2010-03-31 23:16

dhx


Details Diff
Fix 0011530: Don't expose real name and email of higher users

manage_user_threshold grants permission to users so that they can modify
user accounts which have an equal or lower access level.

Therefore we shouldn't be exposing the real name and email of users on
view_user_page.php if the target user has a higher access level. The
manage user link should also not appear when the target user has a
higher access level.
Affected Issues
0011530
mod - view_user_page.php Diff File

master-1.2.x 886dccd9

2010-03-31 10:18

dhx


Details Diff
Issue 0011729: Preselect next highest status in bug_change_status

The bug change status dropdown list currently preselects the
first/lowest status as the default. It would be more useful if the
default value selected was the next highest status from the current
status. Failing that (for closed issues) we should revert back to using
the highest available status as the default.
Affected Issues
0011729
mod - core/html_api.php Diff File

master 820b45be

2010-03-31 10:18

dhx


Details Diff
Issue 0011729: Preselect next highest status in bug_change_status

The bug change status dropdown list currently preselects the
first/lowest status as the default. It would be more useful if the
default value selected was the next highest status from the current
status. Failing that (for closed issues) we should revert back to using
the highest available status as the default.
Affected Issues
0011729
mod - core/html_api.php Diff File

master 25223c9e

2010-03-31 09:17

dhx


Details Diff
Fix 0011530: Support multiple access levels above manage_user_threshold

Traditionally manage_user_threshold was thought of as being an absolute
global threshold which would allow any user the ability to modify any
other user account. Thus manage_user_threshold effectively had to be the
same as admin_site_threshold because users with manage_user_threshold
could just modify accounts to escalate their permissions to the maximum
level.

This patch prevents users from modifying accounts which have an access
level greater than their own. It also prevents users from creating
accounts with with access levels greater than their own.

Thus it is now possible to use manage_user_threshold as a separate
permission level to admin_site_threshold. Users with an access level
between manage_user_threshold <= user access level <
admin_site_threshold can no longer escalate their permissions or modify
the accounts of other users with a higher access level.
Affected Issues
0011530
mod - manage_proj_user_remove.php Diff File
mod - manage_proj_user_copy.php Diff File
mod - manage_user_prune.php Diff File
mod - core/project_api.php Diff File
mod - manage_user_edit_page.php Diff File
mod - manage_user_proj_add.php Diff File
mod - manage_user_proj_delete.php Diff File
mod - manage_user_delete.php Diff File
mod - manage_user_update.php Diff File
mod - account_prefs_reset.php Diff File
mod - account_prefs_update.php Diff File
mod - manage_user_page.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_user_create.php Diff File
mod - manage_user_reset.php Diff File
mod - manage_user_create_page.php Diff File

master-1.2.x 67f43bde

2010-03-31 09:17

dhx


Details Diff
Fix 0011530: Support multiple access levels above manage_user_threshold

Traditionally manage_user_threshold was thought of as being an absolute
global threshold which would allow any user the ability to modify any
other user account. Thus manage_user_threshold effectively had to be the
same as admin_site_threshold because users with manage_user_threshold
could just modify accounts to escalate their permissions to the maximum
level.

This patch prevents users from modifying accounts which have an access
level greater than their own. It also prevents users from creating
accounts with with access levels greater than their own.

Thus it is now possible to use manage_user_threshold as a separate
permission level to admin_site_threshold. Users with an access level
between manage_user_threshold <= user access level <
admin_site_threshold can no longer escalate their permissions or modify
the accounts of other users with a higher access level.
Affected Issues
0011530
mod - manage_user_proj_add.php Diff File
mod - manage_user_prune.php Diff File
mod - manage_user_delete.php Diff File
mod - account_prefs_update.php Diff File
mod - manage_user_proj_delete.php Diff File
mod - account_prefs_reset.php Diff File
mod - manage_user_page.php Diff File
mod - manage_user_edit_page.php Diff File
mod - manage_user_create_page.php Diff File
mod - manage_user_reset.php Diff File
mod - manage_user_create.php Diff File
mod - core/project_api.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_user_copy.php Diff File
mod - manage_proj_user_remove.php Diff File
mod - manage_user_update.php Diff File

master-1.2.x f845ed54

2010-03-31 06:11

dhx


Details Diff
Fix 0011362: Use readfile instead of custom file_send_chunk

PHP's inbuilt readfile() function already does its own internal
chunking. We should use this function instead of our own file chunk
reading function to improve reliability and performance.
Affected Issues
0011362
mod - file_download.php Diff File

master fbfdfe40

2010-03-31 06:11

dhx


Details Diff
Fix 0011362: Use readfile instead of custom file_send_chunk

PHP's inbuilt readfile() function already does its own internal
chunking. We should use this function instead of our own file chunk
reading function to improve reliability and performance.
Affected Issues
0011362
mod - file_download.php Diff File

master 9527e0ef

2010-03-31 05:29

dhx


Details Diff
Issue 0011732: Remove built-in source code integration support

The built-in source code integration support is old, restrictive and not
actively maintained. The far superior SourceIntegration plugin
provides the same functionality and much more (in a modular fashion).
Affected Issues
0011732
mod - plugins/MantisCoreFormatting/lang/strings_portuguese_brazil.txt Diff File
mod - lang/strings_spanish.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_slovak.txt Diff File
mod - lang/strings_finnish.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_french.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_finnish.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_russian.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_afrikaans.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_ripoarisch.txt Diff File
mod - lang/strings_macedonian.txt Diff File
mod - docbook/adminguide/en/customizing_mantis.sgml Diff File
mod - plugins/MantisCoreFormatting/lang/strings_spanish.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_hungarian.txt Diff File
mod - lang/strings_arabicegyptianspoken.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_russian.txt Diff File
mod - plugins/MantisCoreFormatting/pages/config.php Diff File
mod - plugins/MantisCoreFormatting/lang/strings_dutch.txt Diff File
mod - plugins/MantisCoreFormatting/MantisCoreFormatting.php Diff File
mod - core/history_api.php Diff File
mod - lang/strings_czech.txt Diff File
mod - docbook/adminguide/en/configuration.sgml Diff File
mod - lang/strings_catalan.txt Diff File
mod - lang/strings_polish.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_norwegian_bokmal.txt Diff File
mod - lang/strings_bulgarian.txt Diff File
mod - api/soap/mc_issue_api.php Diff File
mod - plugins/MantisCoreFormatting/lang/strings_breton.txt Diff File
mod - lang/strings_occitan.txt Diff File
mod - core/obsolete.php Diff File
mod - lang/strings_dutch.txt Diff File
mod - lang/strings_chinese_simplified.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_occitan.txt Diff File
mod - lang/strings_breton.txt Diff File
mod - lang/strings_japanese.txt Diff File
mod - lang/strings_tagalog.txt Diff File
mod - core/string_api.php Diff File
mod - lang/strings_lithuanian.txt Diff File
mod - plugins/MantisCoreFormatting/pages/config_edit.php Diff File
mod - core/custom_function_api.php Diff File
mod - lang/strings_portuguese_brazil.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_english.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_german.txt Diff File
mod - lang/strings_hebrew.txt Diff File
mod - lang/strings_estonian.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_portuguese_standard.txt Diff File
mod - core/constant_inc.php Diff File
mod - lang/strings_chinese_traditional.txt Diff File
mod - scripts/README Diff File
mod - lang/strings_icelandic.txt Diff File
mod - lang/strings_galician.txt Diff File
mod - lang/strings_korean.txt Diff File
mod - lang/strings_danish.txt Diff File
mod - lang/strings_slovak.txt Diff File
mod - lang/strings_swedish.txt Diff File
mod - lang/strings_urdu.txt Diff File
mod - lang/strings_english.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_catalan.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_hebrew.txt Diff File
mod - lang/strings_norwegian_bokmal.txt Diff File
rm - scripts/checkin.php Diff
mod - plugins/MantisCoreFormatting/lang/strings_galician.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_swissgerman.txt Diff File
mod - lang/strings_german.txt Diff File
mod - config_defaults_inc.php Diff File
mod - lang/strings_arabic.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_japanese.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_macedonian.txt Diff File
mod - api/soap/mantisconnect.php Diff File
mod - lang/strings_hungarian.txt Diff File
mod - lang/strings_swissgerman.txt Diff File

master 666e231f

2010-03-31 03:01

dhx


Details Diff
Issue 0011728: Add Fileinfo checks to admin/check/

Add some further checks to check_attachments_inc.php as part of the new
configuration/environment check script in 1.3.x to verify that Fileinfo
is configured correctly.
Affected Issues
0011728
mod - admin/check/check_attachments_inc.php Diff File

master-1.2.x b81d2302

2010-03-31 02:09

dhx


Details Diff
Issue 0011404: Record dropping of bug revisions in bug history

This patch has been backported from the 1.3.x branch in accordance with
issue 0011727.

When dropping bug revisions (bugnotes, description, steps to reproduce
and additional information) we should be recording this event in the bug
history. This maintains an audit log of who and at what time revision
data was permanently deleted.

This commit also fixes an issue whereby links in the history were still
shown for bug revisions that had been dropped. Users would thus click a
link to come across a 'revision not found' error message.
Affected Issues
0011404, 0011727
mod - core/bug_revision_api.php Diff File
mod - lang/strings_english.txt Diff File
mod - core/constant_inc.php Diff File
mod - core/history_api.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 473 474 475 476 477 478 479 ... 490 ... 560 ... 630 ... 700 ... 746 747 748  Next  Last