Source Control Integration

master be57bb8c 2009-10-28 19:06 dhx Details Diff	ob_end_clean should be called BEFORE headers are sent Follow-up to commit b341ca89c83b9d906b229d289c35dfcc1185b034 ob_end_clean throws away the output buffer instead of flushing it to the client. Therefore we should call this BEFORE the file download headers are sent to the client or else these headers could potentially be thrown away/lost. Note to self: don't rely upon incorrect comments in the code that tell you ob_end_clean flushes the buffer... look it up in the PHP manual!	Affected Issues 0011101
	mod - file_download.php	Diff File
master fb8383a2 2009-10-28 18:30 Paul Richards Details Diff	Fix whitespace introduced on 20th September by commit git.mantisforge.org/w/mantisbt.git?a=blobdiff;f=core/compress_api.php;fp=core/compress_api.php;hb=61804a9da622dd0519fea853924bdab5bddbd933;hpb=f657c277db6b00cd2f63cb43a4c506acc4095482
	mod - core/compress_api.php	Diff File
master-1.2.x 087445ce 2009-10-28 12:18 rombert Details Diff	Fixes 0011015: mc_issue_update erases 'Due date' field The due_date field has been added to the WSDL and is now exposed by mc_issue_get and accepted by mc_issue_add and mc_issue_update. Proper access checkes are in place. The due_date is read with the local time zone offset applied since nusoap seems to apply the offset wrong when parsing. Reference: http://www.nabble.com/NUSOAP-datetime-UTC-issue-td16627310.html Tests have been added for both adding and updating an issue, skipped if the thresholds don't allow the admin user to view and update the due date.	Affected Issues 0011015
	mod - tests/soap/SoapBase.php	Diff File
	mod - api/soap/mantisconnect.php	Diff File
	mod - tests/soap/IssueAddTest.php	Diff File
	mod - tests/soap/IssueUpdateTest.php	Diff File
	mod - api/soap/mc_issue_api.php	Diff File
master 29d70634 2009-10-28 12:18 rombert Details Diff	Fixes 0011015: mc_issue_update erases 'Due date' field The due_date field has been added to the WSDL and is now exposed by mc_issue_get and accepted by mc_issue_add and mc_issue_update. Proper access checkes are in place. The due_date is read with the local time zone offset applied since nusoap seems to apply the offset wrong when parsing. Reference: http://www.nabble.com/NUSOAP-datetime-UTC-issue-td16627310.html Tests have been added for both adding and updating an issue, skipped if the thresholds don't allow the admin user to view and update the due date.	Affected Issues 0011015
	mod - tests/soap/SoapBase.php	Diff File
	mod - api/soap/mantisconnect.php	Diff File
	mod - tests/soap/IssueAddTest.php	Diff File
	mod - tests/soap/IssueUpdateTest.php	Diff File
	mod - api/soap/mc_issue_api.php	Diff File
master-1.2.x ba426dbb 2009-10-28 02:58 vboctor Details Diff	Fixes 0010841: Target Version not cleared when Version is deleted.	Affected Issues 0010841
	mod - core/version_api.php	Diff File
master c8a9d4a5 2009-10-28 02:58 vboctor Details Diff	Fixes 0010841: Target Version not cleared when Version is deleted.	Affected Issues 0010841
	mod - core/version_api.php	Diff File
master-1.2.x 8faebae6 2009-10-27 12:36 rombert Details Diff	Fixes 0010592: mc_enum functions doesn't take customization into account The mc_enum_xxx functions have been updated to return the customised keys, while the names remain the translated ones. mc_enum_get has not been updated, as it returns a raw enum string, not an ObjectRefArray. Unfortunately no new tests can be added since we don't control the customisation settings on the mantis installation on a per-test basis. - split functionality from mc_issue_get - explode_bla_bla now takes a enumeration name - localized labels are properly used	Affected Issues 0010592
	mod - api/soap/mc_enum_api.php	Diff File
master 834c8ed7 2009-10-27 12:36 rombert Details Diff	Fixes 0010592: mc_enum functions doesn't take customization into account The mc_enum_xxx functions have been updated to return the customised keys, while the names remain the translated ones. mc_enum_get has not been updated, as it returns a raw enum string, not an ObjectRefArray. Unfortunately no new tests can be added since we don't control the customisation settings on the mantis installation on a per-test basis. - split functionality from mc_issue_get - explode_bla_bla now takes a enumeration name - localized labels are properly used	Affected Issues 0010592
	mod - api/soap/mc_enum_api.php	Diff File
master 5c784edd 2009-10-27 06:01 dhx Details Diff	Issue 0007917: "Update Information" button at top of update form This patch from stappel extends the use of the existing $g_action_button_position configuration option to apply to the "Update Information" button on the bug update form. This can make it a little bit quicker/easier to update a bug without scrolling all the way down the page to reach the bottom of the form. Again, this is optional and disabled by default.	Affected Issues 0007917
	mod - bug_update_advanced_page.php	Diff File
master-1.2.x d8fb6b21 2009-10-27 06:01 dhx Details Diff	Issue 0007917: "Update Information" button at top of update form This patch from stappel extends the use of the existing $g_action_button_position configuration option to apply to the "Update Information" button on the bug update form. This can make it a little bit quicker/easier to update a bug without scrolling all the way down the page to reach the bottom of the form. Again, this is optional and disabled by default.	Affected Issues 0007917
	mod - bug_update_advanced_page.php	Diff File
master-1.2.x 829e821b 2009-10-27 05:34 dhx Details Diff	Fix 0011086: project_id column shows a number instead of the project name	Affected Issues 0011086
	mod - core/columns_api.php	Diff File
master 29c972c7 2009-10-27 05:34 dhx Details Diff	Fix 0011086: project_id column shows a number instead of the project name	Affected Issues 0011086
	mod - core/columns_api.php	Diff File
master-1.2.x ff2d2ab8 2009-10-27 05:24 dhx Details Diff	Send headers before output buffer is flushed for file_download.php Content-* headers and etc should be sent before the output buffer is flushed at the start of file transfers. These headers have also been reordered so they're grouped together more logically. Also inline_file_exts can now be blank without the 'gif' attachment being forcefully added by Mantis.	Affected Issues 0011101
	mod - file_download.php	Diff File
master b341ca89 2009-10-27 05:24 dhx Details Diff	Send headers before output buffer is flushed for file_download.php Content-* headers and etc should be sent before the output buffer is flushed at the start of file transfers. These headers have also been reordered so they're grouped together more logically. Also inline_file_exts can now be blank without the 'gif' attachment being forcefully added by Mantis.	Affected Issues 0011101
	mod - file_download.php	Diff File
master-1.2.x faa14562 2009-10-27 04:29 dhx Details Diff	Issue 0011075: Fix copy/paste error in file_get_extension Commit 07c8da02a96216b87842190cca2777e82a668d1f introduced a copy/paste error within the file_get_extension function that prevented it from splitting the extension off a filename.	Affected Issues 0011075
	mod - core/file_api.php	Diff File
master 13403565 2009-10-27 04:29 dhx Details Diff	Issue 0011075: Fix copy/paste error in file_get_extension Commit 07c8da02a96216b87842190cca2777e82a668d1f introduced a copy/paste error within the file_get_extension function that prevented it from splitting the extension off a filename.	Affected Issues 0011075
	mod - core/file_api.php	Diff File
master-1.2.x 77c59569 2009-10-27 04:21 rombert Details Diff	Add FilterTest to AllTests in the SOAP configuration
	mod - tests/soap/AllTests.php	Diff File
master b9ccfc48 2009-10-27 04:21 rombert Details Diff	Add FilterTest to AllTests in the SOAP configuration
	mod - tests/soap/AllTests.php	Diff File
master-1.2.x efac9eb2 2009-10-27 02:34 dhx Details Diff	Add warning to configuration page for disabling text processing The consequences of disabling text processing without knowing what it does are very serious. Therefore users should be warned not to turn off text processing.
	mod - plugins/MantisCoreFormatting/lang/strings_english.txt	Diff File
	mod - plugins/MantisCoreFormatting/pages/config.php	Diff File
master 0b6e1800 2009-10-27 02:34 dhx Details Diff	Add warning to configuration page for disabling text processing The consequences of disabling text processing without knowing what it does are very serious. Therefore users should be warned not to turn off text processing.
	mod - plugins/MantisCoreFormatting/lang/strings_english.txt	Diff File
	mod - plugins/MantisCoreFormatting/pages/config.php	Diff File
master-1.2.x f2035d37 2009-10-27 02:02 dhx Details Diff	Fix 0011075: Add Content-Disposition workaround for Internet Explorer/Chrome Internet Explorer and Chrome don't support RFC2231 and also ignore the fallback method currently implemented in MantisBT. See http://greenbytes.de/tech/tc2231/#attfnboth2 for the current method. We can however use another method to display UTF8 filenames to IE and Chrome. This workaround is actually in breach in RFC2231. See http://greenbytes.de/tech/tc2231/#attwithfnrawpctenclong for details. We use this method when the user agent is determined to be IE or Chrome. Otherwise we just keep using the original RFC2231 fallback technique mentioned above. It also appears that urlencode() is the wrong method to use for encoding filenames. Browsers seem to expect %20 as a space instead of +. Thus we should use rawurlencode() instead for the old method of encoding URLs. RFC2231 actually contains examples with %20 being used. Some minor cleanups were also performed in relation to sending the Content-Disposition header and also performing browser checks.	Affected Issues 0009775, 0011075
	mod - file_download.php	Diff File
	mod - core/http_api.php	Diff File
	mod - core/file_api.php	Diff File
	mod - print_all_bug_page_word.php	Diff File
master 07c8da02 2009-10-27 02:02 dhx Details Diff	Fix 0011075: Add Content-Disposition workaround for Internet Explorer/Chrome Internet Explorer and Chrome don't support RFC2231 and also ignore the fallback method currently implemented in MantisBT. See http://greenbytes.de/tech/tc2231/#attfnboth2 for the current method. We can however use another method to display UTF8 filenames to IE and Chrome. This workaround is actually in breach in RFC2231. See http://greenbytes.de/tech/tc2231/#attwithfnrawpctenclong for details. We use this method when the user agent is determined to be IE or Chrome. Otherwise we just keep using the original RFC2231 fallback technique mentioned above. It also appears that urlencode() is the wrong method to use for encoding filenames. Browsers seem to expect %20 as a space instead of +. Thus we should use rawurlencode() instead for the old method of encoding URLs. RFC2231 actually contains examples with %20 being used. Some minor cleanups were also performed in relation to sending the Content-Disposition header and also performing browser checks.	Affected Issues 0009775, 0011075
	mod - core/file_api.php	Diff File
	mod - core/http_api.php	Diff File
	mod - file_download.php	Diff File
	mod - print_all_bug_page_word.php	Diff File
master-1.2.x c25fc512 2009-10-26 18:29 rombert Details Diff	Record patching of NuSOAP in README.libs
	mod - library/README.libs	Diff File
master-1.2.x 895b7a14 2009-10-26 18:05 rombert Details Diff	Fixes 0010969: Verify that closed issues are retrieved by mc_project_get_issues Following a bug report which hints that mc_project_get_issues may be ignoring closed issues, two tests are introduced: - verify that a newly created issue is retrieved by mc_project_get_issues with the correct id; - verify that a newly created issue with closed status is retrieved by mc_project_get_issues;	Affected Issues 0010969
	add - tests/soap/FilterTest.php	Diff File
master 571ed585 2009-10-26 18:05 rombert Details Diff	Fixes 0010969: Verify that closed issues are retrieved by mc_project_get_issues Following a bug report which hints that mc_project_get_issues may be ignoring closed issues, two tests are introduced: - verify that a newly created issue is retrieved by mc_project_get_issues with the correct id; - verify that a newly created issue with closed status is retrieved by mc_project_get_issues;	Affected Issues 0010969
	add - tests/soap/FilterTest.php	Diff File

Changesets: MantisBT