Changesets: MantisBT

master-1.2.x 2c505b17

2009-09-22 03:44

dhx


Details Diff
Issue 0010929: Fix typo dezember=>december

There was a typo with the spelling of "December" in commit
1ad85ad6c1276e4ef0632c31637185f62e7e873d
Affected Issues
0010929
mod - lang/strings_english.txt Diff File

master 5814da84

2009-09-22 03:44

dhx


Details Diff
Issue 0010929: Fix typo dezember=>december

There was a typo with the spelling of "December" in commit
1ad85ad6c1276e4ef0632c31637185f62e7e873d
Affected Issues
0010929
mod - lang/strings_english.txt Diff File

master-1.2.x 733e53b0

2009-09-22 02:41

dhx


Details Diff
Complete move of graphing abilities to MantisGraph

The move of the graphing abilities from the core into a new MantisGraph
plugin wasn't fully completed. This large patch completes the move by
ripping out remaining parts of graphing support from the core, and
moving them into the plugin.

Some of the things that have changed as a result of this commit:

1. Deprecated the graph_font configuration option in the core and added
it back to the plugin configuration. This time there is a nicer UI for
selecting the font from within the plugin configuration screen.

2. Deprecated the graph_colors option from the core and disabled this
functionality in the plugin. This will obviously require a lot more work
(outside the scope of what I can do at the moment) so that there is a
better way for the user to select colours via the UI configuration page.
Additionally, this option shouldn't just be restrictied to JpGraph.
Graph colours need to be reimplemented properly at a later stage.

3. Deprecated the default_graph_type option from the core and disabled
this functionality in the plugin. This was a very cryptic non-documented
option that set the default plot type on bug_graph_page. If this is to
be reimplemented, it needs to be done so properly so that it isn't
cryptic and unusable. There is no real loss of functionality with the
removal of this option.

4. Reordered the layout of configuration options in the plugin
configuration page so similar options are grouped together. It also
looks much nicer now thanks to some changes to strings, and the
placement of comments on a second line in small text.

5. Moved all strings used solely by MantisGraph into the plugin. The
original strings have been removed from the core as they aren't used
there.

6. Removed references to the graph related options from the
Configuration section of the Administrator Guide.

7. Moved class.period.php from the core to the MantisGraph plugin as it
currently isn't used elsewhere within Mantis. Really this class should
be part of the core of Mantis (under
core/classes/MantisPeriod.class.php) but it'll need some more work
before it can be used in other parts of Mantis. For instance, we don't
use this class for date filters. More importantly, PHP has a built-in
class called DatePeriod (and DateInterval) that appear to be better
choices for future work with date periods.

8. Added a UI field in the plugin configuration page that is only
accessible to users with access level >= admin_site_threshold to set
what once used to be $g_jpgraph_path.
mod - plugins/MantisGraph/pages/summary_graph_byresolution_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bystatus_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bypriority_pct.php Diff File
mod - summary_page.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bystatus.php Diff File
mod - plugins/MantisGraph/pages/config.php Diff File
mod - config_defaults_inc.php Diff File
mod - plugins/MantisGraph/core/graph_api.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_byresolution_mix.php Diff File
mod - plugins/MantisGraph/pages/config_edit.php Diff File
mod - core/obsolete.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_priority.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_byseverity_mix.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_severity.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_status.php Diff File
mod - plugins/MantisGraph/lang/strings_english.txt Diff File
mod - plugins/MantisGraph/pages/summary_graph_bycategory_pct.php Diff File
mod - lang/strings_english.txt Diff File
mod - plugins/MantisGraph/pages/bug_graph_page.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_category.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_byseverity_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_resolution.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bypriority_mix.php Diff File
mod - plugins/MantisGraph/MantisGraph.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bycategory.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_cumulative_bydate2.php Diff File
mod - docbook/adminguide/en/configuration.sgml Diff File

master 82dd624c

2009-09-22 02:41

dhx


Details Diff
Complete move of graphing abilities to MantisGraph

The move of the graphing abilities from the core into a new MantisGraph
plugin wasn't fully completed. This large patch completes the move by
ripping out remaining parts of graphing support from the core, and
moving them into the plugin.

Some of the things that have changed as a result of this commit:

1. Deprecated the graph_font configuration option in the core and added
it back to the plugin configuration. This time there is a nicer UI for
selecting the font from within the plugin configuration screen.

2. Deprecated the graph_colors option from the core and disabled this
functionality in the plugin. This will obviously require a lot more work
(outside the scope of what I can do at the moment) so that there is a
better way for the user to select colours via the UI configuration page.
Additionally, this option shouldn't just be restrictied to JpGraph.
Graph colours need to be reimplemented properly at a later stage.

3. Deprecated the default_graph_type option from the core and disabled
this functionality in the plugin. This was a very cryptic non-documented
option that set the default plot type on bug_graph_page. If this is to
be reimplemented, it needs to be done so properly so that it isn't
cryptic and unusable. There is no real loss of functionality with the
removal of this option.

4. Reordered the layout of configuration options in the plugin
configuration page so similar options are grouped together. It also
looks much nicer now thanks to some changes to strings, and the
placement of comments on a second line in small text.

5. Moved all strings used solely by MantisGraph into the plugin. The
original strings have been removed from the core as they aren't used
there.

6. Removed references to the graph related options from the
Configuration section of the Administrator Guide.

7. Moved class.period.php from the core to the MantisGraph plugin as it
currently isn't used elsewhere within Mantis. Really this class should
be part of the core of Mantis (under
core/classes/MantisPeriod.class.php) but it'll need some more work
before it can be used in other parts of Mantis. For instance, we don't
use this class for date filters. More importantly, PHP has a built-in
class called DatePeriod (and DateInterval) that appear to be better
choices for future work with date periods.

8. Added a UI field in the plugin configuration page that is only
accessible to users with access level >= admin_site_threshold to set
what once used to be $g_jpgraph_path.
mod - plugins/MantisGraph/lang/strings_english.txt Diff File
mod - plugins/MantisGraph/pages/summary_graph_byresolution_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bystatus_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bypriority_pct.php Diff File
mod - plugins/MantisGraph/pages/config.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_byresolution_mix.php Diff File
mod - plugins/MantisGraph/pages/config_edit.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_cumulative_bydate2.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_priority.php Diff File
mod - core/obsolete.php Diff File
mod - config_defaults_inc.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_byseverity_mix.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_severity.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_status.php Diff File
mod - summary_page.php Diff File
mod - plugins/MantisGraph/core/graph_api.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bycategory_pct.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_page.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_category.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bycategory.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_byseverity_pct.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_resolution.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_bypriority_mix.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bystatus.php Diff File
mod - plugins/MantisGraph/MantisGraph.php Diff File
mod - lang/strings_english.txt Diff File
mod - docbook/adminguide/en/configuration.sgml Diff File

master-1.2.x 8977d9c3

2009-09-21 15:27

frodgers

Committer: dhx


Details Diff
Fix 0010971: Email about new bug sent before plugins are notified

Email is sent in bug_report.php before plugins are notified via
EVENT_REPORT_BUG to post-process data. This results in missing or
incorrect information in the email.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010971
mod - bug_report.php Diff File

master 3cb1185b

2009-09-21 15:27

frodgers

Committer: dhx


Details Diff
Fix 0010971: Email about new bug sent before plugins are notified

Email is sent in bug_report.php before plugins are notified via
EVENT_REPORT_BUG to post-process data. This results in missing or
incorrect information in the email.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010971
mod - bug_report.php Diff File

master-1.2.x 5b448d2f

2009-09-20 11:20

Danez

Committer: dhx


Details Diff
Fix 0010915: Description field data not shown

class BugData now notices if the requested field is an extended or not, and then fetches the extended data if needed.
A small bug was also fixed in the print function for steps_to_reproduce. Printed additional_info instead of steps_to_reproduce.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010915
mod - issues_rss.php Diff File
mod - csv_export.php Diff File
mod - plugins/XmlImportExport/pages/export.php Diff File
mod - core/bug_api.php Diff File
mod - core/columns_api.php Diff File

master f9ab82ea

2009-09-20 11:20

Danez

Committer: dhx


Details Diff
Fix 0010915: Description field data not shown

class BugData now notices if the requested field is an extended or not, and then fetches the extended data if needed.
A small bug was also fixed in the print function for steps_to_reproduce. Printed additional_info instead of steps_to_reproduce.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010915
mod - core/bug_api.php Diff File
mod - issues_rss.php Diff File
mod - csv_export.php Diff File
mod - plugins/XmlImportExport/pages/export.php Diff File
mod - core/columns_api.php Diff File

master-1.2.x c896ad16

2009-09-20 08:55

Danez

Committer: dhx


Details Diff
Issue 0010967: Check for existence of ini_set function before use

On some servers, the administrator may have disabled the use of the
ini_set function for security reasons (using the disabled_functions PHP
configuration option).

We should check to make sure ini_set is available before we try to call
it.

Also use set_magic_quotes_runtime() instead of doing an ini_set on the
"magic_quotes_runtime" option. This function is deprecated as of PHP
5.3.0 but at least we can do a function_exists() check on it.
Affected Issues
0010967
mod - file_download.php Diff File
mod - core/string_api.php Diff File
mod - core/php_api.php Diff File
mod - core/compress_api.php Diff File

master 61804a9d

2009-09-20 08:55

Danez

Committer: dhx


Details Diff
Issue 0010967: Check for existence of ini_set function before use

On some servers, the administrator may have disabled the use of the
ini_set function for security reasons (using the disabled_functions PHP
configuration option).

We should check to make sure ini_set is available before we try to call
it.

Also use set_magic_quotes_runtime() instead of doing an ini_set on the
"magic_quotes_runtime" option. This function is deprecated as of PHP
5.3.0 but at least we can do a function_exists() check on it.
Affected Issues
0010967
mod - core/string_api.php Diff File
mod - core/php_api.php Diff File
mod - file_download.php Diff File
mod - core/compress_api.php Diff File

master-1.2.x 5f78466f

2009-09-20 07:40

Danez

Committer: dhx


Details Diff
Fix 0010929: Use localizeable function strftime() instead of date()

This commit adds the possibility to translate month names in lang-files.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010929
mod - lang/strings_english.txt Diff File
mod - core/date_api.php Diff File

master 1ad85ad6

2009-09-20 07:40

Danez

Committer: dhx


Details Diff
Fix 0010929: Use localizeable function strftime() instead of date()

This commit adds the possibility to translate month names in lang-files.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010929
mod - lang/strings_english.txt Diff File
mod - core/date_api.php Diff File

master-1.2.x e93ab8b4

2009-09-17 11:20

Chris Fitch

Committer: dhx


Details Diff
Fix 0010959: Incorrect variable name in tag_update function

After a tag is renamed, associated reports are supposed to get an issue
history entry indicating so. The history_log_event_special() call in
tag_update() passes the wrong variable in for the tag name, causing a
database error to occur.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010959
mod - core/tag_api.php Diff File

master ca9b4def

2009-09-17 11:20

Chris Fitch

Committer: dhx


Details Diff
Fix 0010959: Incorrect variable name in tag_update function

After a tag is renamed, associated reports are supposed to get an issue
history entry indicating so. The history_log_event_special() call in
tag_update() passes the wrong variable in for the tag name, causing a
database error to occur.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010959
mod - core/tag_api.php Diff File

master-1.2.x 694037a6

2009-09-17 09:56

Chris Fitch

Committer: dhx


Details Diff
Fix 0010956: Fix line wrap regex for preformatted text

The string_nl2br() function doesn't look for whitespace before wrapping
a line when the text is in a <pre> block.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010956
mod - core/string_api.php Diff File

master 0fd12b74

2009-09-17 09:56

Chris Fitch

Committer: dhx


Details Diff
Fix 0010956: Fix line wrap regex for preformatted text

The string_nl2br() function doesn't look for whitespace before wrapping
a line when the text is in a <pre> block.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010956
mod - core/string_api.php Diff File

master-1.2.x 79f04e92

2009-09-15 08:47

dhx


Details Diff
Fix 0010940: Reopen button sends incorrect parameter to bug_change_status.php

Commit 546e72b12e8149041ce2a55d7e5b511639e823b4 changed the 'bug_id'
parameter of bug_change_status.php to just 'id'.

However the html_button_bug_reopen function hadn't been updated as a
result of the renaming of the bug_id parameter. This resulted in an
application error #200 appearing when users clicked on the 'Reopen'
button on an issue.
Affected Issues
0010940
mod - core/html_api.php Diff File

master 4b5059c2

2009-09-15 08:47

dhx


Details Diff
Fix 0010940: Reopen button sends incorrect parameter to bug_change_status.php

Commit 546e72b12e8149041ce2a55d7e5b511639e823b4 changed the 'bug_id'
parameter of bug_change_status.php to just 'id'.

However the html_button_bug_reopen function hadn't been updated as a
result of the renaming of the bug_id parameter. This resulted in an
application error #200 appearing when users clicked on the 'Reopen'
button on an issue.
Affected Issues
0010940
mod - core/html_api.php Diff File

master-1.2.x 3507d1f6

2009-09-15 06:29

dhx


Details Diff
Obsolete 'advanced' config options removed in earlier commit

Commit 7c8910853c0232605c79a4345418d4e932812de5 removed some
configuration options relating to advanced vs simple views. There
configuration options thus need to be marked as obsolete in obsolete.php
mod - core/obsolete.php Diff File

master f5e51781

2009-09-15 06:29

dhx


Details Diff
Obsolete 'advanced' config options removed in earlier commit

Commit 7c8910853c0232605c79a4345418d4e932812de5 removed some
configuration options relating to advanced vs simple views. There
configuration options thus need to be marked as obsolete in obsolete.php
mod - core/obsolete.php Diff File

master-1.2.x aa34cdfd

2009-09-12 20:13

jreese


Details Diff
Fix 0010930: Fix verification redirect loop

User verification was logging out the user, and then calling auth_api
functions that implicitly logged in the anonymous user, resulting in an
endless redirection loop. By adding a parameter to the appropriate
auth_api function, the verification page can specify that the anonymous
user should not be implicitly logged in.
Affected Issues
0010930
mod - core/authentication_api.php Diff File

master 0abe9b45

2009-09-12 20:13

jreese


Details Diff
Fix 0010930: Fix verification redirect loop

User verification was logging out the user, and then calling auth_api
functions that implicitly logged in the anonymous user, resulting in an
endless redirection loop. By adding a parameter to the appropriate
auth_api function, the verification page can specify that the anonymous
user should not be implicitly logged in.
Affected Issues
0010930
mod - core/authentication_api.php Diff File

master 2a53ece7

2009-09-10 04:16

dhx


Details Diff
Fix 0010922: Prevent jscalendar from being imported more than once

jscalendar doesn't work if it's included more than once (recursion error
according to Firefox's Error Console). The date_print_calendar()
function always used to include the javascript each time it was called.
However this function can be called multiple times on a page load and it
therefore shouldn't include the same javascript/css files each time.
This function has been changed to import the javascript/css files only
on the first instance.
Affected Issues
0010922
mod - core/date_api.php Diff File

master-1.2.x 3773caf4

2009-09-10 04:16

dhx


Details Diff
Fix 0010922: Prevent jscalendar from being imported more than once

jscalendar doesn't work if it's included more than once (recursion error
according to Firefox's Error Console). The date_print_calendar()
function always used to include the javascript each time it was called.
However this function can be called multiple times on a page load and it
therefore shouldn't include the same javascript/css files each time.
This function has been changed to import the javascript/css files only
on the first instance.
Affected Issues
0010922
mod - core/date_api.php Diff File

master-1.2.x cb0318cb

2009-09-10 03:42

dhx


Details Diff
Fix 0010748: Fix CSS include for jscalendar

The CSS required for jscalendar was not included properly. Additionally,
there was some left over code that doesn't apply to the jscalendar
widget that MantisBT has been using. This useless code has been removed.
Affected Issues
0010748
mod - core/date_api.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 481 482 483 484 485 486 487 ... 490 ... 560 ... 630 ... 700 ... 729 730 731  Next  Last