Changesets: MantisBT

i30278-remove-cftype-const b06b3e45

2022-05-17 09:15

dregad


Details Diff
Consistently set type class for custom field columns

'cftype-textarea' class was introduced to fix wrapping for textarea
custom fields, as part of the patch for the regression on overflow-wrap
(see 0030268).

Assign a 'cftype-xxx' class to Custom Field columns of any type, where
xxx is the type (label) defined in $g_custom_field_type_enum_string,
with a simple transformation to ensure it is a valid CSS identifier.

Issue 0030279
Affected Issues
0030279
mod - core/custom_function_api.php Diff File

i30278-remove-cftype-const 7a77360c

2022-05-16 12:03

dregad


Details Diff
Apply overflow-wrap more selectively

Issue 0027114 introduced a regression in the bugnotes count column's
display on View Issues page.

We now only target those fields susceptible to have long, unbreakable
content (i.e. textarea fields), by

- adding markup to Textarea custom fields (`cftype-textarea` class)
- using more precise CSS selectors for description, steps-to-reproduce,
additional-information and bugnotes, as well as Textarea custom fields
(using the new cftype-textarea class).

Fixes 0030268
Affected Issues
0027114, 0030268
mod - bug_view_inc.php Diff File
mod - core/custom_function_api.php Diff File
mod - css/ace-mantis.css Diff File

master 20cd415e

2022-05-16 08:51

dregad

Committer: community


Details Diff
Restrict access to Export and Print Reports

Adds 2 new config options to control access restrictions to these View
Issues page functionalities:

- CSV/Excel Export ($g_export_issues_threshold)
- Print Reports ($g_print_reports_threshold)

The default value for print_reports_threshold is UPDATER, to reduce the
risk of denial of service attacks overloading the server via multiple
concurrent executions of print_all_bug_page_word.php. This changes from
earlier behavior, where access to this function was not restricted.

Fixes 0022224, 0025492,
PR https://github.com/mantisbt/mantisbt/pull/1810
Affected Issues
0022224, 0025492
mod - config_defaults_inc.php Diff File
mod - css/default.css Diff File
mod - csv_export.php Diff File
mod - docbook/Admin_Guide/en-US/config/misc.xml Diff File
mod - excel_xml_export.php Diff File
mod - lang/strings_english.txt Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - manage_config_work_threshold_set.php Diff File
mod - print_all_bug_page.php Diff File
mod - print_all_bug_page_word.php Diff File
mod - view_all_inc.php Diff File

master 1aa2f6f0

2022-05-16 07:06

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net.
mod - lang/strings_polish.txt Diff File
mod - lang/strings_russian.txt Diff File
mod - lang/strings_saraiki.txt Diff File

master 267418c1

2022-05-16 05:55

dregad


Details Diff
Add new configs to Workflow Thresholds page

Issue 0022224
Affected Issues
0022224
mod - lang/strings_english.txt Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - manage_config_work_threshold_set.php Diff File

master-2.25 c54a3794

2022-05-13 09:24

dregad


Details Diff
Use filter key instead of URL to build permalink

Refactor permalink_page.php to accept a temporary filter key and
generate the URL from that, instead of receiving a fully-formed URL.

This prevents issues when the filter criteria contain a `&` (e.g. a
category named "a & b"), causing the value to be interpreted as 2
distinct parameters due to string_sanitize_url() decoding the `%26`
before processing the query string.

Fixes 0030204
Affected Issues
0030204
mod - core/filter_api.php Diff File
mod - permalink_page.php Diff File

master 22c2d1da

2022-05-13 09:23

dregad


Details Diff
Squelsh PHPStorm warning [skip ci]
mod - core/constant_inc.php Diff File

master 3cc574ba

2022-05-12 11:22

dregad


Details Diff
Replace deprecated bgcolor attribute by CSS Affected Issues
0031944
mod - css/default.css Diff File
mod - view_all_inc.php Diff File

master 32dea980

2022-05-12 11:08

dregad


Details Diff
Fix indentation
mod - view_all_inc.php Diff File

master 843c24af

2022-05-12 10:57

dregad


Details Diff
Fix PHPStorm warnings
mod - view_all_inc.php Diff File

master 0c66cee2

2022-05-12 10:32

dregad


Details Diff
Move helper function to end of file

Having the write_bug_rows() function in the middle of the markup makes
the code difficult to read and defeats the purpose of having it a
function in the first place...
mod - view_all_inc.php Diff File

master 23de65dc

2022-05-12 10:18

dregad


Details Diff
Only display toolbar if there's something to show
mod - view_all_inc.php Diff File

master ee1f3e33

2022-05-12 09:04

dregad


Details Diff
Default $g_print_reports_threshold to UPDATER

Considering that the Print Reports functionality can be leveraged to
perform DOS attacks, it is safer to set $g_print_reports_threshold* to
`UPDATER`, so it is not accessible out of the box by anonymous or
self-registered users.
mod - config_defaults_inc.php Diff File
mod - docbook/Admin_Guide/en-US/config/misc.xml Diff File

master 89f382be

2022-05-12 08:19

dregad


Details Diff
Rewording the new configs' documentation
mod - config_defaults_inc.php Diff File
mod - docbook/Admin_Guide/en-US/config/misc.xml Diff File

master 9a5de3b8

2022-05-12 08:01

dregad


Details Diff
Missing access check on print_all_bug_page_word.php
mod - print_all_bug_page_word.php Diff File

master d8ec9cb9

2022-05-12 07:06

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net.
mod - lang/strings_japanese.txt Diff File
mod - lang/strings_polish.txt Diff File
mod - lang/strings_russian.txt Diff File

master 8c4bbc73

2022-05-10 19:22

dregad


Details Diff
Merge branch 'master-2.25'

This is a "fake" merge, effectively ignoring changes from commit
6135907829c5aaf15d0ba40266e76bc5e1e45655 which is a revert that should
only be applied to 2.25 branch.

# Conflicts:
# core/constant_inc.php

[skip ci]

master 528e0206

2022-05-10 19:19

dregad


Details Diff
Set version to 2.25.4-dev

[skip ci]
mod - core/constant_inc.php Diff File

master-2.25 61359078

2022-05-10 19:01

dregad


Details Diff
Revert "Use null-coalescing operator"

This language construct is not supported on PHP 5.6.

Partial revert of the backport commit 4f4e176d5e87dd835e5d646ab3de938c1e103f8a
(effectively reverting 7dd6c512a8e658e26c31dcd3bc393538f85ec166 from
master branch).

Fixes 0030193
Affected Issues
0030193
mod - core/bug_api.php Diff File

master 35a14e3b

2022-05-10 13:03

dregad


Details Diff
Add newlines to make generated HTML easier to read
mod - changelog_page.php Diff File
mod - roadmap_page.php Diff File

master 140fc80e

2022-05-10 12:57

dregad


Details Diff
Use print_extra_small_button()

Instead of manually building the buttons with <a> tags.
mod - changelog_page.php Diff File
mod - roadmap_page.php Diff File

master ccf9664d

2022-05-10 12:31

dregad


Details Diff
Print changelog/roadmap items as unordered list

Add HTML markup so that each individual entry of the changelog/roadmap
is printed as a <li> element within an <ul>, instead of them being all
printed in a single div without any structure.

This facilitates copy/paste of rendered changelog into an external
changelog.

Fixes 0030192
Affected Issues
0030192
mod - changelog_page.php Diff File
mod - core/custom_function_api.php Diff File
mod - css/ace-mantis.css Diff File
mod - roadmap_page.php Diff File

master ed717fba

2022-05-10 09:37

dregad


Details Diff
Merge tag 'release-2.25.4'

Stable release 2.25.4

# Conflicts:
# core/constant_inc.php

master-2.25 77aa1001

2022-05-10 09:35

dregad


Details Diff
Bump version to 2.25.4

Signed-off-by: Damien Regad <dregad@mantisbt.org>
mod - core/constant_inc.php Diff File

master c1cb709f

2022-05-10 09:16

dregad


Details Diff
Merge branch 'master-2.25'
mod - .travis.yml Diff File
 First  Prev  1 2 3 ... 66 67 68 69 70 71 72 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 737 738 739  Next  Last