Changesets: MantisBT

Search Browse Back to Index

master 8e0c80b9

2002-12-06 13:48

Julian Fitzell


Details Diff		 Have to run so I'm committing this work in progress

- Renamed several manage_proj_custom_field_* files to manage_custom_field_*
- Added a mange_custom_field_page.php
- Added a 'Manage Custom Fields' item to the manage menu
- Split custom_field_get_ids() into a new function custom_field_get_bound_ids() and updated references to it

My theory is that we can let managers go to the manage custom fields page but they'll only see a list of fields and their types, etc. Administrators will be able to actually modify them and add/delete them.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1651 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/custom_field_api.php Diff File
mod - print_all_bug_page_word.php Diff File
mod - print_bug_page.php Diff File
mod - bug_report.php Diff File
mod - bug_view_page.php Diff File
mod - core/html_api.php Diff File
add - manage_custom_field_page.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - bug_update_advanced_page.php Diff File
mod - core/email_api.php Diff File
mod - bug_update.php Diff File
mod - bug_update_page.php Diff File
mod - bug_view_advanced_page.php Diff File
mod - lang/strings_english.txt Diff File
mod - bug_report_page.php Diff File
mod - bug_report_advanced_page.php Diff File

master 25f479d9

2002-12-06 13:24

Julian Fitzell


Details Diff		 remove colons for consistency

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1650 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - lang/strings_english.txt Diff File
mod - lang/strings_german.txt Diff File

master 39c05017

2002-12-06 13:01

Julian Fitzell


Details Diff		 This commit moves the 'sequence' column from mantis_custom_field_table to mantis_custom_field_project_table. You'll need to either drop your custom field tables and add new ones, or manually remove the sequence column from the former and add it to the latter before the code will work again.

There is now currently no interface to modify the sequence for a binding. I figure we can do this when we rework the interface.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1649 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/custom_field_api.php Diff File
mod - manage_proj_custom_field_update.php Diff File
mod - manage_proj_custom_field_edit_page.php Diff File

master 10aca0bc

2002-12-06 10:01

vboctor


Details Diff		 - Added support for custom fields in e-mail notifications.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1648 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/email_api.php Diff File

master f2e06158

2002-12-06 04:12

vboctor


Details Diff		 Some custom fields work:
- bug_delete() did not delete custom values associated with the bug.
- project_delete() did not delete the custom field associations.
- Removed colons after field name in View Bug (Advanced) Pages as it was not consistent
with the rest of the fields.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1647 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - bug_view_advanced_page.php Diff File
mod - core/bug_api.php Diff File
mod - core/project_api.php Diff File
mod - bug_view_page.php Diff File

master ff5b7fab

2002-12-05 04:07

Julian Fitzell


Details Diff		 I started playing with the custom field stuff tonight and these are the fixes I had to make to get it working. I also cleaned up the manage_* pages a little.

---

* manage_proj_custom_field_add_existing.php:
+ use gpc_* to get form fields
+ custom_field_bind() errors if there's a problem so there's no need to display our own error
* manage_proj_custom_field_add_new.php:
+ use gpc_* to get form fields
+ use is_blank() instead of ==''
+ add $t_ prefix to $duplicate
* manage_proj_custom_field_delete.php:
+ use gpc_* to get form fields
+ remove unneeded use of $t_affected_projects
+ we can't print $query since such a variable doesn't exist. Also custom_field_delete() errors itself.
* manage_proj_custom_field_edit_page.php:
+ use gpc_* to get form fields
+ correct spelling of sequence as 'seqence'
* manage_proj_custom_field_remove.php:
+ use gpc_* to get form fields
+ custom_field_remove() errors if there's a problem so there's no need to display our own error
* manage_proj_custom_field_update.php:
+ use gpc_get_bool() to get f_advanced
+ correct spelling of sequence as 'seqence'
+ custom_field_update() errors if there's a problem so there's no need to display our own error
* core/custom_field_api.php
(custom_field_ensure_name_unique): new function that call custom_field_is_name_unique() and errors if it returns false
(custom_field_create): make sure the name is unique before creating a new field
(custom_field_bind): move db_prepare_* calls to top of function for clarity
(custom_field_update): use db_prepare_bool() for the advanced field
* lang/strings_english.txt
(s_custom_field_seqence): correct spelling of sequence as 'seqence' (in variable name and contents)
(s_custom_field_type_enum_string): correct spelling of enumeration as 'enummeration'
* lang/strings_german.txt
(s_custom_field_seqence): rename to s_custom_field_sequence (spelling error)

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1646 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - manage_proj_custom_field_add_existing.php Diff File
mod - manage_proj_custom_field_update.php Diff File
mod - manage_proj_custom_field_edit_page.php Diff File
mod - lang/strings_english.txt Diff File
mod - core/custom_field_api.php Diff File
mod - lang/strings_german.txt Diff File
mod - manage_proj_custom_field_remove.php Diff File
mod - manage_proj_custom_field_delete.php Diff File
mod - manage_proj_custom_field_add_new.php Diff File

master 4b3fcb76

2002-12-05 02:23

Julian Fitzell


Details Diff		 * custom_field_api.php
(mantis_custom_field_table): the key on project_id is not longer valid since there is no project_id column. Add a key on 'name' instead

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1645 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/custom_field_api.php Diff File

master b093f6e7

2002-12-04 14:42

Julian Fitzell


Details Diff		 * ldap_api.php
(ldap_connect_bind): correct mixup between DN and password

Patch by Robert Foster <rfoster@mountainvisions.com.au>

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1644 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/ldap_api.php Diff File

master 5981c530

2002-12-04 06:17

Julian Fitzell


Details Diff		 add the copyright to mantis developers to this file

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1643 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - README Diff File

master e0065992

2002-12-04 05:31

Julian Fitzell


Details Diff		 Added Yves Durasnel as a contributor

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1642 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - doc/CREDITS Diff File

master 7299813c

2002-12-04 05:30

Julian Fitzell


Details Diff		 * doc/README.LDAP: correct a few typos using $t_ instead of $g_
* doc/configuration.html: change g_ldap_organisation to g_ldap_organization
* config_defaults_inc.php
(g_ldap_bind_dn): add config variable
(g_ldap_bind_passwd): add config variable
(g_ldap_organisation): removed in favour of g_ldap_organization
(g_ldap_organization): replacing g_ldap_organisation for consistency
(g_ldap_port): add config variable
* core/ldap_api.php: change g_ldap_organisation to g_ldap_organization
* core/obsolete.php: add an entry to notify that g_ldap_organisation is obsolete and g_ldap_organization is now used

I hope this is right. I originally was fixing the problem that Robert's new config options weren't initialized in the default config file. Then I noticed the two typos in the README. Then I noticed that our config option spelled organisation with an 's' but the LDAP field name (and most of the example of organizationName I could find relating to LDAP on Google spelled it with a 'z'.

If anyone objects, I can revert this. I wouldn't normally rename a variable name because of an alternate spelling but this seems to be a case where we're not using what everyone else uses in this context.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1641 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - config_defaults_inc.php Diff File
mod - doc/configuration.html Diff File
mod - core/obsolete.php Diff File
mod - core/ldap_api.php Diff File
mod - doc/README.LDAP Diff File

master dc57aff4

2002-12-04 05:27

Julian Fitzell


Details Diff		 * core/print_api.php
(print_project_user_option_list): renamed to print_project_access_levels_option_list()
(print_project_access_levels_option_list): new name for print_project_user_option_list()
* manage_user_page.php: change call from print_project_user_option_list() to print_project_access_levels_option_list()
* proj_user_menu_page.php: change call from print_project_user_option_list() to print_project_access_levels_option_list()

This is part of a patch from Yves Durasnel <yves@durasnel.com>.

This function was poorly named and he was adding a function that really wanted the name this function used to use.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1640 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - manage_user_page.php Diff File
mod - proj_user_menu_page.php Diff File
mod - core/print_api.php Diff File

master a2e8c50d

2002-12-04 03:05

Julian Fitzell


Details Diff		 Add code throughout the system to exercise the custom fields API. It is currently all blocked off with if checks on the config variable 'use_experimental_custom_fields' so make sure to set that to ON in your config file if you want to play with it.

This patch is from Christian Mayer <Christian.Mayer@hexal.de>

I've reviewed it to make sure it doesn't do anything nasty to existing code and I'm committing it now because I think it will be easier to fix things and make comments when it's in CVS.

I apologize for the formatting fixes and helper_alternate_class() calls added in the same patch, I'm too tired to put in the effort to pull them out into seperate commits.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1639 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - constant_inc.php Diff File
mod - lang/strings_german.txt Diff File
mod - manage_proj_custom_field_update.php Diff File
mod - manage_proj_custom_field_add_existing.php Diff File
mod - bug_update_page.php Diff File
mod - bug_report.php Diff File
mod - print_bug_page.php Diff File
mod - bug_report_advanced_page.php Diff File
mod - bug_update_advanced_page.php Diff File
mod - bug_view_page.php Diff File
mod - bug_view_advanced_page.php Diff File
mod - doc/custom_fields.txt Diff File
mod - print_all_bug_page_word.php Diff File
mod - core/custom_field_api.php Diff File
mod - bug_update.php Diff File
mod - manage_proj_custom_field_add_new.php Diff File
mod - config_defaults_inc.php Diff File
mod - bug_report_page.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - lang/strings_english.txt Diff File
mod - manage_proj_custom_field_edit_page.php Diff File

master bee502de

2002-12-04 01:15

Julian Fitzell


Details Diff		 Fix line endings in all files

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1638 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - css/default.css Diff File
mod - graphs/graph_reported_by_me.php Diff File
mod - admin/css/core.php Diff File
mod - core/utility_api.php Diff File
mod - manage_proj_custom_field_add_new.php Diff File
mod - admin/css/index.php Diff File
mod - graphs/graph_by_severity.php Diff File
mod - manage_proj_custom_field_add_existing.php Diff File
mod - manage_proj_custom_field_remove.php Diff File
mod - graphs/graph_by_category.php Diff File
mod - admin/css/css_inc.php Diff File
mod - graphs/graph_assigned_to_me.php Diff File
mod - admin/css/css_view.php Diff File
mod - doc/installation.html Diff File
mod - graphs/graph_by_daily_delta.php Diff File
mod - manage_proj_custom_field_update.php Diff File
mod - graphs/graph_by_release_delta.php Diff File
mod - graphs/graph_by_cumulative.php Diff File
mod - graphs/graph_by_severity_status.php Diff File
mod - admin/css/view_inc.php Diff File
mod - manage_proj_custom_field_edit_page.php Diff File
mod - manage_proj_custom_field_delete.php Diff File

master 9468ae9a

2002-12-03 22:18

Julian Fitzell


Details Diff		 * ldap_api.php
(ldap_has_group): change some "" to ''

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1637 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/ldap_api.php Diff File

master 47dc3c25

2002-12-03 22:16

Julian Fitzell


Details Diff		 * constant_inc.php: add some errors for LDAP stuff
* core/authentication_api.php
(auth_does_password_match): call ldap_authenticate() for ldap auth
* core/ldap_api.php: rewrite of ldap api
* doc/README.LDAP: update example config settings
* lang/strings_english.txt: add strings for the new LDAP errors

This is a rewrite of the LDAP api by Robert Foster <rfoster@mountainvisions.com.au>

I cleaned up quite a few things (mostly variable names and spacing) in ldap_api before committing and this hasn't been tested by me since I don't use LDAP. So if I broke it, patches welcome! :)

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1636 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/ldap_api.php Diff File
mod - constant_inc.php Diff File
mod - core/authentication_api.php Diff File
mod - doc/README.LDAP Diff File
mod - lang/strings_english.txt Diff File

master da0464ca

2002-12-03 19:58

Julian Fitzell


Details Diff		 * README.LDAP: change to unix line endings

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1635 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - doc/README.LDAP Diff File

master 862c96ea

2002-11-30 16:27

Julian Fitzell


Details Diff		 * print_api.php
(print_user): use user_api functions to get name and email to make use of caching
(print_user_with_subject): use user_api functions to get name and email to make use of caching

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1634 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/print_api.php Diff File

master 008b25f1

2002-11-30 16:15

Julian Fitzell


Details Diff		 * string_api.php
(string_process_bug_link): don't force a space when replacing, use whatever whitespace we (optionally) matched

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1633 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/string_api.php Diff File

master 88196b3d

2002-11-30 16:11

Julian Fitzell


Details Diff		 * string_api.php
(string_process_bug_link): include the title attribute with the bug's description

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1632 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/string_api.php Diff File

master ca6851f0

2002-11-29 11:46

Julian Fitzell


Details Diff		 * bug_api.php
(bug_assign): flush the bug cache before sending the email, otherwise the handler is wrong
(bug_update_date): add a call to flush the bug data after updating the date

Thanks to Jean-Francois Travers <jean-francois.travers2@fr.thalesgroup.com> for pointing out the first problem

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1631 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/bug_api.php Diff File

master 15e012ed

2002-11-27 20:23

Julian Fitzell


Details Diff		 * history_api.php
(history_get_events_array):
+ check if handler_id is 0 (unassigned) before asking for the username
+ use user_get_name() instead of user_get_field() since it handles users that have been deleted
+ reformat the switch statement for consistency while I'm here

Thanks to Andre Eisenbach for the original patch and bug report

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1630 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/history_api.php Diff File

master 886b1111

2002-11-27 00:12

Julian Fitzell


Details Diff		 * CREDITS: Victor and I are administrators so we might as well indicate that so people know who to look for

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1629 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - doc/CREDITS Diff File

master 0c839ece

2002-11-26 23:27

Julian Fitzell


Details Diff		 * CREDITS: add all the people I've taken patches from and credited in commit logs since September

gotta keep up to date on this in the future

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1628 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - doc/CREDITS Diff File

master a474d294

2002-11-26 22:07

Julian Fitzell


Details Diff		 * core/API.php: add line to load new utility_api file
* core/helper_api.php: remove some functions and move them to utility_api.php
* core/project_api.php: rename uses of helper_terminate_directory_path() to terminate_directory_path() since it is no longer in the helper_api
* core/utility_api.php: new file to hold utility functions needed by all APIs

I added a Utility API which contains little functions that need to be available to all APIs (and therefore do not have dependcies on any other APIs themselves). These are the types of little functions that do little conversions or things that should be in php but aren't, etc.

This was needed to make the is_blank() change work, otherwise there was a an ugly dependency that pushed helper_api and print_api above nearly everything else. I think helper_api needs to come after base APIs like DB and config, but before most other ones (as it is now).

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1627 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/project_api.php Diff File
mod - core/helper_api.php Diff File
mod - core/API.php Diff File
add - core/utility_api.php Diff File
 First  Prev  1 2 3 ... 80 ... 160 ... 240 ... 320 ... 400 ... 480 ... 560 ... 640 ... 702 703 704 705 706 707 708 ... 720 ... 762 763 764  Next  Last