Changesets: MantisBT

master-2.25 0d1d7b65

2022-06-13 06:03

dregad


Details Diff
Code cleanup: 1 array element per row, sorted

Issue 0030384
Affected Issues
0030384
mod - file_download.php Diff File

master 582d5d50

2022-06-12 16:57

dregad


Details Diff
Fix list.js scrolling regression patch

The list.js patch for the scrolling regression (issue 0030494, commit
7c0e2b8590c1e2c6ab17a566e14839584009a064) introduced another regression,
because preventing the default click event's execution not only applied
to the pagination buttons, but also to the checkboxes and the Apply
button as well, basically making the whole Manage Accounts section
unusable.

To fix the problem, we now only execute preventDefault() when the
pagination buttons are clicked.

Fixes 0030494
Affected Issues
0030494
mod - js/list-2.3.1.js Diff File
mod - js/list-2.3.1.min.js Diff File

master e1af8bac

2022-06-12 09:48

dregad


Details Diff
Project Edit Page improvements

Fixes 0030551, PR https://github.com/mantisbt/mantisbt/pull/1821
Affected Issues
0030551
mod - api/soap/mc_api.php Diff File
mod - core/constant_inc.php Diff File
mod - css/ace-mantis.css Diff File
mod - css/default.css Diff File
rm - js/list-1.5.0.js Diff
rm - js/list-1.5.0.min.js Diff
add - js/list-2.3.1.js Diff File
add - js/list-2.3.1.min.js Diff File
mod - js/manage_proj_edit_page.js Diff File
mod - lang/strings_afrikaans.txt Diff File
mod - lang/strings_arabic.txt Diff File
mod - lang/strings_arabicegyptianspoken.txt Diff File
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_breton.txt Diff File
mod - lang/strings_bulgarian.txt Diff File
mod - lang/strings_catalan.txt Diff File
mod - lang/strings_chinese_simplified.txt Diff File
mod - lang/strings_chinese_traditional.txt Diff File
mod - lang/strings_czech.txt Diff File
mod - lang/strings_danish.txt Diff File
mod - lang/strings_dutch.txt Diff File
mod - lang/strings_english.txt Diff File
mod - lang/strings_estonian.txt Diff File
mod - lang/strings_finnish.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_galician.txt Diff File
mod - lang/strings_german.txt Diff File
mod - lang/strings_hebrew.txt Diff File
mod - lang/strings_hungarian.txt Diff File
mod - lang/strings_icelandic.txt Diff File
mod - lang/strings_interlingua.txt Diff File
mod - lang/strings_italian.txt Diff File
mod - lang/strings_japanese.txt Diff File
mod - lang/strings_korean.txt Diff File
mod - lang/strings_lithuanian.txt Diff File
mod - lang/strings_macedonian.txt Diff File
mod - lang/strings_norwegian_bokmal.txt Diff File
mod - lang/strings_occitan.txt Diff File
mod - lang/strings_persian.txt Diff File
mod - lang/strings_polish.txt Diff File
mod - lang/strings_portuguese_brazil.txt Diff File
mod - lang/strings_portuguese_standard.txt Diff File
mod - lang/strings_ripoarisch.txt Diff File
mod - lang/strings_romanian.txt Diff File
mod - lang/strings_russian.txt Diff File
mod - lang/strings_serbian.txt Diff File
mod - lang/strings_serbian_latin.txt Diff File
mod - lang/strings_slovak.txt Diff File
mod - lang/strings_slovene.txt Diff File
mod - lang/strings_spanish.txt Diff File
mod - lang/strings_swedish.txt Diff File
mod - lang/strings_swissgerman.txt Diff File
mod - lang/strings_tagalog.txt Diff File
mod - lang/strings_turkish.txt Diff File
mod - lang/strings_ukrainian.txt Diff File
mod - lang/strings_urdu.txt Diff File
mod - lang/strings_vietnamese.txt Diff File
mod - lang/strings_volapuk.txt Diff File
mod - library/README.md Diff File
mod - manage_custom_field_edit_page.php Diff File
mod - manage_proj_cat_add.php Diff File
mod - manage_proj_cat_copy.php Diff File
mod - manage_proj_cat_delete.php Diff File
mod - manage_proj_cat_edit_page.php Diff File
mod - manage_proj_cat_update.php Diff File
mod - manage_proj_create.php Diff File
mod - manage_proj_custom_field_add_existing.php Diff File
mod - manage_proj_custom_field_copy.php Diff File
mod - manage_proj_custom_field_remove.php Diff File
mod - manage_proj_custom_field_update.php Diff File
mod - manage_proj_delete.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_page.php Diff File
mod - manage_proj_subproj_add.php Diff File
mod - manage_proj_subproj_delete.php Diff File
mod - manage_proj_update_children.php Diff File
mod - manage_proj_user_add.php Diff File
mod - manage_proj_user_copy.php Diff File
mod - manage_proj_user_update.php Diff File
mod - manage_proj_ver_add.php Diff File
mod - manage_proj_ver_copy.php Diff File
mod - manage_proj_ver_delete.php Diff File
mod - manage_proj_ver_edit_page.php Diff File
mod - manage_proj_ver_update.php Diff File

master 3d88f684

2022-06-12 09:38

dregad


Details Diff
CSS: adjust height of .btn-sm class

Setting the height to 30px allows proper vertical alignment of toolbar
buttons when print_form_button() is used next to a form containing a
select.

Without this, the button's height is 28.9333px, causing a slight offset.

Fixes 0030550
Affected Issues
0030550
mod - css/ace-mantis.css Diff File

master e8993b7e

2022-06-12 09:24

dregad


Details Diff
Move create button after add suproject form

Per @atrol's suggestion [[1]], improve UI consistency by moving the
Create New Subproject button to the right of the Add as Subproject form,
so the project selection drop down is the first element in the toolbar,
like in other sections on the page (Categories, Versions, etc).

[1]: https://github.com/mantisbt/mantisbt/pull/1821#issuecomment-1147325872
mod - manage_proj_edit_page.php Diff File

dependabot/composer/adodb/adodb-php-5.22.2 e6d1663f

2022-06-12 06:10

dependabot[bot]

Committer: community


Details Diff
Bump adodb/adodb-php from 5.21.4 to 5.22.2

Bumps [adodb/adodb-php](https://github.com/ADOdb/ADOdb) from 5.21.4 to 5.22.2.
- [Release notes](https://github.com/ADOdb/ADOdb/releases)
- [Changelog](https://github.com/ADOdb/ADOdb/blob/master/docs/changelog.md)
- [Commits](https://github.com/ADOdb/ADOdb/compare/v5.21.4...v5.22.2)

---
updated-dependencies:
- dependency-name: adodb/adodb-php
dependency-type: direct:production
update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
mod - composer.lock Diff File

master a19acf4b

2022-06-12 06:05

dregad


Details Diff
Further improvements to admin/test_langs.php

This is a follow-up on PR https://github.com/mantisbt/mantisbt/pull/1772.

It includes a bit of code cleanup, and brings a few additional UI
enhancements (related to issue 0027383):

- add missing error messages
- improved visibility for plugin headers in table
- add a TOC for tested plugins, allowing user to scroll straight to a
specific one
- add buttons to navigate between the core and plugin sections

It also implements 2 extra checks for language strings:

- basic syntax check (invalid tags, unexpected end tags, open/end tag
mismatch, etc), fixing 0030447
- Use HTMLPurifier to detect if any unauthorized tags are present, which
is partially fixes #12242

PR https://github.com/mantisbt/mantisbt/pull/1822
Affected Issues
0027383
mod - admin/test_langs.php Diff File
mod - composer.json Diff File
mod - composer.lock Diff File
mod - css/default.css Diff File

master-2.25 abafd6b4

2022-06-11 06:30

dregad


Details Diff
Use standard table layout for proj_doc_page.php

Previously the files were presented with a hybrid layout using floating
<span> blocks within a table cell. The Use of print_form_buttons()
within the span tag generated invalid HTML, a problem that was fixed in
87ec8b45bca75ade53150f1f4b669604b71a67ad but that commit introduced a
regression because the CSRF token was not passed on so it was no longer
possible to delete documents.

We now switch to a fully tabular layout, moving the data within the
spans (project, creation date, action buttons) to their own columns and
adjust the markup to align to standard MantisBT UI.

Fixes 0030541
Affected Issues
0030541
mod - proj_doc_page.php Diff File

master f04f7a39

2022-06-10 10:06

dregad


Details Diff
Merge branch 'master-2.25'
mod - composer.lock Diff File

master c92ce0f5

2022-06-09 21:18

dependabot[bot]

Committer: dregad


Details Diff
Bump guzzlehttp/guzzle from 6.5.6 to 6.5.7

Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 6.5.6 to 6.5.7.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/6.5.7/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/6.5.6...6.5.7)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
dependency-type: direct:production
update-type: version-update:semver-patch
...

Fixes 0030416, PR https://github.com/mantisbt/mantisbt/pull/1823

Signed-off-by: dependabot[bot] <support@github.com>
Affected Issues
0030416
mod - composer.lock Diff File

dependabot/composer/guzzlehttp/guzzle-6.5.7 879a9221

2022-06-09 21:18

dependabot[bot]

Committer: community


Details Diff
Bump guzzlehttp/guzzle from 6.5.6 to 6.5.7

Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 6.5.6 to 6.5.7.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/6.5.7/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/6.5.6...6.5.7)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
dependency-type: direct:production
update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
mod - composer.lock Diff File

master 7c0e2b85

2022-06-07 09:16

dregad


Details Diff
Fix scrolling regression in list.js 2.3.1

This is the patch submitted upstream [[1]].

Fixes 0030494

[1]: https://github.com/javve/list.js/pull/750
Affected Issues
0030494
mod - js/list-2.3.1.js Diff File
mod - js/list-2.3.1.min.js Diff File
mod - library/README.md Diff File

master 96ab85e3

2022-06-07 09:05

dregad


Details Diff
Update list.js from 1.5.0 to 2.3.1

Fixes CSP violation when using navigation buttons.

Fixes 0030490
Affected Issues
0030490
mod - core/constant_inc.php Diff File
rm - js/list-1.5.0.js Diff
rm - js/list-1.5.0.min.js Diff
add - js/list-2.3.1.js Diff File
add - js/list-2.3.1.min.js Diff File
mod - library/README.md Diff File

master d9f7710e

2022-06-06 11:34

dregad


Details Diff
Add warning when PHP extensions are missing

Inform the user that some checks were not executed, as suggested by
@atrol in PR review [[1]].

[1]: https://github.com/mantisbt/mantisbt/pull/1822/files/20f813477387b29805ab84c636568d8b7a96f44f#r889677658
mod - admin/test_langs.php Diff File

master 62738564

2022-06-06 07:09

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net.
mod - lang/strings_arabic.txt Diff File
mod - lang/strings_zazaki.txt Diff File

master e03cf73b

2022-06-03 12:41

dregad


Details Diff
Fix indentation and add missing </div> tag

Fixes 0024621
Affected Issues
0024621
mod - signup_page.php Diff File

master a336906d

2022-06-02 12:14

dregad


Details Diff
Use HTMLPurifier to check valid tags in lang strings

This is a first, limited attempt at using the HTMLPurifier library,
to improve the quality and security of language strings by detecting
whether any unallowed HTML tags or properties are used.

For now this is only a manual check, limited to the test_langs.php
script which will report any exceptions, but eventually we should
generalize this to sanitize all user input.

Issue #12242
mod - admin/test_langs.php Diff File
mod - composer.json Diff File
mod - composer.lock Diff File

master 8116b5e3

2022-06-02 09:14

dregad


Details Diff
Move Delete Custom Field button to form footer

Using the HTML5 button's `formaction` property we can get rid of the
separate form that caused the button to be displayed below the Edit box,
and put the Delete button in the main form's footer

Fixes 0027274
Affected Issues
0027274, 0033248
mod - manage_custom_field_edit_page.php Diff File

master 67b2b93c

2022-06-02 07:22

dregad


Details Diff
Fix spelling mistake
mod - core/classes/DbQuery.class.php Diff File

master-2.25 3b2ec19e

2022-06-02 05:31

dregad


Details Diff
Fix deprecated usage of ${} string interpolation

The "Deprecate ${} string interpolation" RFC [1] has been acceoted and
will be implemented in PHP 8.2.

The Mantis code was using the deprecated syntax in a few places, this
fixes these occurrences.

Thanks to ChrisG for the original patch.

Fixes 0030429

[1]: https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation

(cherry picked from commit c3cbfe2c90240d15bf0e450254cbeb68050655ba)

# Conflicts:
# core/string_api.php
Affected Issues
0030429
mod - core/file_api.php Diff File
mod - core/plugin_api.php Diff File
mod - core/string_api.php Diff File
mod - login_page.php Diff File

master c3cbfe2c

2022-06-02 05:31

dregad


Details Diff
Fix deprecated usage of ${} string interpolation

The "Deprecate ${} string interpolation" RFC [1] has been acceoted and
will be implemented in PHP 8.2.

The Mantis code was using the deprecated syntax in a few places, this
fixes these occurrences.

Thanks to ChrisG for the original patch.

Fixes 0030429

[1]: https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation
Affected Issues
0030429
mod - core/file_api.php Diff File
mod - core/plugin_api.php Diff File
mod - core/string_api.php Diff File
mod - login_page.php Diff File

master fdd7efd4

2022-06-01 11:52

dregad


Details Diff
Jump to Custom Fields section after update

Use existing `#customfields` anchor (div id) to jump straight to the
Custom Fields section when returning from an update operation in the
Edit Project page.

Fixes 0030435
Affected Issues
0030435
mod - manage_proj_custom_field_add_existing.php Diff File
mod - manage_proj_custom_field_copy.php Diff File
mod - manage_proj_custom_field_remove.php Diff File
mod - manage_proj_custom_field_update.php Diff File

master fefefe6a

2022-06-01 11:46

dregad


Details Diff
Jump to Subprojects section after update

Use existing `#subprojects` anchor (div id) to jump straight to the
Subprojects section when returning from an update operation in the Edit
Project page.

Fixes 0030435
Affected Issues
0030435
mod - manage_proj_create.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_subproj_add.php Diff File
mod - manage_proj_subproj_delete.php Diff File
mod - manage_proj_update_children.php Diff File

master d105eb4f

2022-06-01 11:43

dregad


Details Diff
Jump to Categories section after update

Use existing `#categories` anchor (div id) to jump straight to the
Categories section when returning from an update operation in the Edit
Project page.

Fixes 0030435
Affected Issues
0030435
mod - manage_proj_cat_add.php Diff File
mod - manage_proj_cat_copy.php Diff File
mod - manage_proj_cat_delete.php Diff File
mod - manage_proj_cat_update.php Diff File

master 4fb8f967

2022-05-31 15:25

atrol


Details Diff
Fix message when checking upload_max_filesize

Fixes 0030428
Affected Issues
0030428
mod - admin/check/check_php_inc.php Diff File
 First  Prev  1 2 3 ... 70 71 72 73 74 75 76 77 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 744 745 746  Next  Last