Changesets: MantisBT

master 79fd7192

2023-03-02 07:09

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net.
mod - lang/strings_dutch.txt Diff File
mod - lang/strings_luxembourgish.txt Diff File

master fe972e04

2023-03-01 12:44

dregad


Details Diff
Fix PHPDoc / static analysis warnings
mod - core/database_api.php Diff File
mod - core/version_api.php Diff File

master e4b23f72

2023-03-01 12:21

dregad


Details Diff
Remove version_cache_row()'s 2nd parameter

$p_trigger_errors allows the function to conditionally throw an
Exception or return False when the Version can't be found.

This is a legacy construct going back to when trigger_error() was used
instead of Exceptions, and is only used once in version_exists().

To simplify code, the parameter is removed and a try/catch block is
used to replace the single use case.

Fixes 0032832
Affected Issues
0032832
mod - core/version_api.php Diff File

master 35416386

2023-03-01 12:11

dregad


Details Diff
Invalid HTML: <fieldset> not allowed in <table>
mod - manage_proj_edit_page.php Diff File

master 00f4f1fc

2023-03-01 12:08

dregad


Details Diff
Remove unnecessary check on Version Id

It does not make any sense for prepare_version_string() to make a
strict-type comparison of the Version Id against false.

The same goes for the null Version Id check in version_full_name().

The Caller should take care of passing a valid Version. If it is not,
just throw an Exception.

Fixes 0032831
Affected Issues
0032831
mod - core/prepare_api.php Diff File
mod - core/version_api.php Diff File
mod - manage_proj_edit_page.php Diff File

master-2.25 6671bc5c

2023-03-01 11:41

dregad


Details Diff
Fix error when displaying Issue without Version

Commit d9464fe8132f6cfd694625c8d050575aed95d5ba introduced a regression
when displaying an Issue without Product, Target or Fixed In Version:

APPLICATION ERROR 1601 - Version "" not found
PHP Notice (or Warning on 8.1+): Undefined array key "version"

This is because mci_issue_data_as_array() removes null keys and empty
arrays from the Issue data, so the IssueViewPageCommand needs to check
for array key existence before calling prepared_version_string().

Fixes 0032086, 0031889
Affected Issues
0031889, 0032086
mod - core/commands/IssueViewPageCommand.php Diff File

master-2.25 ab891658

2023-02-28 11:07

dregad


Details Diff
Fix invalid OpenSearch specification URL
mod - admin/check/check_display_inc.php Diff File
mod - config_defaults_inc.php Diff File

master-2.25 456d874d

2023-02-28 11:06

dregad


Details Diff
Fix escaping of OpenSearch Shortname property

Improper escaping prevented the user from adding a Search Engine when
$g_search_title contains an ampersand.

The `" ' < > &` characters in the config variable are now escaped
- in layout_api.php, to generate proper HTML is in the page head
- in browser_search_plugin.php, to ensure valid XML is produced for the
OpenSearch descriptor.

Fixes 0032076
Affected Issues
0032076
mod - browser_search_plugin.php Diff File
mod - core/layout_api.php Diff File

master 95dab79e

2023-02-27 07:06

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net.
mod - lang/strings_serbian.txt Diff File

master 86566b95

2023-02-23 07:07

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net.
mod - lang/strings_slovene.txt Diff File

master 8017d7ec

2023-02-22 17:52

dregad


Details Diff
Merge tag 'release-2.25.6'

Stable release 2.25.6

# Conflicts:
# core/constant_inc.php
mod - .mailmap Diff File
mod - bug_actiongroup_ext.php Diff File
mod - doc/CREDITS Diff File

master-2.25 7369f9ff

2023-02-22 17:41

dregad


Details Diff
Bump version to 2.25.6
mod - core/constant_inc.php Diff File

master fd4b1c56

2023-02-22 10:43

sederther

Committer: dregad


Details Diff
Adding In-Reply-To header to bugnote notification

Prevents start of a new thread/conversation in mail clients.

Fixes 0032038, PR https://github.com/mantisbt/mantisbt/pull/1867

Co-authored-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0032038
mod - core/email_api.php Diff File

master-2.25 0bfda0db

2023-02-21 18:45

dregad


Details Diff
Update credits
mod - doc/CREDITS Diff File

master-2.25 7a198bc9

2023-02-21 18:43

dregad


Details Diff
Update .mailmap
mod - .mailmap Diff File

master 1b857dae

2023-02-21 18:24

dregad


Details Diff
Merge branch 'master-2.25'
mod - bug_update.php Diff File
mod - bug_view_inc.php Diff File
mod - config_defaults_inc.php Diff File
mod - core/bug_api.php Diff File
mod - core/commands/IssueViewPageCommand.php Diff File
mod - core/commands/VersionAddCommand.php Diff File
mod - core/date_api.php Diff File
mod - core/prepare_api.php Diff File
mod - core/version_api.php Diff File
mod - docbook/Admin_Guide/en-US/config/duedate.xml Diff File

master-2.25 a500ed68

2023-02-21 17:41

dregad

Committer: community


Details Diff
Improve conversion of date strings to unix timestamps

When editing a project version, if the date format is set for a non-US
format, the strtotime() call will fail on date conversion.

This moves the conversion logic to date_strtotime() API and makes use
of the modified API function where relevant, i.e. when date string
could be user-provided.

Fixes 0031836, PR https://github.com/mantisbt/mantisbt/pull/1864
Affected Issues
0031836
mod - bug_update.php Diff File
mod - config_defaults_inc.php Diff File
mod - core/bug_api.php Diff File
mod - core/commands/VersionAddCommand.php Diff File
mod - core/date_api.php Diff File
mod - core/version_api.php Diff File
mod - docbook/Admin_Guide/en-US/config/duedate.xml Diff File

master 361bdb4e

2023-02-17 19:46

dregad


Details Diff
Unit tests improvements
mod - tests/TestConfig.php Diff File
mod - tests/bootstrap.php.sample Diff File
mod - tests/rest/RestBase.php Diff File
mod - tests/rest/RestIssueAddTest.php Diff File
mod - tests/soap/AttachmentTest.php Diff File
mod - tests/soap/CompressionTest.php Diff File
mod - tests/soap/FilterTest.php Diff File
mod - tests/soap/IssueAddTest.php Diff File
mod - tests/soap/IssueHistoryTest.php Diff File
mod - tests/soap/IssueMonitorTest.php Diff File
mod - tests/soap/IssueNoteTest.php Diff File
mod - tests/soap/IssueUpdateTest.php Diff File
mod - tests/soap/MentionTest.php Diff File
mod - tests/soap/ProjectTest.php Diff File
mod - tests/soap/RelationshipTest.php Diff File
mod - tests/soap/SoapBase.php Diff File
mod - tests/soap/TagTest.php Diff File

master e1df23df

2023-02-17 19:36

dregad


Details Diff
Remove ob_start() from TestConfig

Not sure why output buffering was enabled in the first place - the Soap
test suite seems to run just fine without it. Use benefits from the
unbuffered output, as they can see the progress of tests execution.
mod - tests/TestConfig.php Diff File

master 004fa0e6

2023-02-17 19:30

dregad


Details Diff
Use UTC as default timezone in sample bootstrap
mod - tests/bootstrap.php.sample Diff File

master 49d6e7d2

2023-02-17 19:29

dregad


Details Diff
New bootstrap variable MANTIS_TESTSUITE_MAX_ISSUES

This replaces the FilterTest::ISSUES_TO_RETRIEVE constant, allowing a
developer to adjust the number of issues to retrieve when executing
FilterTest cases.

This avoids skipped tests when using a local database with more Issues
than the default of 50 (which works fine for TravisCI tests, that start
with an empty DB).

This is a follow-up fix for Issue 0017121.
Affected Issues
0017121
mod - tests/bootstrap.php.sample Diff File
mod - tests/soap/FilterTest.php Diff File
mod - tests/soap/SoapBase.php Diff File

master fb0a8bda

2023-02-17 19:17

dregad


Details Diff
Code cleanup

Use null-coalescing operator to avoid array_key_exists() / isset() calls
mod - tests/soap/SoapBase.php Diff File

master 8129cd02

2023-02-17 19:05

dregad


Details Diff
Skip FilterTests if there are too many issues

Some tests can't be completed if there are more Issues in the database
than the maximum number to retrieve (defined in ISSUES_TO_RETRIEVE
constant), because they compare the number of Issues before/after
executing the test, and both lists contain ISSUES_TO_RETRIEVE Issues.

Mark the test case as skipped if getAllProjectsIssues() or getAllProjectsIssueHeaders() return ISSUES_TO_RETRIEVE or more Issues.

Fixes 0017121
Affected Issues
0017121
mod - tests/soap/FilterTest.php Diff File

master 2c431fdf

2023-02-17 18:45

dregad


Details Diff
Replace assertEquals by more specialized assertions
mod - tests/soap/FilterTest.php Diff File

master 8a712090

2023-02-17 18:41

dregad


Details Diff
Remove unused, commented-out code
mod - tests/soap/FilterTest.php Diff File
 First  Prev  1 2 3 ... 78 79 80 81 82 83 84 ... 160 ... 240 ... 320 ... 400 ... 480 ... 560 ... 640 ... 720 ... 760 761 762  Next  Last