View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011140 | mantisbt | bugtracker | public | 2009-11-09 13:49 | 2009-11-10 02:46 |
| Reporter | frodgers | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | acknowledged | Resolution | open | ||
| Product Version | 1.2.0rc2 | ||||
| Summary | 0011140: Category change not logged to history | ||||
| Description | Categories with the same name in different projects are not logged to history. | ||||
| Steps To Reproduce | Create identically named categories in different projects. Update Bug and change to the identically named category. | ||||
| Additional Information | I have created a patch for the core/bug_api.php. I will pass true to the category_full_name function call which will concatenate the project name with the category name in the bug history table. | ||||
| Tags | patch | ||||
| Attached Files | bug_api.patch (1,910 bytes)
From a65f454281b67b35d1c27731ad7709b97b8d0cd9 Mon Sep 17 00:00:00 2001
From: Frank Rodgers <frodgers@redcom.com>
Date: Mon, 9 Nov 2009 13:12:12 -0500
Subject: [PATCH] Categories with the same name in different projects where not logged to history
diff --git a/core/bug_api.php b/core/bug_api.php
index 23730c3..aa073e9 100644
--- a/core/bug_api.php
+++ b/core/bug_api.php
@@ -186,11 +186,11 @@ class BugData {
public function __get($name) {
return $this->{$name};
}
-
+
/**
* @private
*/
- public function __isset($name) {
+ public function __isset($name) {
return isset( $this->{$name} );
}
@@ -206,13 +206,13 @@ class BugData {
}
$this->loading = false;
}
-
+
/**
* Retrieves extended information for bug (e.g. bug description)
* @return null
*/
public function fetch_extended_info() {
- if ( $this->description == '' ) {
+ if ( $this->description == '' ) {
$t_text = bug_text_cache_row($this->id);
$this->description = $t_text['description'];
@@ -450,7 +450,7 @@ class BugData {
history_log_event_direct( $c_bug_id, 'status', $t_old_data->status, $this->status );
history_log_event_direct( $c_bug_id, 'resolution', $t_old_data->resolution, $this->resolution );
history_log_event_direct( $c_bug_id, 'projection', $t_old_data->projection, $this->projection );
- history_log_event_direct( $c_bug_id, 'category', category_full_name( $t_old_data->category_id, false ), category_full_name( $this->category_id, false ) );
+ history_log_event_direct( $c_bug_id, 'category', category_full_name( $t_old_data->category_id, true ), category_full_name( $this->category_id, true ) );
history_log_event_direct( $c_bug_id, 'eta', $t_old_data->eta, $this->eta );
history_log_event_direct( $c_bug_id, 'os', $t_old_data->os, $this->os );
history_log_event_direct( $c_bug_id, 'os_build', $t_old_data->os_build, $this->os_build );
--
1.6.0.4
| ||||