View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0037343 | mantisbt | plug-ins | public | 2026-08-06 10:55 | 2026-08-18 11:06 |
| Reporter | przemyslawWiatr | Assigned To | dregad | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Target Version | 2.29.0 | Fixed in Version | 2.29.0 | ||
| Summary | 0037343: validation error check mismatches return types | ||||
| Description | bug_actiongroup_ext.php checks for failed id's by matching the type of the value returned from validation function to not null:
However, the validation function is supposed to return either true on success or a key=>value array with reasons for validation failure: | ||||
| Steps To Reproduce | I'm using asterisk (*) as a placeholder here,
| ||||
| Tags | No tags attached. | ||||
|
@przemyslawWiatr I checked our internal implementations of the action_XXX_validate() function:
None of them actually follow the In fact, tt does not make any sense to return an array, considering that bug_group_action_validate() only processes a single Issue at a time. Consequently, I believe that your proposed change is not necessary, and we should just update the PHPDoc comment to reflect what the code actually does instead. |
|
|
MantisBT: master dcf3bdcd 2026-08-18 10:46 Details Diff |
Fix PHPDoc for bug_group_action_validate() The documented return value was incorrect. Updated to reflect actual usage in action_*_validate() functions and bug_actiongroup_ext.php. Fixes 0037343 |
Affected Issues 0037343 |
|
| mod - core/bug_group_action_api.php | Diff File | ||