How to Update AdoDB on Ubuntu to get through the check?

[UlfDunkel]

I am running Mantis 1.2.8 on a current Ubuntu server. When I call <myMantis>/admin/check.php, it tells me:

Checking your installation
Checking adodb version...
V4.94 23 Jan 2007 (c) 2000-2007 John Lim (jlim#natsoft.com.my). All rights reserved. Released BSD & LGPL. WARN
Database Type (adodb) mysql
Database Provider (adodb) mysql
Database Server Description (adodb) 5.1.58-1ubuntu1
Database Server Description (version) 5.1.58
magic_quotes_gpc
include_path /<myDomain>/bugs/core/:<myDomain>/bugs/library:.:/usr/share/php:/usr/share/pear
PHP variable "upload_max_filesize" 5242880
PHP variable "post_max_size" 8388608
MantisBT variable "max_file_size" 5000000

What do I have to do in order to fix this warning?

[UlfDunkel]

Maybe my note wasn't clear for others:

I'd like to know how I can get rid of the warning that the adodb version seems to be inappropriate. Any hints?

[UlfDunkel]

This issue seems to be silly, as it seems to be caused by a hard-coded version string in /core/adodb/adodb.inc.php:

Code: Select all

$ADODB_vers = 'V4.94 23 Jan 2007 (c) 2000-2007 John Lim (jlim#natsoft.com.my). All rights reserved. Released BSD & LGPL.';

This string seems to be compared with my current version (5.1.58-1ubuntu1) which then throws this silly warning.

There is another hard-coded adodb version string in /library/adodb/adodb.inc.php:

Code: Select all

$ADODB_vers = 'V5.10 10 Nov 2009  (c) 2000-2009 John Lim (jlim#natsoft.com). All rights reserved. Released BSD & LGPL. MantisBT Version';

Is it possible that I have mixed some source files by copying the update versions over old installations?

[UlfDunkel]

So here is the solution:

NEVER simply copy old files over new files.

After I have checked my files, I saw that the /core/ folder contained some outdated subfolders, like /adodb/, which has been moved to the /library/ folder somewhen in the past by the developers.

After I had removed these outdated folders from the /core/ folder, the check passed successfully. Holy sh**.

[atrol]

NEVER simply copy old files over new files.

Read file doc/INSTALL for the recommended way to upgrade.
You should unpack a clean 1.2.8 and compare it with your current installation.
There might be other files in your installation which you should remove to prevent further unwanted effects.

[UlfDunkel]

I am now checking all files against my previous version and found an issue in /core/cfdefs/cfdef_standard.php:

It misses the closing PHP tag ?> at the very end. I am quite sure this is a minor issue, but didn't anyone else note this?

[atrol]

This is intended.
You will hardly find any closing PHP tag at the end of files in whole source code of MantisBT.