Relationship Graph

View IssueDependency GraphShow Summary
Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

WikiJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0010372mantisbtfeaturepublic2009-04-22 14:492014-09-23 18:05
Reporterkec161 Assigned Todregad  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version1.2.15Fixed in Version1.2.15 
Summary0010372: Don't allow reminders to be sent if the user doesn't have an email address specificed
Description

Currently you can send a reminder even if the user doesn't have an email address specified (meaning they won't get the reminder). Changed it so that if you try to send a reminder to someone who doesn't have an email address it will error.

Custom Strings:
$MANTIS_ERROR[ERROR_USER_EMAIL_NOT_SPECIFIED] = 'Unable to send reminder. No email address is specified for %s.';

Custom Constant:
define( 'ERROR_USER_EMAIL_NOT_SPECIFIED', 809 );

Tagspatch
Attached Files
noEmailNoReminder (380 bytes)

Relationships

Relationship GraphDependency Graph
related to 0002971 closeddregad Reminders are not added to bug history 
related to 0015471 closeddregad bug_reminder.php does not handle unsent reminders 
related to 0015721 closedgrangeway Functionality to consider porting to master-2.0.x 
related to 0015470 closeddregad Reminders recipient list is truncated 

Activities

dhx

dhx

2010-08-16 05:32

reporter   ~0026328

Thanks for the patch.

Just some quick comments:

1) The patch file you provided is incorrectly formatted as far as I can tell (the headers are missing). The preferred patch format is the output of git format-patch.

2) I think it'd be better to silently ignore users who don't have email addresses. It would be frustrating for a user sending reminders to be blocked from doing when they have no way of knowing who does/doesn't have an email address specified. Users can check the last bugnote/issue history to verify that people received a reminder.
dregad

dregad

2013-02-07 06:13

developer   ~0035070

Users can check the last bugnote/issue history to verify that people received a reminder.

This is not an option at the moment, because

  1. Reminders are not added to bug history (see 0002971)
  2. If more than 50 users are sent a reminder or if the list of these users' id is longer than 250 chars (size of note_attr field in mantis_bugnote_table), then the bugnote does not list all the people who were sent the reminder (see 0015470)
  3. the code in bug_reminder.php does not handle errors from email_bug_reminder() (see 0015471)
dregad

dregad

2013-02-07 07:42

developer   ~0035073

This is now fixed. Please see related issues for details.
grangeway

grangeway

2013-04-05 17:56

reporter   ~0036098

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch