Updated patch for mantisbt-1.2.0rc2-2010-01-05-master-1.2.x-67762d7

Solution:

Patch for v1.2.0rc2 (Ugly hack! Please suggest better alternative)

leow@leow-laptop:~/SANDBOX/MANTIS$ diff mantis12build/core/filter_api.php pokokhydro/custom/core/filter_api.php
908a909

$uniq_hash = 0;
921a923,925
$uniq_hash++;
$t_cf_tablealias .= '' . $uniq_hash;

=========================================================================

I have the same problem, thanks for the workaround which helps.

I have the same problem with the version 1.2.0 and a mysql database.
I confirm all steps to reproduce with a custom field of type TEXT.

I noticed that the two LEFT JOINs that are causing the error, were actually the same JOIN, but were structured in a different way. I managed to track down where the second JOIN was being produced and came up with the following patch:

===================================================================
Index: filter_api.php

--- filter_api.php (revision 6)
+++ filter_api.php (working copy)
@@ -924,7 +924,7 @@

check to be sure this field wasn't already added to the query.

            if( !in_array( $t_cf_select, $p_query_clauses['select'] ) ) {
                $p_query_clauses['select'][] = $t_cf_select;

• $p_query_clauses['join'][] = "LEFT JOIN $t_custom_field_string_table $t_cf_table_alias ON $t_bug_table.id = $t_cf_table_alias.bug_id AND $t_cf_table_alias.field_id = $t_custom_field_id";

• $p_query_clauses['join'][] = "LEFT JOIN $t_custom_field_string_table $t_cf_table_alias ON $t_cf_table_alias.bug_id = $t_bug_table.id AND $t_cf_table_alias.field_id = $t_custom_field_id ";
  }

          $p_query_clauses['order'][] = $c_cf_alias . ' ' . $c_dir;

  ===================================================================

On my system (Mantis 1.2.1), this appears to have fixed the problem.

This is a duplicate of 0005859 and not fixed yet.

My patch for this problem (1.2.0 - 1.2.2) is to prevent multiple left joins:

--- mantis-1.2.0/core/filter_api.php 2010-02-24 10:34:19.642476000 +0100
+++ mantis/core/filter_api.php 2010-10-05 09:55:54.372631700 +0200
@@ -924,7 +924,13 @@

check to be sure this field wasn't already added to the query.

            if( !in_array( $t_cf_select, $p_query_clauses['select'] ) ) {
                $p_query_clauses['select'][] = $t_cf_select;

• $p_query_clauses['join'][] = "LEFT JOIN $t_custom_field_string_table $t_cf_table_alias ON $t_bug_table.id = $t_cf_table_alias.bug_id AND $t_cf_table_alias.field_id = $t_custom_field_id";

• be sure to add join clause only if it isn't already there

• WARNING: MUST be the same as in filter_get_bug_rows(), section custom field filters.

• if you change here, also change there

• $t_cf_join_clause = "LEFT JOIN $t_custom_field_string_table $t_cf_table_alias ON $t_cf_table_alias.bug_id = $t_bug_table.id AND $t_cf_table_alias.field_id = $t_custom_field_id ";
• if( !in_array( $t_cf_join_clause, $p_query_clauses['join'] ) ) {
• $p_query_clauses['join'][] = $t_cf_join_clause;

• }
  }

          $p_query_clauses['order'][] = $c_cf_alias . ' ' . $c_dir;

  @@ -1857,6 +1863,9 @@

  Each custom field will result in a exponential growth like Number_of_Issues^Number_of_Custom_Fields

          # and only after this process ends (if it is able to) the result query will be filtered
          # by the WHERE clause and by the DISTINCT clause

• WARNING: join clause MUST be the same as in filter_get_query_sort_data()

• if you change here, also change there

          $t_cf_join_clause = "LEFT JOIN $t_custom_field_string_table $t_table_name ON $t_table_name.bug_id = $t_bug_table.id AND $t_table_name.field_id = $t_cfid ";
  
          if( $t_def['type'] == CUSTOM_FIELD_TYPE_DATE ) {

It may be better to use the table name of the joined table as a key (i. e. $p_query_clauses['join'][$t_cf_table_alias] instead of just $p_query_clauses['join'][]), but this would mean to rewrite some code in filter_get_bug_rows() (don't use array_push()).

thanks nimmich for the hints and the patch