Source Control Integration

master c1076a52 2019-09-15 10:11 dregad Details Diff	Refactor manage_plugin_page with objects Added a new class hierarchy, with one class for each plugin status (Available, Installed, Invalid): - PluginForDisplay (abstract parent class) - AvailablePlugin - InstalledPlugin - InvalidPluginForDisplay Each class takes care of populating column data for display from raw plugin data as appropriate, and provides an internal method to render the columns. This avoids code duplication in the main page, and simplifies the ListPluginsForDisplay class which now only provides methods to build, count and print lists of plugins for each status.
	mod - manage_plugin_page.php	Diff File
master b8ee31e4 2019-09-15 09:47 dregad Details Diff	PHPDoc for plugin_api - Improve global plugin cache variables doc - Fix return types - add missing block for plugin_log_event()
	mod - core/plugin_api.php	Diff File
master 10b6d8b1 2019-09-14 15:15 dregad Details Diff	Specific message to confirm missing Plugins removal
	mod - lang/strings_english.txt	Diff File
	mod - manage_plugin_uninstall.php	Diff File
master b288b676 2019-09-14 15:02 dregad Details Diff	Refactor prepare_for_display() as a class
	mod - manage_plugin_page.php	Diff File
master d7ae5dd8 2019-09-14 07:29 dregad Details Diff	Remove unused variables
	mod - plugins/MantisGraph/MantisGraph.php	Diff File
master 25110fd3 2019-09-13 13:11 dregad Details Diff	Convert redirect_delay column back to integer Follow-up fix for user_pref.redirect_delay, which was incorrectly set to boolean in check_pgsql_bool_columns() before MantisBT 2.23.0, so we need to check its type and convert it back to integer if needed. Fixes 0026109	Affected Issues 0026109
	mod - admin/install.php	Diff File
	mod - core/install_helper_functions_api.php	Diff File
master b215c4d5 2019-09-13 13:04 dregad Details Diff	Check DB type before calling check_pgsql_bool_columns()
	mod - admin/install.php	Diff File
master c7f87915 2019-09-13 13:03 dregad Details Diff	Fix PHP Warning if check_pgsql_bool_columns() fails If SQL to retrieve column data in information_schema fails, the function returns a string. This string is then used in a foreach loop, triggering a warning.
	mod - admin/install.php	Diff File
master c73fd8b0 2019-09-12 15:11 dregad Details Diff	Only display time spent if time tracking is enabled Fixes 0026134	Affected Issues 0026134
	mod - bugnote_view_inc.php	Diff File
master c57ccb2b 2019-09-12 14:38 dregad Details Diff	Add missing column from group by clause This causes an error when retrieving time tracking information on View Issue Details page, on MySQL when ONLY_FULL_GROUP_BY is enabled (default since 5.7). Fixes 0026132	Affected Issues 0026132
	mod - core/bugnote_api.php	Diff File
master 9d840d2b 2019-09-12 08:47 dregad Details Diff	Add file with default value 'null' for user id This ensures that the file attachment is added with a reference to the current user. Regression introduced by 255dfdf261c42adb76c4f3b6a157186afe999f9b, caused attachments uploaded together with the issue's submission to be linked to user '0' instead of the reporter. Fixes 0026128	Affected Issues 0026128
	mod - core/file_api.php	Diff File
master 7acc1d26 2019-09-12 06:04 translatewiki.net Details Diff	Localisation updates from https://translatewiki.net.
	mod - lang/strings_italian.txt	Diff File
	mod - lang/strings_japanese.txt	Diff File
	add - plugins/Gravatar/lang/strings_en-gb.txt	Diff File
master 2dfb827c 2019-09-11 07:05 dregad Details Diff	Add missing Tag-related thresholds in manage page Fixes 0026119	Affected Issues 0026119
	mod - lang/strings_english.txt	Diff File
	mod - manage_config_work_threshold_page.php	Diff File
	mod - manage_config_work_threshold_set.php	Diff File
master 0785615c 2019-09-11 03:16 dregad Details Diff	IssueViewPageCommand: regroup monitor flags
	mod - core/commands/IssueViewPageCommand.php	Diff File
master b64d993f 2019-09-10 03:21 dregad Details Diff	Fix display of monitor/unmonitor buttons The monitor button should only be displayed when the current user is not yet monitoring the issue. Likewise for the unmonitor button when the user is indeed monitoring it. Fixes 0026123	Affected Issues 0026123
	mod - core/commands/IssueViewPageCommand.php	Diff File
master 185d18ee 2019-09-09 09:20 translatewiki.net Details Diff	Localisation updates from https://translatewiki.net.
	mod - lang/strings_chinese_simplified.txt	Diff File
	mod - lang/strings_macedonian.txt	Diff File
	mod - lang/strings_spanish.txt	Diff File
master c03afdce 2019-09-07 07:55 dregad Details Diff	Improve UX & consistency for inline action icons Fixes 0025905, PR https://github.com/mantisbt/mantisbt/pull/1545	Affected Issues 0025905
	mod - bug_monitor_list_view_inc.php	Diff File
	mod - bug_report_page.php	Diff File
	mod - bug_view_inc.php	Diff File
	mod - bugnote_update.php	Diff File
	mod - bugnote_view_inc.php	Diff File
	mod - core/collapse_api.php	Diff File
	mod - core/prepare_api.php	Diff File
	mod - core/print_api.php	Diff File
	mod - css/ace-mantis.css	Diff File
	mod - tests/Mantis/PrepareTest.php	Diff File
master f3c532b7 2019-09-05 21:01 translatewiki.net Details Diff	Localisation updates from https://translatewiki.net.
	mod - lang/strings_french.txt	Diff File
master-2.22 a7413daa 2019-09-04 07:30 dregad Details Diff	Use REST API full path (with index.php) On web servers where URL rewriting is not properly configured, calling REST API with the "short" URL, e.g. http://my.mantis/rest/api/issues does not work. To make sure that core functionality relying on REST calls (via the 'internal' route) is working is expected even when URL rewriting is not operational, we use the full path including the index.php file: http://my.mantis/rest/api/index.php/internal/... Fixes 0026110 (cherry picked from commit c4a2cdd9d8d443a84287756959f595728a1524c9)	Affected Issues 0026110
	mod - js/adm_config_report.js	Diff File
	mod - js/common.js	Diff File
master c4a2cdd9 2019-09-04 07:30 dregad Details Diff	Use REST API full path (with index.php) On web servers where URL rewriting is not properly configured, calling REST API with the "short" URL, e.g. http://my.mantis/rest/api/issues does not work. To make sure that core functionality relying on REST calls (via the 'internal' route) is working is expected even when URL rewriting is not operational, we use the full path including the index.php file: http://my.mantis/rest/api/index.php/internal/... Fixes 0026110	Affected Issues 0026110
	mod - js/adm_config_report.js	Diff File
	mod - js/common.js	Diff File
master 0155970f 2019-09-04 07:26 dregad Details Diff	PHPDoc: fix incorrect function return type config_get_value_as_string() returns string, not void.
	mod - core/config_api.php	Diff File
master 8973350c 2019-09-04 07:25 dregad Details Diff	Add PHPDoc blocks to declare extract() variables Fix warnings about undefined variables in PHPStorm.
	mod - adm_config_report.php	Diff File
master 393bca8e 2019-09-04 02:29 dregad Details Diff	Install: redirect_delay is integer, not boolean check_pgsql_bool_columns() function incorrectly categorized column 'redirect_delay' in user_pref table as boolean, when in fact it it an integer (see issue 0016392). This prevents users from having a redirect delay > 1s on PostgreSQL. A follow-up fix will be required to ensure that the underlying column is indeed integer as expected by MantisBT. Fixes 0026109	Affected Issues 0016392, 0026109
	mod - core/install_helper_functions_api.php	Diff File
master 86eb8dec 2019-09-04 02:19 dregad Details Diff	Fix invalid HTML - remove stray </table> tag - 'name' is not a valid attribute for <span>, replace by 'id' - remove deprecated <table> attributes	Affected Issues 0026596
	mod - admin/install.php	Diff File
	mod - js/install.js	Diff File
master b293eb3f 2019-09-04 02:18 dregad Details Diff	Add PHPDoc with types for ADOdb variables Fix warnings about unknown methods and undefined variables in PHPStorm.
	mod - admin/install.php	Diff File

Changesets: MantisBT