Changesets: MantisBT

master 13bda674

2016-05-02 18:47

cproensa

Committer: vboctor


Details Diff
Actions for edit/clone configuration options

In adm_config_report, show buttons for different editing actions:

- Action "Clone" creates new option and keeps old, overwritting if one already exists with those key values. exists
- Action "Edit" updates current configuration option, or moves the option if key values are changed, overwritting if one already exists

Fixes 0020058
Affected Issues
0020058
mod - adm_config_report.php Diff File
mod - adm_config_set.php Diff File
mod - lang/strings_english.txt Diff File

master 45ed88b8

2016-05-02 07:25

vboctor


Details Diff
Fix error when category default handler is deleted

- Fix the error in edit category page.
- Don't assign to default handler on reporting an issue unless user exists.

Fixes 0020867
Affected Issues
0020867
mod - core/bug_api.php Diff File
mod - core/print_api.php Diff File

master f5a278d6

2016-05-01 14:09

cproensa

Committer: vboctor


Details Diff
Fix FILTER_TYPE_MULTI_STRING type for plugin filter

When treating filter options keys as strings, META_FILTER_ANY has to
be used as a string, to not trigger a type mismatch error

Also, when using check_selected() to print selected options, "strict"
option cannot be used because not always the option keys can be kept
as strings.
This happens when the options returned by the plugin filter object
uses integers for keys. Even if the keys are set as string type, PHP
will translate them to integer keys, thus triggering a type mismatch
error if strict check is used.

Eg:
array( '1' => 'x' ) is parsed by PHP as:
array( 1 => 'x' )
Affected Issues
0020866
mod - core/filter_api.php Diff File

master 3709b448

2016-05-01 01:16

dregad


Details Diff
Fix inconsistent return type in compress_handler_is_enabled()

When $g_compress_html == OFF, the function would return null instead of
false.
mod - core/compress_api.php Diff File

master-1.2.x 6b9bf08b

2016-05-01 00:59

dregad


Details Diff
PHP7: Remove old-style constructors

One function was omitted from a9731e9468f3112bde652326310bd3fcf5086a29.

Fixes 0020501
Affected Issues
0020501
mod - core/graphviz_api.php Diff File

master db98d830

2016-05-01 00:59

dregad


Details Diff
PHP7: Remove old-style constructors

One function was omitted from baae433f220fe8b0bed41e0ffb4c46942729a142.

Fixes 0020501
Affected Issues
0020501
mod - core/graphviz_api.php Diff File

master 046e878d

2016-04-30 08:28

dregad


Details Diff
Do not enable compress handler if errors occured

Prevents 'Content Encoding Error', shows the actual output instead.

Fixes 0020865
Affected Issues
0020865
mod - core/compress_api.php Diff File

master-1.2.x 672a256e

2016-04-30 07:25

dregad


Details Diff
Require user pref API in lang API

If the user pref API has not yet been loaded and an error is triggered,
then the error API is not able to retrieve the error message because
language API cannot get the user's preferred language.

Fixes 0020864
Affected Issues
0020864
mod - core/lang_api.php Diff File

master 6abac246

2016-04-30 04:30

dregad


Details Diff
Consistency in PHPUnit test classes names

Some of the test case classes were named with an underscore (e.g.
Mantis_StringTests) while others did not have one (MantisEnumTests).

For consistency, we now exclusively use names witout '_'.
mod - tests/AllTests.php Diff File
mod - tests/Mantis/AllTests.php Diff File
mod - tests/Mantis/ConfigParserTest.php Diff File
mod - tests/Mantis/HelperTest.php Diff File
mod - tests/Mantis/StringTest.php Diff File
mod - tests/soap/AllTests.php Diff File

master 3ed60df1

2016-04-30 03:53

dregad


Details Diff
Parse complex configs using PHP tokenizer

Implements 2 classes to parse 'complex' config options in admin
Configuration Report page using PHP tokenizer instead of relying on
regular expressions.

- Tokenizer calls token_get_all() to build a list of tokens from the
given code
- Parser uses a Tokenizer object to convert the code (string) to an
actual PHP array variable

Includes PHPUnit test cases for the new parser code.

Fixes 0020787, 0020812, 0020813, 0020850, 0020851, 0016931, 0016932
PR https://github.com/mantisbt/mantisbt/pull/761
Affected Issues
0016931, 0016932, 0020787, 0020812, 0020813, 0020850, 0020851
mod - adm_config_set.php Diff File
add - core/classes/ConfigParser.class.php Diff File
add - core/classes/Tokenizer.class.php Diff File
mod - core/constant_inc.php Diff File
mod - lang/strings_english.txt Diff File
mod - tests/Mantis/AllTests.php Diff File
add - tests/Mantis/ConfigParserTest.php Diff File

master fcd4939a

2016-04-29 16:35

vboctor


Details Diff
Add tags to email notifications when set

Fixes 0020857
Affected Issues
0020857
mod - core/email_api.php Diff File
mod - lang/strings_english.txt Diff File

master cd8fa25f

2016-04-29 13:52

cproensa

Committer: dregad


Details Diff
Clean up function user_pref_cache_row

Clean up duplicated logic, fix comments

Signed-off-by: Damien Regad <dregad@mantisbt.org>

Reworded the docblock comment in original commit to simplify it.
mod - core/user_pref_api.php Diff File

master b433e7e6

2016-04-29 13:13

cproensa

Committer: dregad


Details Diff
Don't cache users in project_get_all_user_rows()

Most of the callers of project_get_all_user_rows use the return array
directly, and do not need to fetch the user rows. There's no need to
always cache the calculated users. Especially when the user list is very
large, eg: print users option list with public access. By not caching
them, memory and time is saved (see issue 0017577)

Of all the callers of this function, those that actually use the
cached data are:
- email_notify_new_account(): Adds an explicit call to cache
- email_collect_recipients(): Was already calling to cache users

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0017577
mod - core/email_api.php Diff File
mod - core/project_api.php Diff File

master 1a28acf3

2016-04-28 07:07

Victor Boctor


Details Diff
Update readme with screenshots and modern ui info
mod - readme.md Diff File

master f31e35ac

2016-04-28 06:59

Victor Boctor


Details Diff
Add Modern UI screenshots for wiki
add - doc/modern_my_view.png Diff File
add - doc/modern_view_issue.png Diff File
add - doc/modern_view_issues.png Diff File

master fe73a916

2016-04-26 03:35

dregad


Details Diff
Documentation: review & improve email notification sections
mod - docbook/Admin_Guide/en-US/Customizing.xml Diff File
mod - docbook/Admin_Guide/en-US/config/email.xml Diff File

master 0fd3ba13

2016-04-25 22:08

luke

Committer: vboctor


Details Diff
Add due_date to email notifications when set

Fixes 0020806
Affected Issues
0020806
mod - core/email_api.php Diff File

master 3ecab1a8

2016-04-25 22:02

vboctor


Details Diff
Make mention processing an explicit API action

Don't process mentions as part of create API for issues and notes.
However, make it a separate APIs and call it from applicable scenarios.
mod - api/soap/mc_issue_api.php Diff File
mod - bug_actiongroup.php Diff File
mod - bug_actiongroup_add_note_inc.php Diff File
mod - bug_reminder.php Diff File
mod - bug_report.php Diff File
mod - bug_update.php Diff File
mod - bugnote_add.php Diff File
mod - core/bug_api.php Diff File
mod - core/bugnote_api.php Diff File

master 934f63c0

2016-04-25 22:01

vboctor


Details Diff
Don't send mention notifications to disabled users
mod - core/email_api.php Diff File

master 11d1dcc6

2016-04-25 21:39

vboctor


Details Diff
Refactor mention_format_text & remove user_exists
mod - core/mention_api.php Diff File

master dc291809

2016-04-25 08:00

vboctor


Details Diff
Remove assumption that mentions tag is 1 character
mod - core/mention_api.php Diff File

master a9a20393

2016-04-25 07:57

vboctor


Details Diff
Fix handling of email addresses for @ mentions

Use tokenization instead of regular expression to fix handling for:

- vboctor@localhost and vboctor@example.com shouldn't match.
- @vboctor@example.com and @vboctor@localhost should match for email addresses used as usernames.
- @ mention with invalid characters shouldn't match.

Based on PR review comments from @cproensa
mod - core/mention_api.php Diff File
mod - tests/Mantis/MentionParsingTest.php Diff File

master cf44da01

2016-04-25 07:53

vboctor


Details Diff
Applied misc PR review comments from @atrol
mod - config_defaults_inc.php Diff File
mod - core/bugnote_api.php Diff File
mod - core/email_api.php Diff File
mod - core/mention_api.php Diff File

master b1576be0

2016-04-24 13:53

vboctor


Details Diff
Fix docbook error for mentions configuration
mod - docbook/Admin_Guide/en-US/config/reminders.xml Diff File

master 9e2ec909

2016-04-24 13:45

vboctor


Details Diff
Spacing updates for test cases
mod - core/bug_revision_api.php Diff File
mod - tests/soap/MentionTest.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 217 218 219 220 221 222 223 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 729 730 731  Next  Last