View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020851 | mantisbt | administration | public | 2016-04-21 19:15 | 2016-06-12 00:42 |
Reporter | cproensa | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.3.0-rc.1 | ||||
Target Version | 1.3.0-rc.2 | Fixed in Version | 1.3.0-rc.2 | ||
Summary | 0020851: Configuration page parsing associative keys incorrectly | ||||
Description | when parsing an associative array, with element of mixed format, like:
This is parsed as:
Where native PHP code builds it as:
| ||||
Tags | No tags attached. | ||||
MantisBT: master 8107ea50 2016-04-22 03:04 Details Diff |
Parse complex configs using PHP tokenizer Implements 2 classes to parse 'complex' config options in admin Configuration Report page using PHP tokenizer instead of relying on regular expressions. - Tokenizer calls token_get_all() to build a list of tokens from the given code - Parser uses a Tokenizer object to convert the code (string) to an actual PHP array variable TODO: Move classes to an API and write automated tests Fixes 0020787, 0020812, 0020813, 0020850, 0020851 |
Affected Issues 0020787, 0020812, 0020813, 0020850, 0020851 |
|
mod - adm_config_set.php | Diff File | ||
mod - core/constant_inc.php | Diff File | ||
mod - lang/strings_english.txt | Diff File | ||
MantisBT: master 3ed60df1 2016-04-30 03:53 Details Diff |
Parse complex configs using PHP tokenizer Implements 2 classes to parse 'complex' config options in admin Configuration Report page using PHP tokenizer instead of relying on regular expressions. - Tokenizer calls token_get_all() to build a list of tokens from the given code - Parser uses a Tokenizer object to convert the code (string) to an actual PHP array variable Includes PHPUnit test cases for the new parser code. Fixes 0020787, 0020812, 0020813, 0020850, 0020851, 0016931, 0016932 PR https://github.com/mantisbt/mantisbt/pull/761 |
Affected Issues 0016931, 0016932, 0020787, 0020812, 0020813, 0020850, 0020851 |
|
mod - adm_config_set.php | Diff File | ||
add - core/classes/ConfigParser.class.php | Diff File | ||
add - core/classes/Tokenizer.class.php | Diff File | ||
mod - core/constant_inc.php | Diff File | ||
mod - lang/strings_english.txt | Diff File | ||
mod - tests/Mantis/AllTests.php | Diff File | ||
add - tests/Mantis/ConfigParserTest.php | Diff File |