Source Control Integration

master 6dd6e7c4 2010-03-04 02:42 dhx Details Diff	Revert "Fix 0011600: Bugnote direct links include mismatched parenthesis" This reverts commit 02185e9949d512826bc4b8dc23a6c0fb495a5888.	Affected Issues 0011600
	mod - bugnote_view_inc.php	Diff File
master 4f3906f6 2010-03-04 02:32 dhx Details Diff	Fix 0011600: Bugnote direct links include mismatched parenthesis In the bugnote direct links in the left column of the "Notes" section of an issue page, the right parenthesis is part of the link but the left parenthesis is not. This patch removes the parenthesis entirely and instead uses the value of $g_bugnote_link_tag as a prefix to the bugnote ID. This technique is a subtle reminder to users of the syntax to use within bugnotes and bug descriptions to refer to a particular bugnote.	Affected Issues 0011600
	mod - bugnote_view_inc.php	Diff File
master 02185e99 2010-03-04 02:32 dhx Details Diff	Fix 0011600: Bugnote direct links include mismatched parenthesis In the bugnote direct links in the left column of the "Notes" section of an issue page, the right parenthesis is part of the link but the left parenthesis is not. This patch removes the parenthesis entirely and instead uses the value of $g_bugnote_link_tag as a prefix to the bugnote ID. This technique is a subtle reminder to users of the syntax to use within bugnotes and bug descriptions to refer to a particular bugnote.	Affected Issues 0011600
	mod - bugnote_view_inc.php	Diff File
master bfd49f38 2010-03-01 08:43 dhx Details Diff	login_method = LDAP shouldn't warrant a warning
	mod - admin/check/check_crypto_inc.php	Diff File
master 21ac0c07 2010-03-01 07:36 Kirill Krasnov Committer: dhx Details Diff	Update link to check script from admin/index.php Commit ba97560b02d620569ad062d894284722f0acd890 renamed the old admin/check.php script to admin/check/index.php However a link on admin/index.php wasn't updated to point to the new check script. Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
	mod - admin/index.php	Diff File
master 457d8c9e 2010-03-01 06:19 dhx Details Diff	Revert "Issue 0010730: Implement CAPICOM PRNG source for Windows servers" This reverts commit ab7dad32cd2e53124f1cc78cb62964861ee7c87f. Relying upon the CAPICOM.Utilities.1 library for providing a PRNG source for Windows environments seems to be problematic. Problems include lack of CAPICOM libraries in certain Windows environments as well as potentially garbled and unpredictable output from the CAPICOM library.	Affected Issues 0010730
	mod - core/crypto_api.php	Diff File
master-1.2.x 3cca9275 2010-02-28 20:22 dhx Details Diff	Fix 0011571: Versions 1.1 and 1.10 are treated as duplicates A problem was discovered on manage_proj_edit_page.php where if versions 1.1 and 1.10 were both shown, clicking 'edit' for 1.1 would bring up the edit version page for the 1.10 version instead. This is due to an incorrect version name comparison in version_get_id whereby the following check between strings was occurring: if( "1.1" == "1.10" ) { ... } PHP evaluates this expression to true because 1.1 and 1.10 are treated as floats. We however need to preserve the string type during this comparison, thus we need to use the === comparison operator instead.	Affected Issues 0011571
	mod - core/version_api.php	Diff File
master 0e5ad6ca 2010-02-28 20:22 dhx Details Diff	Fix 0011571: Versions 1.1 and 1.10 are treated as duplicates A problem was discovered on manage_proj_edit_page.php where if versions 1.1 and 1.10 were both shown, clicking 'edit' for 1.1 would bring up the edit version page for the 1.10 version instead. This is due to an incorrect version name comparison in version_get_id whereby the following check between strings was occurring: if( "1.1" == "1.10" ) { ... } PHP evaluates this expression to true because 1.1 and 1.10 are treated as floats. We however need to preserve the string type during this comparison, thus we need to use the === comparison operator instead.	Affected Issues 0011571
	mod - core/version_api.php	Diff File
master 904e4943 2010-02-27 12:16 siebrand Details Diff	Localisation updates from translatewiki.net (2010-02-27) Signed-off-by: Siebrand Mazeland <s.mazeland@xs4all.nl>
	mod - lang/strings_norwegian_bokmal.txt	Diff File
	mod - lang/strings_spanish.txt	Diff File
	mod - lang/strings_serbian.txt	Diff File
	mod - lang/strings_galician.txt	Diff File
	mod - lang/strings_arabicegyptianspoken.txt	Diff File
master-1.2.x 76cd989e 2010-02-26 20:39 dhx Details Diff	Fix 0011560: ADOdb version check in check.php is incorrect See upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=18320 for the reason as to why this change is necessary. version_compare works with strings, not float values. And the Version() function in ADOdb should not be returning floats anyway (there is no way to determine if the version if 5.1 or 5.10 from a float value).	Affected Issues 0011560
	mod - admin/check.php	Diff File
master 916f1143 2010-02-26 20:39 dhx Details Diff	Fix 0011560: ADOdb version check in check.php is incorrect See upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=18320 for the reason as to why this change is necessary. version_compare works with strings, not float values. And the Version() function in ADOdb should not be returning floats anyway (there is no way to determine if the version if 5.1 or 5.10 from a float value).	Affected Issues 0011560
	mod - admin/check.php	Diff File
master ab7dad32 2010-02-26 19:42 dhx Details Diff	Issue 0010730: Implement CAPICOM PRNG source for Windows servers First attempt at generating strong randomness on Windows servers by using the CAPICOM.Utilities library call GetRandom(). Needs testing!	Affected Issues 0010730
	mod - core/crypto_api.php	Diff File
master 1fbfa488 2010-02-26 18:54 dhx Details Diff	Don't use openssl_random_pseudo_bytes() on Windows (performance reasons) The openssl_random_pseudo_bytes() function seems to perform very slowly on Windows (100% CPU, pages take over a minute to load). Therefore we should disable this function from being used on Windows platforms.
	mod - core/crypto_api.php	Diff File
master-1.2.x 5ea26915 2010-02-26 18:39 rombert Details Diff	Fixes 0011427: Undefined index: id Fix provided by vboctor, supplemented with a SOAP test.	Affected Issues 0011427
	mod - tests/soap/IssueAddTest.php	Diff File
	mod - api/soap/mc_api.php	Diff File
master 44be8f3f 2010-02-26 18:39 rombert Details Diff	Fixes 0011427: Undefined index: id Fix provided by vboctor, supplemented with a SOAP test.	Affected Issues 0011427
	mod - tests/soap/IssueAddTest.php	Diff File
	mod - api/soap/mc_api.php	Diff File
master-1.2.x 888a3561 2010-02-26 18:17 dhx Details Diff	Fix 0011569: Incorrect variable name in print_page_links() Commit f838e89dc6460f3f2e65d20e4bd904203bd6f880 introduced a bug whereby a variable name was incorrect ($p_emp_filter_id instead of $p_temp_filter_id), thereby causing errors.	Affected Issues 0011569
	mod - core/print_api.php	Diff File
master 6a424345 2010-02-26 18:17 dhx Details Diff	Fix 0011569: Incorrect variable name in print_page_links() Commit f838e89dc6460f3f2e65d20e4bd904203bd6f880 introduced a bug whereby a variable name was incorrect ($p_emp_filter_id instead of $p_temp_filter_id), thereby causing errors.	Affected Issues 0011569
	mod - core/print_api.php	Diff File
master-1.2.x 19b969e9 2010-02-26 08:18 dhx Details Diff	Fix 0011565: $g_enable_profiles not respected on bug report page On the bug report page, profile fields are shown even with $g_enable_profiles = OFF	Affected Issues 0011565
	mod - bug_report_page.php	Diff File
master ecb7cc08 2010-02-26 08:18 dhx Details Diff	Fix 0011565: $g_enable_profiles not respected on bug report page On the bug report page, profile fields are shown even with $g_enable_profiles = OFF	Affected Issues 0011565
	mod - bug_report_page.php	Diff File
master 8164b3eb 2010-02-25 11:33 dhx Details Diff	Fix 0011554: Status legend should react to current filter settings The status legend shown at the bottom of the view all issues page should factor in the current filter settings. The following conditions should apply to showing the status legend: * Don't show the legend if there is only one status selected by the filter * Hide statuses from the legend that are hidden by the 'hide status' filter (for simple filters) * Hide statuses from the legend that aren't selected using an advanced status filter	Affected Issues 0011554
	mod - core/html_api.php	Diff File
master-1.2.x 09b7815e 2010-02-25 11:31 dhx Details Diff	Fix 0011553: Status legend doesn't show final workflow states The status legend at the bottom of the view all issues page doesn't show the final states in a workflow. This is due to the html_status_legend function removing any workflow states from status_enum_workflow[STATUS] which are null/zero length.	Affected Issues 0011553
	mod - core/html_api.php	Diff File
master 8d5d327e 2010-02-25 11:31 dhx Details Diff	Fix 0011553: Status legend doesn't show final workflow states The status legend at the bottom of the view all issues page doesn't show the final states in a workflow. This is due to the html_status_legend function removing any workflow states from status_enum_workflow[STATUS] which are null/zero length.	Affected Issues 0011553
	mod - core/html_api.php	Diff File
master 0cc7dde8 2010-02-25 10:13 dhx Details Diff	Fix 0011481: Incorrect arguments for access_has_any_project Commit 6dc35105064e5a2533fb4e1de54426ea17d2ef36 introduced improved checking within print_column_selection to determine which actions should be presented to users as part of the actiongroup support in MantisBT. However the second argument to access_has_any_project should not be defined in the way it was, as it is refers to the user ID not the project ID. We don't need to specify this argument anyway, so it is removed in this patch.	Affected Issues 0011481
	mod - core/columns_api.php	Diff File
master 2191aa1b 2010-02-25 09:55 dhx Details Diff	Fix 0011552: No errors shown when actiongroup tag attaching fails When attacking tags to multiple issues via the action group feature (the dropdown in the bottom left of the view all issues page), errors are silently ignored. The user should instead be informed if any of the tags could not be applied to the issues selected. This patch also changes the return status from the actiongroup validation and processing functions to be an error string or null in the event that an error didn't occur. In the future it'd be much better if the validation and processing functions worked on the entire set of selected issues instead of each issue one-by-one. This gives the actiongroup validation/processing functions more flexibility (especially in the case of the tag attaching action).	Affected Issues 0011552
	mod - lang/strings_english.txt	Diff File
	mod - bug_actiongroup_attach_tags_inc.php	Diff File
	mod - bug_actiongroup_update_product_build_inc.php	Diff File
	mod - bug_actiongroup_add_note_inc.php	Diff File
	mod - bug_actiongroup_ext.php	Diff File
	mod - bug_actiongroup_update_severity_inc.php	Diff File
master-1.2.x 0f00ee79 2010-02-25 01:02 dhx Details Diff	current_user_get_bug_filter() can return false When calling current_user_get_bug_filter(), we need to check if the return value is boolean false. If so, we need to get the default filter instead of the current user's filter. Also, current_user_get_bug_filter() already validates the filter to ensure it is correct, so there is no need to validate it a second time.
	mod - view_filters_page.php	Diff File
	mod - core/current_user_api.php	Diff File
	mod - view_all_inc.php	Diff File
	mod - my_view_inc.php	Diff File
	mod - return_dynamic_filters.php	Diff File

Changesets: MantisBT