View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009663 | mantisbt | roadmap | public | 2008-09-26 06:49 | 2010-12-17 04:40 |
| Reporter | greno2 | Assigned To | dhx | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.1.2 | ||||
| Target Version | 1.2.4 | Fixed in Version | 1.2.4 | ||
| Summary | 0009663: Wrong underline-charcount when Project-Name contains htmlspecialchars | ||||
| Description | Underline of Project/Version via "=" counts characters after htmlspecialchars so that Ampersand (&) counts 4 characters for length of line ... x&o AA Intranet/Internet - KW2008/53 | ||||
| Tags | patch | ||||
| Attached Files | issue9663.patch (1,134 bytes)
From f708b2ed618bb1e89a3e6c61cae717b8bab37aa7 Mon Sep 17 00:00:00 2001 From: Roland Becker <roland@atrol.de> Date: Tue, 14 Sep 2010 22:20:47 +0200 Subject: [PATCH] Fix #9663: Wrong underline-charcount when Project-Name contains htmlspecialchars --- roadmap_page.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/roadmap_page.php b/roadmap_page.php index 5ef5691..b0f1003 100644 --- a/roadmap_page.php +++ b/roadmap_page.php @@ -49,7 +49,7 @@ echo '<br />', $t_release_title, $t_scheduled_release_date, lang_get( 'word_separator' ), print_bracket_link( 'view_all_set.php?type=1&temporary=y&' . FILTER_PROPERTY_PROJECT_ID . '=' . $t_project_id . '&' . filter_encode_field_and_value( FILTER_PROPERTY_TARGET_VERSION, $t_version_name ), lang_get( 'view_bugs_link' ) ), '<br />'; $t_release_title_without_hyperlinks .= $t_scheduled_release_date; - echo utf8_str_pad( '', utf8_strlen( $t_release_title_without_hyperlinks ), '=' ), '<br />'; + echo utf8_str_pad( '', utf8_strlen( html_entity_decode( $t_release_title_without_hyperlinks ) ), '=' ), '<br />'; } # print project header -- 1.6.4.2 | ||||
|
Reminder sent to: dhx Please have a look at the patch. |
|
|
Reminder sent to: dhx maybe you missed this patch because I forgot to add the patch tag |
|
|
Thanks for the reminder/patch Roland. I noticed that the patch you provided could be simplified a great deal so I have done that. This problem didn't just affect the roadmap page, it also impacted the changelog page. I've fixed both pages in both 1.2.x and 1.3.x. Thanks :) |
|
|
MantisBT: master b23efa9c 2010-09-22 05:14 Details Diff |
Fix 0009663: Roadmap underlines incorrect lengths The text underlines on the roadmap page are displayed with an incorrect length when the version name contains characters that are encodable via htmlspecialchars(). We need to use the length of the raw string instead of the length of the encoded string. Thanks to Roland Becker for the initial patch for this issue. |
Affected Issues 0009663 |
|
| mod - roadmap_page.php | Diff File | ||
|
MantisBT: master-1.2.x 922d605c 2010-09-22 05:14 Details Diff |
Fix 0009663: Roadmap underlines incorrect lengths The text underlines on the roadmap page are displayed with an incorrect length when the version name contains characters that are encodable via htmlspecialchars(). We need to use the length of the raw string instead of the length of the encoded string. Thanks to Roland Becker for the initial patch for this issue. |
Affected Issues 0009663 |
|
| mod - roadmap_page.php | Diff File | ||
|
MantisBT: master 80b8b1ab 2010-09-22 05:14 Details Diff |
Fix 0009663: Changelog underlines incorrect lengths The text underlines on the changelog page are displayed with an incorrect length when the version name contains characters that are encodable via htmlspecialchars(). We need to use the length of the raw string instead of the length of the encoded string. |
Affected Issues 0009663 |
|
| mod - changelog_page.php | Diff File | ||
|
MantisBT: master-1.2.x 58969dfb 2010-09-22 05:14 Details Diff |
Fix 0009663: Changelog underlines incorrect lengths The text underlines on the changelog page are displayed with an incorrect length when the version name contains characters that are encodable via htmlspecialchars(). We need to use the length of the raw string instead of the length of the encoded string. |
Affected Issues 0009663 |
|
| mod - changelog_page.php | Diff File | ||