Source Control Integration

master dac9d0aa 2010-01-17 06:32 dhx Details Diff	Issue 0011405: Add link to bugnote revisions within bugnote display For bugnotes that have been edited, revisions may exist. If they do (ie. they haven't been dropped by someone with permission to do so) then we can display a count of revisions and a link to the page where users can view previous revisions of a bugnote.		Affected Issues 0011405
	mod - lang/strings_english.txt		Diff File
	mod - bugnote_view_inc.php		Diff File
	mod - print_all_bug_page_word.php		Diff File
	mod - print_bugnote_inc.php		Diff File
master da6c133f 2010-01-17 03:43 dhx Details Diff	Issue 0010884: Improve granularity of bugnote permissions Currently it's only possible to use a single $g_bugnote_allow_user_edit_delete setting to turn ON or OFF the ability for users to be able to edit/delete their own bugnotes. This patch provides improvement to the granularity of bugnote permissions to make the following possible: 1) Separate edit and delete permissions 2) Thresholds instead of boolean switches 3) Ability for users to change the view state of their own bugnotes On the topic of view states, the $g_set_view_status_threshold setting controls whether a user can make a bug or bug note private at the time of reporting/posting. The existing $g_change_view_status_threshold setting allows users to change the view state of any bug or bug note after they've been reported/posted. This patch introduces $g_bugnote_user_change_view_state_threshold which allows administrators to give users the the ability to make their own bugnotes public or private as they choose, at any time. $g_bugnote_user_edit_threshold is a new setting that can be changed to allow users the ability to edit their own bugnotes. $g_bugnote_user_delete_threshold is a new setting that can be changed to allow users the ability to delete their own bugnotes. You may be wondering why there is a difference when a user could simply edit and blank their bugnote. The answer lies with bugnote revisions and the ability for users to see a revision history of each bug that has been edited. Many thanks to Chris Fitch for the original idea and an initial patch from August 2009. This patch is a rewrite of his earlier work with a number of additional changes and improvements.		Affected Issues 0010884
	mod - config_defaults_inc.php		Diff File
	mod - lang/strings_english.txt		Diff File
	mod - bugnote_add.php		Diff File
	mod - manage_config_work_threshold_set.php		Diff File
	mod - bugnote_delete.php		Diff File
	mod - bugnote_update.php		Diff File
	mod - docbook/adminguide/en/page_descriptions.sgml		Diff File
	mod - docbook/adminguide/en/configuration.sgml		Diff File
	mod - core/bugnote_api.php		Diff File
	mod - bugnote_edit_page.php		Diff File
	mod - manage_config_work_threshold_page.php		Diff File
	mod - core/obsolete.php		Diff File
	mod - bugnote_set_view_state.php		Diff File
	mod - bugnote_view_inc.php		Diff File
	mod - bugnote_add_inc.php		Diff File
master-1.2.x 2c8f64b0 2010-01-16 23:35 dhx Details Diff	Fix 0004654: Preserve sort field and order when changing filter Clicking on one of the alphabetical filters (A-Z, etc) would reset the currently selected sort field and sort order. Additionally, toggling the "Hide inactive" checkbox reset the filter to 'All' even if you had something else selected at the time.		Affected Issues 0004654
	mod - manage_user_page.php		Diff File
master 391d3e80 2010-01-16 23:35 dhx Details Diff	Fix 0004654: Preserve sort field and order when changing filter Clicking on one of the alphabetical filters (A-Z, etc) would reset the currently selected sort field and sort order. Additionally, toggling the "Hide inactive" checkbox reset the filter to 'All' even if you had something else selected at the time.		Affected Issues 0004654
	mod - manage_user_page.php		Diff File
master-1.2.x e8ae3806 2010-01-16 22:57 dhx Details Diff	project_hierarchy_cache function shouldn't be called outside API Caching of project hierarchies is a concept that should be internal to project_hierarchy_api. External users of this API should not know or have to care about caching.
	mod - core/version_api.php		Diff File
	mod - core/print_api.php		Diff File
	mod - manage_proj_page.php		Diff File
	mod - core/category_api.php		Diff File
	mod - manage_proj_edit_page.php		Diff File
master 443d28a2 2010-01-16 22:57 dhx Details Diff	project_hierarchy_cache function shouldn't be called outside API Caching of project hierarchies is a concept that should be internal to project_hierarchy_api. External users of this API should not know or have to care about caching.
	mod - manage_proj_page.php		Diff File
	mod - core/version_api.php		Diff File
	mod - core/category_api.php		Diff File
	mod - manage_proj_edit_page.php		Diff File
	mod - core/print_api.php		Diff File
master-1.2.x dd258c75 2010-01-16 22:49 dhx Details Diff	Fix 0011402: Project hierarchy cache problem on manage_proj_edit_page.php manage_proj_edit_page.php didn't cache project hierarchies with disabled projects included. Thus errors relating to in_array() were seen when attempting to edit a parent project when one of the sub-projects was marked as being disabled.		Affected Issues 0011402
	mod - manage_proj_edit_page.php		Diff File
	mod - core/project_hierarchy_api.php		Diff File
master bf80e9ee 2010-01-16 22:49 dhx Details Diff	Fix 0011402: Project hierarchy cache problem on manage_proj_edit_page.php manage_proj_edit_page.php didn't cache project hierarchies with disabled projects included. Thus errors relating to in_array() were seen when attempting to edit a parent project when one of the sub-projects was marked as being disabled.		Affected Issues 0011402
	mod - core/project_hierarchy_api.php		Diff File
	mod - manage_proj_edit_page.php		Diff File
master-1.2.x d6b2fd09 2010-01-16 22:00 dhx Details Diff	Fix 0010818: MetaColumnNames ADOdb function may return bool value The MetaColumnNames ADOdb function doesn't always return an array - it could return a boolean value of false as well. Therefore before using the result of a call to MetaColumnNames, we must first check that we've got a valid array. ADOdb documentation of course doesn't mention this.		Affected Issues 0010818
	mod - manage_user_page.php		Diff File
	mod - core/database_api.php		Diff File
master 90d3d4db 2010-01-16 22:00 dhx Details Diff	Fix 0010818: MetaColumnNames ADOdb function may return bool value The MetaColumnNames ADOdb function doesn't always return an array - it could return a boolean value of false as well. Therefore before using the result of a call to MetaColumnNames, we must first check that we've got a valid array. ADOdb documentation of course doesn't mention this.		Affected Issues 0010818
	mod - manage_user_page.php		Diff File
	mod - core/database_api.php		Diff File
master-1.2.x 9b1fbd77 2010-01-16 21:17 dhx Details Diff	Fix 0011400: Update documentation of $g_view_configuration_threshold Commit 5c727ba9ac508201434e7d5361297f367a206463 changed the default value of $g_view_configuration_threshold from VIEWER to ADMINISTRATOR. However, I forgot to update the documentation to reflect this change. Thank you Victor for reminding me! Note that this backport includes documentation of the configuration view/set threshold options that were introduced in commit fce04e6597310e9dd644612348354dc055e99dfa but weren't backported to the 1.2.x branch at that point of time.		Affected Issues 0011400
	mod - docbook/adminguide/en/configuration.sgml		Diff File
master e1d134e7 2010-01-16 21:17 dhx Details Diff	Fix 0011400: Update documentation of $g_view_configuration_threshold Commit 5c727ba9ac508201434e7d5361297f367a206463 changed the default value of $g_view_configuration_threshold from VIEWER to ADMINISTRATOR. However, I forgot to update the documentation to reflect this change. Thank you Victor for reminding me!		Affected Issues 0011400
	mod - docbook/adminguide/en/configuration.sgml		Diff File
master e22eeacf 2010-01-15 09:03 dhx Details Diff	Fix 0011395: show_queries_list should be a global option		Affected Issues 0011395
	mod - config_defaults_inc.php		Diff File
master-1.2.x f3d5815f 2010-01-15 09:01 dhx Details Diff	Fix 0011395: show_queries_list should be a global option		Affected Issues 0011395
	mod - config_defaults_inc.php		Diff File
master-1.2.x 589ef8ff 2010-01-15 08:55 dhx Details Diff	Fix 0011400: Increase default $g_view_configuration_threshold By default, $g_view_configuration_threshold is currently set to DEVELOPER. This option should really be changed to have a default of ADMINISTRATOR, as the configuration of MantisBT can contain sensitive information. There won't be impact to current installations, as users at DEVELOPER level have no links whatsoever in the UI to the adm_ and manage_ pages of MantisBT.		Affected Issues 0011400
	mod - config_defaults_inc.php		Diff File
master 5c727ba9 2010-01-15 08:55 dhx Details Diff	Fix 0011400: Increase default $g_view_configuration_threshold By default, $g_view_configuration_threshold is currently set to DEVELOPER. This option should really be changed to have a default of ADMINISTRATOR, as the configuration of MantisBT can contain sensitive information. There won't be impact to current installations, as users at DEVELOPER level have no links whatsoever in the UI to the adm_ and manage_ pages of MantisBT.		Affected Issues 0011400
	mod - config_defaults_inc.php		Diff File
master-1.2.x 0d044ba0 2010-01-15 05:18 dhx Details Diff	Improve support for multiple resolved and closed statuses (bug_update) It's possible to have multiple resolved or closed statuses. Thus when updating a bug, we need to check not if the new status meets the resolved or closed status threshold, but whether the new status is within a valid range of statuses. We also need to ensure that bug_resolve/bug_close logic isn't reapplied when the status changes from one resolved status to another resolved status.
	mod - bug_update.php		Diff File
master 5cd754da 2010-01-15 05:18 dhx Details Diff	Improve support for multiple resolved and closed statuses (bug_update) It's possible to have multiple resolved or closed statuses. Thus when updating a bug, we need to check not if the new status meets the resolved or closed status threshold, but whether the new status is within a valid range of statuses. We also need to ensure that bug_resolve/bug_close logic isn't reapplied when the status changes from one resolved status to another resolved status.
	mod - bug_update.php		Diff File
master-1.2.x 8a9f6d05 2010-01-15 05:04 dhx Details Diff	Fix 0011375: Copy list of users monitoring duplicate bug to original bug If a bug X is resolved as being a duplicate of bug Y, any users that are monitoring bug X should automatically start monitoring bug Y (if they aren't already). This solution isn't perfect because it's still possible to manually add a "duplicate" relationship within the relationship table or use bug_update_page.php to manually resolve an issue as being a duplicate. This copying of the bug monitor list thus only occurs when bug_resolve(...) is called - ie. when a bug is resolved using the bug status dropdown and a duplicate bug ID is provided on the following bug_change_status_page.php page. A new bug_monitor_copy( source_bug_id, destination_bug_id ) function has been placed into bug_api.php for use in other cases too. Currently the only other use of this function is when copying/cloning a bug. One may wonder why a call to bug_monitor_copy() isn't made somewhere within relationship_api.php to catch all cases where a duplicate relationship is created. The reason is to do with maintaining low coupling - relationship API shouldn't need to know about the logic of duplicate bugs and bug monitoring lists. Thanks to Akemi Yagi for reporting this issue on the CentOS bug tracker at http://bugs.centos.org/view.php?id=3931 and to Mark Rappoport for passing the matter upstream to MantisBT, providing an initial patch in the process.		Affected Issues 0011375
	mod - core/bug_api.php		Diff File
master 8815b9d0 2010-01-15 05:04 dhx Details Diff	Fix 0011375: Copy list of users monitoring duplicate bug to original bug If a bug X is resolved as being a duplicate of bug Y, any users that are monitoring bug X should automatically start monitoring bug Y (if they aren't already). This solution isn't perfect because it's still possible to manually add a "duplicate" relationship within the relationship table or use bug_update_page.php to manually resolve an issue as being a duplicate. This copying of the bug monitor list thus only occurs when bug_resolve(...) is called - ie. when a bug is resolved using the bug status dropdown and a duplicate bug ID is provided on the following bug_change_status_page.php page. A new bug_monitor_copy( source_bug_id, destination_bug_id ) function has been placed into bug_api.php for use in other cases too. Currently the only other use of this function is when copying/cloning a bug. One may wonder why a call to bug_monitor_copy() isn't made somewhere within relationship_api.php to catch all cases where a duplicate relationship is created. The reason is to do with maintaining low coupling - relationship API shouldn't need to know about the logic of duplicate bugs and bug monitoring lists. Thanks to Akemi Yagi for reporting this issue on the CentOS bug tracker at http://bugs.centos.org/view.php?id=3931 and to Mark Rappoport for passing the matter upstream to MantisBT, providing an initial patch in the process.		Affected Issues 0011375
	mod - core/bug_api.php		Diff File
master-1.2.x 45a2b5c3 2010-01-15 04:27 dhx Details Diff	Fix 0011397: XSS with project names in relationship table A malicious project name containing Javascript is not sanitised before being printed in the relationships table (the bug view page).		Affected Issues 0011397
	mod - core/relationship_api.php		Diff File
master 0995c231 2010-01-15 04:27 dhx Details Diff	Fix 0011397: XSS with project names in relationship table A malicious project name containing Javascript is not sanitised before being printed in the relationships table (the bug view page).		Affected Issues 0011397
	mod - core/relationship_api.php		Diff File
master-1.2.x dc96dcfb 2010-01-15 02:50 vboctor Details Diff	Fixes 0003391: Set assign_to when resolving bug.		Affected Issues 0003391
	mod - bug_change_status_page.php		Diff File
master cb5ca455 2010-01-15 02:38 vboctor Details Diff	Fixes 0003391: Set assign_to when resolving bug.		Affected Issues 0003391
	mod - bug_change_status_page.php		Diff File
master a4727274 2010-01-11 19:21 unknown Details Diff	Improve indentation - left inconsistent by previous recent commits.
	mod - view_user_page.php		Diff File
	mod - adm_config_set.php		Diff File
	mod - print_all_bug_options_update.php		Diff File
	mod - bugnote_set_view_state.php		Diff File
	mod - manage_user_proj_delete.php		Diff File
	mod - manage_config_workflow_page.php		Diff File
	mod - lost_pwd.php		Diff File
	mod - manage_config_email_set.php		Diff File
	mod - account_prof_edit_page.php		Diff File
	mod - verify.php		Diff File
	mod - bug_sponsorship_list_view_inc.php		Diff File
	mod - manage_user_page.php		Diff File
	mod - proj_doc_add_page.php		Diff File
	mod - manage_user_proj_add.php		Diff File
	mod - bug_actiongroup_add_note_inc.php		Diff File
	mod - manage_proj_delete.php		Diff File
	mod - manage_user_create.php		Diff File
	mod - admin/install.php		Diff File
	mod - manage_proj_create.php		Diff File
	mod - manage_user_delete.php		Diff File
	mod - view_all_bug_page.php		Diff File
	mod - bug_actiongroup_ext.php		Diff File
	mod - manage_user_update.php		Diff File
	mod - query_view_page.php		Diff File
	mod - excel_xml_export.php		Diff File
	mod - manage_proj_cat_edit_page.php		Diff File
	mod - manage_proj_custom_field_add_existing.php		Diff File
	mod - manage_custom_field_proj_add.php		Diff File
	mod - signup.php		Diff File
	mod - tag_detach.php		Diff File
	mod - bug_assign.php		Diff File
	mod - news_add.php		Diff File
	mod - wiki.php		Diff File
	mod - bug_actiongroup_update_product_build_inc.php		Diff File
	mod - file_download.php		Diff File
	mod - bug_report.php		Diff File
	mod - bug_reminder_page.php		Diff File
	mod - manage_config_email_page.php		Diff File
	mod - login_select_proj_page.php		Diff File
	mod - print_all_bug_options_page.php		Diff File
	mod - bugnote_stats_inc.php		Diff File
	mod - manage_proj_edit_page.php		Diff File
	mod - manage_proj_update_children.php		Diff File
	mod - manage_proj_custom_field_copy.php		Diff File
	mod - tag_view_page.php		Diff File
	mod - login_anon.php		Diff File
	mod - account_prof_update.php		Diff File
	mod - bug_monitor_add.php		Diff File
	mod - bug_actiongroup.php		Diff File
	mod - lost_pwd_page.php		Diff File
	mod - manage_proj_user_add.php		Diff File
	mod - make_captcha_img.php		Diff File
	mod - manage_user_create_page.php		Diff File
	mod - issues_rss.php		Diff File
	mod - query_store.php		Diff File
	mod - manage_proj_create_page.php		Diff File
	mod - bugnote_add.php		Diff File
	mod - news_list_page.php		Diff File
	mod - tag_delete.php		Diff File
	mod - manage_custom_field_update.php		Diff File
	mod - account_update.php		Diff File
	mod - manage_user_prune.php		Diff File
	mod - login_cookie_test.php		Diff File
mod - signup_page.php		Diff File
mod - account_sponsor_page.php		Diff File
mod - bug_reminder.php		Diff File
mod - my_view_page.php		Diff File
mod - query_delete.php		Diff File
mod - bug_monitor_delete.php		Diff File
mod - manage_user_reset.php		Diff File
mod - adm_config_delete.php		Diff File
mod - manage_proj_user_copy.php		Diff File
mod - manage_proj_user_remove.php		Diff File
mod - bugnote_edit_page.php		Diff File
mod - account_prof_menu_page.php		Diff File
mod - manage_overview_page.php		Diff File
mod - meta_inc.php		Diff File
mod - manage_proj_cat_update.php		Diff File
mod - bug_actiongroup_attach_tags_inc.php		Diff File
mod - account_prefs_page.php		Diff File
mod - csv_export.php		Diff File
mod - query_store_page.php		Diff File
mod - print_bug_page.php		Diff File
mod - admin/check.php		Diff File
mod - print_all_bug_page_word.php		Diff File
mod - manage_proj_subproj_delete.php		Diff File
mod - billing_inc.php		Diff File
mod - bugnote_update.php		Diff File
mod - adm_permissions_report.php		Diff File
mod - proj_doc_edit_page.php		Diff File
mod - view_all_inc.php		Diff File
mod - manage_config_columns_set.php		Diff File
mod - news_rss.php		Diff File
mod - bug_view_inc.php		Diff File
mod - bug_stick.php		Diff File
mod - account_manage_columns_page.php		Diff File
mod - manage_config_work_threshold_page.php		Diff File
mod - bug_set_sponsorship.php		Diff File
mod - tag_attach.php		Diff File
mod - billing_page.php		Diff File
mod - xmlhttprequest.php		Diff File
mod - account_prefs_inc.php		Diff File
mod - login.php		Diff File
mod - manage_proj_ver_delete.php		Diff File
mod - manage_custom_field_edit_page.php		Diff File
mod - news_menu_page.php		Diff File
mod - manage_config_workflow_set.php		Diff File
mod - bug_file_upload_inc.php		Diff File
mod - main_page.php		Diff File
mod - bugnote_delete.php		Diff File
mod - manage_proj_ver_add.php		Diff File
mod - return_dynamic_filters.php		Diff File
mod - manage_proj_ver_update.php		Diff File
mod - history_inc.php		Diff File
mod - manage_config_columns_reset.php		Diff File
mod - jump_to_bug.php		Diff File
mod - bug_file_delete.php		Diff File
mod - proj_doc_delete.php		Diff File
mod - proj_doc_add.php		Diff File
mod - view_all_set.php		Diff File
mod - manage_proj_ver_copy.php		Diff File
mod - roadmap_page.php		Diff File
mod - tag_update.php		Diff File
mod - manage_proj_cat_delete.php		Diff File
mod - login_page.php		Diff File
mod - manage_custom_field_create.php		Diff File
mod - proj_doc_update.php		Diff File
mod - bug_file_add.php		Diff File
mod - manage_config_revert.php		Diff File
mod - news_view_page.php		Diff File
mod - bug_update.php		Diff File
mod - query_delete_page.php		Diff File
mod - manage_config_columns_page.php		Diff File
mod - summary_page.php		Diff File
mod - print_all_bug_options_reset.php		Diff File
mod - manage_columns_copy.php		Diff File
mod - account_page.php		Diff File
mod - manage_proj_page.php		Diff File
mod - manage_proj_custom_field_update.php		Diff File
mod - bug_actiongroup_ext_page.php		Diff File
mod - bug_relationship_graph_img.php		Diff File
mod - adm_config_report.php		Diff File
mod - manage_proj_cat_add.php		Diff File
mod - news_update.php		Diff File
mod - account_prefs_reset.php		Diff File
mod - logout_page.php		Diff File
mod - manage_user_edit_page.php		Diff File
mod - proj_doc_page.php		Diff File
mod - print_all_bug_page.php		Diff File
mod - bug_relationship_delete.php		Diff File
mod - set_project.php		Diff File
mod - bug_change_status_page.php		Diff File
mod - project_page.php		Diff File
mod - manage_proj_update.php		Diff File
mod - manage_proj_ver_edit_page.php		Diff File
mod - manage_proj_cat_copy.php		Diff File
mod - bug_assign_reporter.php		Diff File
mod - account_sponsor_update.php		Diff File
mod - bug_relationship_graph.php		Diff File
mod - manage_custom_field_delete.php		Diff File
mod - bug_relationship_add.php		Diff File
mod - manage_columns_inc.php		Diff File
mod - tag_update_page.php		Diff File
mod - view_filters_page.php		Diff File
mod - manage_config_work_threshold_set.php		Diff File
mod - bug_report_page.php		Diff File
mod - manage_proj_custom_field_remove.php		Diff File
mod - permalink_page.php		Diff File
mod - search.php		Diff File
mod - manage_custom_field_page.php		Diff File
mod - news_edit_page.php		Diff File
mod - account_prefs_update.php		Diff File
mod - manage_proj_subproj_add.php		Diff File
mod - bug_actiongroup_page.php		Diff File

Changesets: MantisBT