View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011395 | mantisbt | sql | public | 2010-01-15 03:10 | 2010-04-23 14:30 |
| Reporter | atrol | Assigned To | jreese | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 1.2.0rc2 | ||||
| Target Version | 1.2.1 | ||||
| Summary | 0011395: show_queries_list gives warnings instead of displaying queries | ||||
| Description | setting show_queries_list to value 1 with Manage -> Manage configurations leads to warnings setting to value ON in config_inc.php works fine | ||||
| Additional Information | nightly build from 14.01.2010 | ||||
| Tags | No tags attached. | ||||
|
This setting should be "global" in that it can only be changed from config_inc.php (and not from within the database configuration). I've patched 1.2.x and 1.3.x to mark the showqueries options as global, preventing them from being looked up (and stored) in the database configuration. Thanks for the report. |
|
|
I feared, that this will be your solution ;-) In 1.1.8 I was able to enable the query list feature for a single user. Is there a way to achieve this in config_inc.php? |
|
|
Please also have a look at http://www.mantisbt.org/bugs/view.php?id=11038 where I had another discussion concerning "what should be done only in config_inc.php, what in database" |
|
|
One of the concerns we have (and this is one of the key reasons why $g_global_settings exists) is that someone with access to the database - or access to a MantisBT administrator account - shouldn't be able to reconfigure MantisBT to access or execute arbitrary files on the hard disk. Ideally we shouldn't be trusting the data we pull from the database (because of issues like XSS injection via SQL injection or a cracked database password). We're not at that stage yet, of course. I do agree that allowing most configuration options to be stored in the database is a good idea. However, paths, specification of executable binaries (for graphviz, etc), URLs, page names, etc should generally be banned from being placed in the database IMO. By "banned", I mean that a user could easily reenable them if they understand the risks, but the default state would be to not allow those settings in the database. By storing paths and other sensitive settings in the database, we effectively open up the door to allowing malicious users with database access (or administrator access to set configuration values in the database) to: What we really need is a distinction between "protected", "per-project", "per-user" and "global" options. Protected: never store in the database We also then need to treat configuration from the database as being potentially malicious in nature. It may contain bad HTML/javascript (thus needs to be sanitised before being outputted). |
|
|
I agree with most of what you wrote. With your current changes maybe it is more unsecure than before, because I have to turn on queries list for all users. IMO developing the things "What we really need ..." should not be the reason that 1.2.0 final has further delay. There are two tasks: If 1) is a lot of effort and/or may lead to further problems, I would prefer if you could concentrate your time to finish 1.2.0 final or a RC3 |
|
|
Well put Atrol. BTW I also do not like feature creep, but IMHO The rest of this discussion maybe better to be continued in the forum. |
|
|
Why move to forum? Be aware, that most of the MantisBT developers do hardly contribute to the forum. |
|
|
atrol: sorry for the delayed response, I do plan on seeing if I can make this option work on a per-user basis again. And thanks for your help in the forums and on this bug tracker, it's a huge help to the developers. |
|
|
There should be no reason to set this in the database. By default, setting show_queries_list obeys the access level specified in show_queries_threshold, which defaults to ADMINISTRATOR. Assuming you trust anyone you've given ADMIN access to, this should already be doing exactly what you are trying to make it do... |
|
|
MantisBT: master-1.2.x f3d5815f 2010-01-15 09:01 Details Diff |
Fix 0011395: show_queries_list should be a global option |
Affected Issues 0011395 |
|
| mod - config_defaults_inc.php | Diff File | ||
|
MantisBT: master e22eeacf 2010-01-15 09:03 Details Diff |
Fix 0011395: show_queries_list should be a global option |
Affected Issues 0011395 |
|
| mod - config_defaults_inc.php | Diff File | ||