Changesets: MantisBT
|
master c7ceb3d2 2002-11-26 21:45 Julian Fitzell Details Diff |
Replace all instances of empty() with our new function called is_blank(). empty() is a horrid function which isn't intended for checking strings. It is intended for checking whether a variable is unset or false (or rather anything that == false, which includes 0 and ''). In every case, as far as we can tell, we are not checking for this but rather for whether the string contains information. So this function first performs trim() on the string and then checks whether the length is 0. The patch was submitted by Robert Foster <rfoster@mountainvisions.com.au> at my request. git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1626 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/icon_api.php | Diff File | ||
| mod - core/filter_api.php | Diff File | ||
| mod - manage_proj_cat_add.php | Diff File | ||
| mod - core/file_api.php | Diff File | ||
| mod - bug_view_page.php | Diff File | ||
| mod - manage_page.php | Diff File | ||
| mod - bug_update.php | Diff File | ||
| mod - bugnote_add.php | Diff File | ||
| mod - login_page.php | Diff File | ||
| mod - account_update.php | Diff File | ||
| mod - core/project_api.php | Diff File | ||
| mod - core/html_api.php | Diff File | ||
| mod - manage_user_create.php | Diff File | ||
| mod - manage_proj_ver_add.php | Diff File | ||
| mod - signup.php | Diff File | ||
| mod - print_all_bug_page.php | Diff File | ||
| mod - core/access_api.php | Diff File | ||
| mod - print_all_bug_page_excel.php | Diff File | ||
| mod - manage_proj_attribute_add.php | Diff File | ||
| mod - core/email_api.php | Diff File | ||
| mod - core/lang_api.php | Diff File | ||
| mod - core/print_api.php | Diff File | ||
| mod - set_project.php | Diff File | ||
| mod - bug_view_advanced_page.php | Diff File | ||
| mod - print_all_bug_page_word.php | Diff File | ||
| mod - account_prefs_inc.php | Diff File | ||
| mod - manage_proj_attribute_update.php | Diff File | ||
|
master 9c7bbf35 2002-11-26 21:42 Julian Fitzell Details Diff |
* helper_api.php (is_blank): add comment, rename parameters, remove isset() check since we don't see the need for doing that here, lowercase TRUE and FALSE git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1625 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/helper_api.php | Diff File | ||
|
master 87789de0 2002-11-25 03:06 Julian Fitzell Details Diff |
some work from Christian on custom fields I cleaned it up a bit though I haven't finished reviewing the newly added files Everything important should be prevented from loading unless you set the appropriate flag in your config file (see the bottom of config_defaults) git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1624 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/custom_field_api.php | Diff File | ||
| mod - manage_proj_edit_page.php | Diff File | ||
| add - manage_proj_custom_field_edit_page.php | Diff File | ||
| mod - constant_inc.php | Diff File | ||
| add - manage_proj_custom_field_add_existing.php | Diff File | ||
| add - manage_proj_custom_field_add_new.php | Diff File | ||
| mod - lang/strings_german.txt | Diff File | ||
| mod - core/API.php | Diff File | ||
| mod - lang/strings_english.txt | Diff File | ||
| add - manage_proj_custom_field_update.php | Diff File | ||
| mod - config_defaults_inc.php | Diff File | ||
| add - manage_proj_custom_field_delete.php | Diff File | ||
| add - manage_proj_custom_field_remove.php | Diff File | ||
|
master 19ba68dc 2002-11-24 15:43 Julian Fitzell Details Diff |
* bug_api.php (bug_create): + move the check for empty fields below the variable cleaning so the cleaning code is all kept together + use new is_blank() helper function instead of empty() (bug_update): + use new is_blank() helper function instead of empty() * helper_api.php (is_blank): new function to be used instead of empty(). it actually works with "0" and does the trimming for you git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1623 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/bug_api.php | Diff File | ||
| mod - core/helper_api.php | Diff File | ||
|
master 5080964f 2002-11-24 15:25 Julian Fitzell Details Diff |
* bug_api.php (bug_update): add calls to clear the bug cache and bug text cache after updating Odd... I thought I committed this but just found it in my WCOdd... I thought I committed this but just found it in my WC This was a fix, half of which was provided by Jean-Francois <jean-francois.travers2@fr.thalesgroup.com> that was causing out of date cached data to be used after modifying a bug git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1622 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/bug_api.php | Diff File | ||
|
master 8835274f 2002-11-19 00:31 Details Diff |
Fixed 2717: Where a bug could be submitted or update to have empty summary / description fields. The fix included added validation in bug_create() and bug_update() to reject submits/updates with empty trim(summary) or trim(description). git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1621 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/bug_api.php | Diff File | ||
|
master 77e39033 2002-11-18 16:24 Julian Fitzell Details Diff |
DOH! wrong file endings on this file... converting it to *nix line endings git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1620 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/custom_field_api.php | Diff File | ||
|
master effa61d9 2002-11-16 11:06 Julian Fitzell Details Diff |
fix error when reporting without submitting a file (in some versions anyway) where tmp_name was set to 'none' so the =='' check didn't work git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1619 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - bug_report.php | Diff File | ||
|
master b08548ee 2002-11-12 22:58 Julian Fitzell Details Diff |
* constant_inc.php: add ANYBODY and NOBODY to the access levels and replaces spaces with tabs everywhere * lang/strings_english.txt: new error for missing custom field * core/custom_field_api.php: new API file (in progress) Commit intial work on custom field api. Christian got the ball rolling, Victor and I reviewed it through several iterations. Though my intention was to simply do a quick review and check this in, doing so made me think about several things and I made some changes along the way. We can carry on from here as a base point. git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1618 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - lang/strings_english.txt | Diff File | ||
| mod - constant_inc.php | Diff File | ||
| add - core/custom_field_api.php | Diff File | ||
|
master 00c93ea0 2002-11-12 14:34 Julian Fitzell Details Diff |
might as well be consistent and use the 'ref' parameter everywhere instead of 'f_ref' We'd sort of decided to remove f_ from all the external parameters (not for the variable names) anyway git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1617 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - login_select_proj_page.php | Diff File | ||
| mod - set_project.php | Diff File | ||
|
master ccac03f3 2002-11-12 07:56 Details Diff |
- Added the following check to admin_check in case of Windows and remove the static contents relating to the fact that they are not available under Windows. $g_validate_email = OFF? $g_check_mx_record = OFF? - Some clean up + XHTML compliance changes. This file needs to be verified by an XHTML checker. git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1616 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - admin/admin_check.php | Diff File | ||
|
master 9e4fc1f3 2002-11-12 07:08 Details Diff |
- Fixed a problem in the defaulting of $g_path where it initialised as HTTPS rather than HTTP, and hence used to hang while trying to load the CSS. Might be IIS specific. - Fixed a problem in css_download.php where headers were sent before attempting to redirect. - Applied patch supplied by Andre Eisenbach to fix invalid redirection to main page after clicking on "Report Bug" and selecting the project (assuming All Projects was selected). - Minor optimisation in project_api.php - Fixed some typos/errors in ChangeLog. git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1615 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - config_defaults_inc.php | Diff File | ||
| mod - admin/css/css_download.php | Diff File | ||
| mod - doc/ChangeLog | Diff File | ||
| mod - core/project_api.php | Diff File | ||
| mod - login_select_proj_page.php | Diff File | ||
|
master fe289de5 2002-11-12 05:10 Julian Fitzell Details Diff |
* print_api.php (print_version_option_list): include an empty option since the version field is optional git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1614 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/print_api.php | Diff File | ||
|
master 41f6c592 2002-11-12 05:03 Julian Fitzell Details Diff |
* bug_update_page.php: Get the extended info for the bug so the description field can be filled in Fix from Andre Eisenbach <andre@eisenbach.com> git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1613 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - bug_update_page.php | Diff File | ||
|
master 289f64e3 2002-11-12 00:19 Julian Fitzell Details Diff |
Fix references to g_primary_colorN by adding helper_alternate_class() Also rename alternate_color() to helper_alternate_color() Remove background colour from some <td> tags Original patch by Andre <andre@eisenbach.com>, massaged by myself git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1612 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - manage_proj_edit_page.php | Diff File | ||
| mod - proj_doc_page.php | Diff File | ||
| mod - core/history_api.php | Diff File | ||
| mod - core/helper_api.php | Diff File | ||
| mod - manage_proj_menu_page.php | Diff File | ||
| mod - print_all_bug_page.php | Diff File | ||
| mod - core/error_api.php | Diff File | ||
| mod - manage_page.php | Diff File | ||
| mod - proj_user_menu_page.php | Diff File | ||
| mod - history_inc.php | Diff File | ||
| mod - core/summary_api.php | Diff File | ||
|
master 0f344f72 2002-11-11 05:36 Julian Fitzell Details Diff |
revert 1.22 and 1.23... scott apparently solved his problem with cookie settings and this didn't help git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1611 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/helper_api.php | Diff File | ||
|
master 84aeee7a 2002-11-10 18:29 Julian Fitzell Details Diff |
* string_api (string_process_bug_link): Fix issue 0002688 (using links with dashes for anchor in the description does not render fine ) by only allowing bug links to be generated when the special symbol is at the beginning of the line or preceeded by whitespace git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1610 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
Affected Issues 0002688 |
|
| mod - core/string_api.php | Diff File | ||
|
master 6f47e969 2002-11-10 17:43 Julian Fitzell Details Diff |
* lang_api.php: use u and p instead of user and pref for table names... apparently user is a keyword in mssql git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1609 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/lang_api.php | Diff File | ||
|
master 645e03ef 2002-11-10 17:32 Julian Fitzell Details Diff |
* user_pref_api.php (user_pref_insert): use the keys of the instvar dictionary for the column names, not the values thanks to ZipKid for noticing the problem on IRC git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1608 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/user_pref_api.php | Diff File | ||
|
master 64542fed 2002-11-10 17:31 Julian Fitzell Details Diff |
a little work on issue 0002686 (mantisbt.sourceforge.net/mantis/view_bug_advanced_page.php?f_id=0002686) but it isn't really fixed... this needs more work git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1607 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
Affected Issues 0002686 |
|
| mod - set_project.php | Diff File | ||
|
master 48db23c4 2002-11-10 17:02 Julian Fitzell Details Diff |
* manage_proj_cat_copy.php: clean up a bit to work without register_globals so I can make sure it's safe to close issue 0002566 git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1606 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
Affected Issues 0002566 |
|
| mod - manage_proj_cat_copy.php | Diff File | ||
|
master 47e187ca 2002-11-10 16:39 Julian Fitzell Details Diff |
include a comment as well git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1605 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/helper_api.php | Diff File | ||
|
master 7529133b 2002-11-10 16:38 Julian Fitzell Details Diff |
catch the case where a user doesn't have a default project set... this shouldn't happen but may happen with old DB data git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1604 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - core/helper_api.php | Diff File | ||
|
master c1acea7a 2002-10-30 05:44 Julian Fitzell Details Diff |
quick fix to get rid of an error... this file is by no means cleaned up git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1603 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - bugnote_inc.php | Diff File | ||
|
master dcb477a6 2002-10-30 05:42 Julian Fitzell Details Diff |
some more cleanup move the code to print out bug action buttons (delete, update, etc) into the html_api instead of duplicating it between advanced and simple views.. probably more of this can be done throughout the code base git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1602 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
||
| mod - bug_view_page.php | Diff File | ||
| mod - bug_view_advanced_page.php | Diff File | ||
| mod - bug_vote_add.php | Diff File | ||
| mod - core/html_api.php | Diff File | ||
