View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0010088mantisbtsignuppublic2009-01-27 07:152019-01-11 06:43
Reporterdrops Assigned Tograngeway  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
Product Version1.1.6 
Fixed in Version1.2.0rc1 
Summary0010088: Confirmation Link incorrect
Description

If I receive any confirmation mail in Entourage and click on the link it is incorrect and an error message is displayed:

for example I got:

http://www.mantisbt.org/bugs/verify.php?id=12905_hash=14e2dfbfc9c75d63e5c8f89a7dd815ca

but it should be

http://www.mantisbt.org/bugs/verify.php?id=12905&confirm_hash=14e2dfbfc9c75d63e5c8f89a7dd815ca

The reason being that in urls ampersands should be escaped.

Additionally I noticed that there are still \n in the e-mail instead of being replaced by the proper newline characters:

If you did not request any registration, ignore this message and nothing will
happen.\n\nDO NOT REPLY TO THIS MESSAGE

Steps To Reproduce

Sign up for a new account on any version between 1.1.1 and 1.1.6, receive the confirmation mail in Entourage and open the confirmation link in Safari.

Additional Information

I fixed this problem on my local installation by changing core/string_api.php:

    function string_get_confirm_hash_url( $p_user_id, $p_confirm_hash ) {
            $t_path = config_get( 'path' );
            return $t_path . "verify.php?id=" . string_url( $p_user_id ) . "&confirm_hash=" . string_url( $p_confirm_hash );
    }
TagsNo tags attached.

Activities

drops

drops

2009-01-27 07:17

reporter   ~0020725

Should be & amp; confirm_hash

but it changed it to just an ampersand.
grangeway

grangeway

2009-04-15 12:02

reporter   ~0021556

Fixed in Git trunk

Thanks

Paul
siebrand

siebrand

2009-06-11 09:13

reporter   ~0022084

Re-opening this, because the solution was reverted. Caused a regression for all other mail clients (webmail, Outlook, for example). Entourage broken?

Related Changesets

MantisBT: master a3ba2c2f

2009-04-15 12:02

Paul Richards


Details Diff		 Fix: 0010088: Confirmation Link incorrect Affected Issues
0010088, 0010369
mod - core/string_api.php Diff File