View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0010231 | mantisbt | feature | public | 2009-03-20 00:45 | 2009-04-20 09:49 |
Reporter | Assigned To | jreese | |||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.0a3 | ||||
Target Version | 1.1.7 | Fixed in Version | 1.1.7 | ||
Summary | 0010231: Assigned bug status cannot be changed to new? | ||||
Description | When a bug is assigned to some one, its status cannot be changed to new. If we need to change the status to 'NEW', then we need to first change the Assignee to default ie) empty and then if we change the status to new, it is getting changed Is this is a Defect? | ||||
Tags | No tags attached. | ||||
Attached Files | bug_10231.patch (1,211 bytes)
From ad29a1cefe8f5b77efdc51f00f68127b0e50daa4 Mon Sep 17 00:00:00 2001 From: Brian Wrightson <brian.wrightson@gmail.com> Date: Tue, 31 Mar 2009 23:04:53 -0400 Subject: [PATCH] Fix #10231: Can't change bugs from Assigned to New The "auto-assign handling" was preventing the ability to assign a bug that was assigned to a User back to New status. I can't see that this piece of code does anything except cause that problem so I removed it. --- bug_update.php | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/bug_update.php b/bug_update.php index e1e7747..7a5f5b9 100644 --- a/bug_update.php +++ b/bug_update.php @@ -87,13 +87,6 @@ $f_time_tracking = gpc_get_string( 'time_tracking', '0:00' ); $f_close_now = gpc_get_string( 'close_now', false ); - # Handle auto-assigning - if ( ( NEW_ == $t_bug_data->status ) - && ( 0 != $t_bug_data->handler_id ) - && ( ON == config_get( 'auto_set_status_to_assigned' ) ) ) { - $t_bug_data->status = config_get( 'bug_assigned_status' ); - } - helper_call_custom_function( 'issue_update_validate', array( $f_bug_id, $t_bug_data, $f_bugnote_text ) ); $t_resolved = config_get( 'bug_resolved_status_threshold' ); -- 1.6.1 bug_10231_UPDATE.patch (844 bytes)
From a43f49efe40ba13d7656924ddbc5580dfbcd284d Mon Sep 17 00:00:00 2001 From: Brian Wrightson <brian.wrightson@gmail.com> Date: Tue, 31 Mar 2009 23:04:53 -0400 Subject: [PATCH] Fix #10231: Can't change bugs from Assigned to New Put in a check so that an issue won't be auto-assigned if the Handler is updated but the Status is not. --- bug_update.php | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/bug_update.php b/bug_update.php index e1e7747..b1fbe99 100644 --- a/bug_update.php +++ b/bug_update.php @@ -89,6 +89,7 @@ # Handle auto-assigning if ( ( NEW_ == $t_bug_data->status ) + && ( $t_bug_data->status == $t_old_bug_status ) && ( 0 != $t_bug_data->handler_id ) && ( ON == config_get( 'auto_set_status_to_assigned' ) ) ) { $t_bug_data->status = config_get( 'bug_assigned_status' ); -- 1.6.1 | ||||
Just tested. The only problem I see is that the assigned=>new transition fails (or is ignored) silently. Yes, looks like something to fix |
|
is this a problem in 1.1.x as well? |
|
I just removed the small chunk of code that was labeled "Handle auto-assigning" and everything seems to work fine. I couldn't find anything else that that particular piece of code did except create the problem outlined in this bug. |
|
Thanks a lot. Issue has been fixed. |
|
That patch "fixes" the reported issue at the expense of some functionality - I'll update it again tonight. |
|
Attaching a related IRC log: <pre>13:09 < bleftson> http://www.mantisbt.org/bugs/view.php?id=10231 |
|
OK, the new patch (bug_10231_UPDATE.patch) should allow Assigned->New without killing auto-assign functionality. |
|
Fix committed to 1.1.7 and 1.2.x development branches. |
|
The new patch gives me some issue: Parse error: syntax error, unexpected $end in C:\Documents and Settings\prabhu_rangan\workspace\mylo\bug_update.php on line 240 |
|
I'm sorry to hear that! I've been trying to reproduce this problem but I've been unable to. Question: I noticed that for you the error occurs on line 240, but my bug_update.php file doesn't even have 240 lines. Are you sure the error is not occurring for some other reason? It's usually do to a missing curly brace. Thoughts? |
|
MantisBT: master 3b837f17 2009-03-31 23:04 Details Diff |
Fix 0010231: Can't change bugs from Assigned to New Put in a check so that an issue won't be auto-assigned if the Handler is updated but the Status is not. <span class="signoff">Signed-off-by: John Reese <jreese@leetcode.net></span> |
Affected Issues 0010231 |
|
mod - bug_update.php | Diff File | ||
MantisBT: master-1.1.x 02288569 2009-03-31 23:04 Details Diff |
Fix 0010231: Can't change bugs from Assigned to New Put in a check so that an issue won't be auto-assigned if the Handler is updated but the Status is not. <span class="signoff">Signed-off-by: John Reese <jreese@leetcode.net></span> |
Affected Issues 0010231 |
|
mod - bug_update.php | Diff File |