View Issue Details

IDProjectCategoryView StatusLast Update
0010558mantisbtchange logpublic2009-06-23 15:28
ReporteraCCuReRaS Assigned Tojreese  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.0a3 
Target Version1.2.0rc1Fixed in Version1.2.0rc1 
Summary0010558: Wrong sorting on changelog/roadmap
Description

Since I upgraded from 1.1.2 to 1.2.0a3 the sorting of the versions on the changelog and roadmap pages has changed.
Before, the latest version for the roadmap was the first version to release (the lowest version number) and for the changelog, it was the latest released version.
After the upgrade, this is the other way around.

I see 2 possible fixes:

  • adjust the sorting like it was before
  • foresee an option to configure sorting
TagsNo tags attached.

Activities

jreese

jreese

2009-06-04 07:45

reporter   ~0022043

I've noticed the same problem on this tracker. I'll take a look at this today, and hopefully git-bisect will help me track down the culprit.

jreese

jreese

2009-06-04 11:14

reporter   ~0022044

Last edited: 2009-06-04 11:14

I pulled a local copy of the live database (minus all user information),
and ran git-bisect between 1.2.0a2 and the current live revision,
using the roadmap page as my method of verification. After drilling
down, Git reported:

0ac196a4639d01c627aa6b2886a84f5ee9eeb4b4 is first bad commit
commit 0ac196a4639d01c627aa6b2886a84f5ee9eeb4b4
Author: Paul Richards paul@mantisforge.org
Date: Sun Apr 5 16:54:24 2009 +0100

 Sync my working checkout of misc performance changes/mssql fixes:

 1) add some caching around version/categories/projects to speed up 

projects with a large number of categories/versions etc
2) database_api: improve db_fetch_array when running under pgsql
3) tag_api: fix for mssql+mysql by implementing different query
logic :(
4) manage_proj_page: add improvement noted in bug 0008850

:100644 100644 becfa198e7178ccfba4542d1f4b08c03e25b00f5
cfd53781de6aef0d15afab4b1b7044236142a191 M changelog_page.php
:040000 040000 3ec3f5e1dcf43a5ec62086f9e91c22f07127e7a7
b4e12e9519887f2ac4435fbb423a100d52f056c0 M core
:100644 100644 343c03fd25f91dd02f1b6ac0cec7cf1de8c6232b
07f7700a47a5e2bf15477d75d701657dfcb22fdb M manage_proj_page.php
:100644 100644 0b7b2e1ca9f585e73a5a258e5ca5d2ad1a219f78
0d23e47ae43425d83f3aada9eb6b6051210d17f1 M roadmap_page.php
:100644 100644 0ac65217e98095bd58a7f123096212e0a441469c
7dbd490f141f204f6cb71a459b040a65fde52cb7 M summary_page.php

The problem was that the data caching introduced in this commit did not
utilize an "order by" clause like the standard query, which roadmap_page
and changelog_page both rely on for sorting versions by date. This
resulted in both pages containing an arbitrary sorting order. I've
committed the fix to Git master.

Related Changesets

MantisBT: master 7104a343

2009-06-04 11:02

jreese


Details Diff
Fix 0010558: Fix roadmap and changelog ordering bug as introduced in commit ref 0ac196a4.
Version caching queries should use the same order by clause as the standard functions.
Affected Issues
0010558
mod - core/version_api.php Diff File