View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0010708 | mantisbt | relationships | public | 2009-07-10 21:31 | 2010-02-18 11:50 |
Reporter | dhx | Assigned To | vboctor | ||
Priority | high | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.0rc2 | ||||
Target Version | 1.2.0rc2 | ||||
Summary | 0010708: Relationship graphs broken after refactoring of bug_view_inc.php | ||||
Description | After the refactoring done in bug 0010696, relationship graphs no longer work. This is because bug_relationship_graph includes bug_view_inc.php and with all the changes, it results in an access denied message. As a quicker fix, I suggest removing bug_relationship_graph.php completely and placing this functionality in bug_relationship_inc.php with some parameters to choose vertical/horizontal mode and so forth. Then we can include this file from within bug_view_inc.php (and elsewhere?) as appropriate. The better long term fix is to separate out relationship graphs to a core plugin in the same way MantisGraph was created. | ||||
Tags | No tags attached. | ||||
@dhx, I've fixed reminders and relationship graphs. Can you please verify the fix on master before I port it to 1.2.x branch? I don't have relationship graphs set up on my machine to fully verify the fix. |
|
Thanks, that fixes part of the problem. I'm still not having any luck with the graphs showing up. I'm getting Content-Length: 0 for the relationship graphs... ie: GET /mantis/bug_relationship_graph_img.php?bug_id=43&graph=relation&orientation=horizontal HTTP/1.1 Host: localhost User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-GB; rv:1.9.1) Gecko/20090701 Gentoo Firefox/3.5 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8 Accept-Language: en-gb,en;q=0.5 Accept-Encoding: gzip,deflate Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive: 300 Connection: keep-alive Cookie: mantis_VIEW_ALL_COOKIE=1; MantisBT-localhost_VIEW_ALL_COOKIE=1; MantisBT-localhost_secure_session=0; MantisBT-localhost_BUG_LIST_COOKIE=(removed); PHPSESSID=(removed); MantisBT-localhost_STRING_COOKIE=(removed) HTTP/1.x 200 OK X-Powered-By: PHP/5.2.10-pl1-gentoo Cache-Control: no-store, no-cache, must-revalidate Expires: Tue, 14 Jul 2009 02:28:15 GMT Last-Modified: Tue, 14 Jul 2009 02:28:15 GMT Content-Type: image/png Content-Length: 0 Date: Tue, 14 Jul 2009 02:28:15 GMT Server: lighttpd/1.4.23 I suspect this might be an error with execution of dot/neato, so I'll do some further debugging to try and fix it (it is probably FastCGI related as I recently switched to using this method). |
|
I'll mark this issue as fixed. I won't set the fixed in version given that this was introduced by another check-in post 1.2.0rc1. Hence, it won't appear in changelog. Please open a separate bug for the bug relationship graphs not working, if applicable. |
|
This wasn't backported to the 1.2.x branch so the errors described in this issue have impacted the 1.2.x branch for almost 6 months now. I've backported and tested this patch on 1.2.x... all is OK now. I'm surprised I was the first person to notice! |
|
MantisBT: master 29b13fb8 2009-07-12 18:04 Details Diff |
Issue 0010708: Relationship graphs broken after refactoring of bug_view_inc.php - Fixed the access_denied issue in relationship graphs. - Fixed the access_denied issue in bug reminders. I don't have the relationship graphs setup, so won't mark the issue as resolved yet until dhx verifies it. |
Affected Issues 0010708 |
|
mod - bug_relationship_graph.php | Diff File | ||
mod - view.php | Diff File | ||
mod - bug_reminder_page.php | Diff File | ||
MantisBT: master-1.2.x 633799cf 2009-07-12 18:04 Committer: dhx Details Diff |
Issue 0010708: Relationship graphs broken after refactoring of bug_view_inc.php - Fixed the access_denied issue in relationship graphs. - Fixed the access_denied issue in bug reminders. I don't have the relationship graphs setup, so won't mark the issue as resolved yet until dhx verifies it. Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0010708 |
|
mod - view.php | Diff File | ||
mod - bug_relationship_graph.php | Diff File | ||
mod - bug_reminder_page.php | Diff File |