View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0010758mantisbtreportspublic2009-07-23 10:002009-10-07 14:19
Reporterfloh Assigned Todhx  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformx86OSWin XP Pro 32-BitOS Version2002
Product Version1.2.0rc1 
Target Version1.2.0rc2Fixed in Version1.2.0rc2 
Summary0010758: Graph Plugin pages do not use "width"
Description

The pages bug_graph_page, summary_graphimp* and summary_jpgraph_page do not show the graphs in the correct width. This is caused by the fact
that plugin pages are called using "plugin.php?page=..." and the width is passed by "?width=..." so there are 2 "?" in the request (see screenshot).

I corrected it for the current git HEAD files and will attach it as zip file. Can someone please transfer it to the git trunk?

Tagsplugin
Attached Files
GraphPluginProblem.jpg (24,944 bytes)   
GraphPluginProblem.jpg (24,944 bytes)   
MantisGraphPages-git.zip (9,098 bytes)

Activities

dhx

dhx

2009-07-23 21:24

reporter   ~0022549

Thanks for finding and patching this. I've committed a fix to the git repository.

In the future are you able to provide patches as diffs (and specify the commit ID of the git HEAD version you made the patch against)? It makes it a lot easier for developers to apply the patch to the current tree. If it's all together as one file we have to manually do a diff ourselves, and also have to guess what version to diff against.

In this case I just patched it from scratch myself because it was easier than trying to work out what changes you made.

The other advantage of providing patches in a git am format is that you can have your name attached as the author on a patch... if that is something you don't mind doing.

Related Changesets

MantisBT: master b23a65c7

2009-07-23 21:04

dhx


Details Diff		 Fix 0010758: MantisGraph width GET parameter has incorrect syntax

When moving to the new MantisGraph plugin, the URLs changed slightly so
that parameters which were first are now second (the plugin page is
first). Therefore the second paramter should be appended with an
ampersand instead of question mark.

Thanks to floh for assistance in fixing this bug.		 Affected Issues
0010758
mod - plugins/MantisGraph/pages/bug_graph_page.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_status.php Diff File
mod - plugins/MantisGraph/pages/summary_jpgraph_page.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_severity.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_resolution.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_priority.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_category.php Diff File

MantisBT: master-1.2.x 05487d5c

2009-07-23 21:04

dhx


Details Diff		 Fix 0010758: MantisGraph width GET parameter has incorrect syntax

When moving to the new MantisGraph plugin, the URLs changed slightly so
that parameters which were first are now second (the plugin page is
first). Therefore the second paramter should be appended with an
ampersand instead of question mark.

Thanks to floh for assistance in fixing this bug.		 Affected Issues
0010758
mod - plugins/MantisGraph/pages/bug_graph_page.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_status.php Diff File
mod - plugins/MantisGraph/pages/summary_jpgraph_page.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_severity.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_resolution.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_priority.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_category.php Diff File