View Issue Details

IDProjectCategoryView StatusLast Update
0010844mantisbtbugtrackerpublic2009-10-07 14:19
Reportercmfitch1 Assigned Todhx  
PrioritylowSeverityminorReproducibilityalways
Status closedResolutionfixed 
Target Version1.2.0rc2Fixed in Version1.2.0rc2 
Summary0010844: When viewing bugnote revisions, the heading is always "View Revisions: Note 0"
Description

The page that shows bugnote revisions is attempting to print the bug id instead of the bugnote id in the title.

TagsNo tags attached.
Attached Files
issue_10844.patch (731 bytes)   
From b70f8090dded9835c31439304b025875291cfd53 Mon Sep 17 00:00:00 2001
From: Chris Fitch <cfitch@redcom.com>
Date: Mon, 17 Aug 2009 13:11:22 -0400
Subject: [PATCH] Fix bugnote on revision page


diff --git a/bug_revision_view_page.php b/bug_revision_view_page.php
index a1e9cc5..4dff6be 100644
--- a/bug_revision_view_page.php
+++ b/bug_revision_view_page.php
@@ -43,7 +43,7 @@ if ( $f_bug_id ) {
 
 	$t_bug_revisions = array_reverse( bug_revision_list( $t_bug_id, REV_ANY, $f_bugnote_id ), true );
 
-	$t_title = lang_get( 'bugnote' ) . ' ' . $f_bug_id;
+	$t_title = lang_get( 'bugnote' ) . ' ' . $f_bugnote_id;
 
 } else if ( $f_rev_id ) {
 	$t_bug_revisions = array_reverse( bug_revision_like( $f_rev_id ), true );
-- 
1.6.0.4

issue_10844.patch (731 bytes)   

Activities

dhx

dhx

2009-08-18 21:45

reporter   ~0022760

Thanks Chris for making this so easy to fix. The world would be a much better place if everyone knew how to use git format-patch :)

I've committed your fix to 1.3.x and 1.2.x.

Thanks again!

Related Changesets

MantisBT: master-1.2.x e58acd93

2009-08-17 13:11

Chris Fitch

Committer: dhx


Details Diff
Fix 0010844: bugnote id not showing on view bugnote revisions page

When viewing a bugnote revision page, the user will always see "View
Revisions: Note 0" where the 0 should actually be the relevant bugnote
ID. This error is caused by trying to use the non-existant bug_id where
we should be using f_bugnote_id.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010844
mod - bug_revision_view_page.php Diff File

MantisBT: master a178518c

2009-08-17 13:11

Chris Fitch

Committer: dhx


Details Diff
Fix 0010844: bugnote id not showing on view bugnote revisions page

When viewing a bugnote revision page, the user will always see "View
Revisions: Note 0" where the 0 should actually be the relevant bugnote
ID. This error is caused by trying to use the non-existant bug_id where
we should be using f_bugnote_id.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010844
mod - bug_revision_view_page.php Diff File