View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011021 | mantisbt | bugtracker | public | 2009-10-08 08:42 | 2010-02-22 14:34 |
| Reporter | frodgers | Assigned To | dhx | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.2.0rc2 | ||||
| Target Version | 1.2.0 | Fixed in Version | 1.2.0 | ||
| Summary | 0011021: Bug history does not display new value | ||||
| Description | If history's new value is zero bug history will only display the old value. Instead of the old => new format. | ||||
| Additional Information | I've supplied a patch to correct this issue. | ||||
| Tags | patch | ||||
| Attached Files | history_api.patch (869 bytes)
From 98c15f3ea16a9a088c57168c9c8bc1a53587ee86 Mon Sep 17 00:00:00 2001
From: Frank Rodgers <frodgers@redcom.com>
Date: Thu, 8 Oct 2009 08:24:07 -0400
Subject: [PATCH] If a history new value is zero the change was not displayed, just the old value
diff --git a/core/history_api.php b/core/history_api.php
index 2d97e57..044bc47 100644
--- a/core/history_api.php
+++ b/core/history_api.php
@@ -247,7 +247,7 @@ function history_localize_item( $p_field_name, $p_type, $p_old_value, $p_new_val
if( PLUGIN_HISTORY == $p_type ) {
$t_note = lang_get_defaulted( "plugin_$p_field_name", $p_field_name );
- $t_change = ( $p_new_value ? "$p_old_value => $p_new_value" : $p_old_value );
+ $t_change = ( isset( $p_new_value ) ? "$p_old_value => $p_new_value" : $p_old_value );
return array( 'note' => $t_note, 'change' => $t_change, 'raw' => true );
}
--
1.6.0.4
| ||||
|
MantisBT: master-1.2.x fef32201 2009-10-08 08:24 Committer: dhx Details Diff |
Fix 0011021: Bug history does not display new null/zero values Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0011021 |
|
| mod - core/history_api.php | Diff File | ||
|
MantisBT: master 0056967d 2009-10-08 08:24 Committer: dhx Details Diff |
Fix 0011021: Bug history does not display new null/zero values Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0011021 |
|
| mod - core/history_api.php | Diff File | ||