0011560: adodb warning - check.php

ID	Project	Category	View Status	Date Submitted	Last Update
0011560	mantisbt	installation	public	2010-02-25 20:22	2012-08-07 08:16

Reporter	NetAndroid	Assigned To	dhx
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	fixed
Product Version	1.2.0
Target Version	1.2.1	Fixed in Version	1.2.1

Summary	0011560: adodb warning - check.php
Description	i use the actual 1.2.0 release and got via ./admin/check.php the following WARN: Checking adodb version... 5.1 - WARN
Tags	No tags attached.

tk 2010-02-26 01:39 reporter ~0024529	see the same problem. caused by wrong version check logic: test is "5.1 >= 5.05" which failes

dhx 2010-02-26 07:58 reporter ~0024539	I reported this upstream a while ago and it is "fixed" awaiting a new release of ADOdb. See http://phplens.com/lens/lensforum/msgs.php?id=18320 Essentially the problem is that the Version() function in ADOdb was returning a float value so that version 5.10 was rounded down to a float value of 5.1 - thus it's impossible to know whether the version of ADOdb is 5.1 or 5.10. More to the point, check.php can't use version_compare() on a float value because version_compare() only works with strings. I actually have a completely rewritten check.php (far superior in every way) that I'm going to commit for the 1.3.x release of MantisBT (with an ADOdb check not affected by this bug).

dhx 2010-02-26 20:45 reporter ~0024557	Problem solved :)

MantisBT: master-1.2.x 76cd989e 2010-02-26 20:39 dhx Details Diff	Fix 0011560: ADOdb version check in check.php is incorrect See upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=18320 for the reason as to why this change is necessary. version_compare works with strings, not float values. And the Version() function in ADOdb should not be returning floats anyway (there is no way to determine if the version if 5.1 or 5.10 from a float value).	Affected Issues 0011560
	mod - admin/check.php	Diff File
MantisBT: master 916f1143 2010-02-26 20:39 dhx Details Diff	Fix 0011560: ADOdb version check in check.php is incorrect See upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=18320 for the reason as to why this change is necessary. version_compare works with strings, not float values. And the Version() function in ADOdb should not be returning floats anyway (there is no way to determine if the version if 5.1 or 5.10 from a float value).	Affected Issues 0011560
	mod - admin/check.php	Diff File