View Issue Details

IDProjectCategoryView StatusLast Update
0011773mantisbtplug-inspublic2010-04-23 14:30
Reportertcplomp Assigned Tojreese  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.0 
Target Version1.2.1Fixed in Version1.2.1 
Summary0011773: Plugin init process can leave some plugins behind
Description

I installed the source integration plugins (http://git.mantisforge.org/w/source-integration.git) together with the HGWeb plugin (http://git.mantisforge.org/w/source-integration/dhx.git?a=shortlog;h=refs/heads/hgweb).

However when I wanted to create a new repository not all the (expected) repository types were shown. I had to delete several repository plugins to get the type I wanted to use.

Steps To Reproduce

Install multiple (>4) source integration plugins
Check if all options for a new repositories are available

TagsNo tags attached.

Activities

tcplomp

tcplomp

2010-04-08 16:44

reporter   ~0025076

I submitted the issue to Leetcode.net (http://leetcode.net/mantis/view.php?id=132) seems more appropriate. This issue can be rejected.

My apologies.

jreese

jreese

2010-04-08 16:59

reporter   ~0025077

This is a problem with the plugin initialization process. There are a few edge cases where plugins at the end of complex dependency chains will be left unitialized by the plugin API.

jreese

jreese

2010-04-08 17:34

reporter   ~0025078

Fix committed to master and 1.2.x branches.

obones

obones

2010-04-13 10:40

reporter   ~0025115

FYI, I applied this patch to my 1.2.0 installation here, it fixed the problem I had where WebSVN would not be initialized because I had other unrelated plugins initialized before it.
Thanks for this fix.

Related Changesets

MantisBT: master-1.2.x 5ef2ad87

2010-04-08 17:13

jreese


Details Diff
Fix 0011773: Plugin init process edge case

This fixes the plugin initialization code so that it will continue to
attempt plugin init passes as long as at least one plugin was
initialized during the previous pass. This fixes the edge cases where
plugins in complex dependency chains could remain uninitialized by the
previous logic.
Affected Issues
0011773
mod - core/plugin_api.php Diff File

MantisBT: master b66fbc3b

2010-04-08 17:13

jreese


Details Diff
Fix 0011773: Plugin init process edge case

This fixes the plugin initialization code so that it will continue to
attempt plugin init passes as long as at least one plugin was
initialized during the previous pass. This fixes the edge cases where
plugins in complex dependency chains could remain uninitialized by the
previous logic.
Affected Issues
0011773
mod - core/plugin_api.php Diff File