View Issue Details

IDProjectCategoryView StatusLast Update
0012166mantisbtldappublic2011-04-05 14:23
Reporterdregad Assigned Todhx  
PrioritylowSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.1 
Target Version1.2.5Fixed in Version1.2.5 
Summary0012166: LDAP logging confusing text
Description

When authenticating with LDAP and generating a log file, one of the lines generated looks as follows:

2010-07-13 17:56 CEST ldap Setting LDAP protocol to to ldap server to 3

Shouldn't it be something like "Setting LDAP protocol version to 3" ?

Tagspatch
Attached Files
0001-Fix-12166-LDAP-log-message-changed.patch (893 bytes)   
From 97279529e43bf3aaf0c22eb998d05eb6b874a4bb Mon Sep 17 00:00:00 2001
From: Damien Regad <damien.regad@merckserono.net>
Date: Wed, 3 Nov 2010 10:37:04 +0100
Subject: [PATCH 1/2] Fix #12166: LDAP log message changed

---
 core/ldap_api.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/core/ldap_api.php b/core/ldap_api.php
index 2636ec1..d962afc 100644
--- a/core/ldap_api.php
+++ b/core/ldap_api.php
@@ -45,7 +45,7 @@ function ldap_connect_bind( $p_binddn = '', $p_password = '' ) {
 		$t_protocol_version = config_get( 'ldap_protocol_version' );
 
 		if( $t_protocol_version > 0 ) {
-			log_event( LOG_LDAP, "Setting LDAP protocol to  to ldap server to " . $t_protocol_version );
+			log_event( LOG_LDAP, "Setting LDAP protocol version to " . $t_protocol_version );
 			ldap_set_option( $t_ds, LDAP_OPT_PROTOCOL_VERSION, $t_protocol_version );
 		}
 
-- 
1.7.1

Relationships

child of 0012167 closeddhx LDAP port parameter is ignored 

Activities

dregad

dregad

2010-11-04 11:31

developer   ~0027248

Last edited: 2010-11-04 11:32

Patch for 1.2.x attached

See also 0012167 for additional LDAP logging improvements

dregad

dregad

2010-11-24 12:48

developer   ~0027479

Please disregard the attached patch, and use the one just uploaded in 0012167.

Related Changesets

MantisBT: master-1.2.x b3e7646f

2010-11-03 05:37

Damien Regad

Committer: dhx


Details Diff
Fix 0012166: LDAP log message changed

Signed-off-by: David Hicks <d@hx.id.au>
Affected Issues
0012166
mod - core/ldap_api.php Diff File

MantisBT: master 98669e05

2010-11-03 05:37

Damien Regad

Committer: dhx


Details Diff
Fix 0012166: LDAP log message changed

Signed-off-by: David Hicks <d@hx.id.au>
Affected Issues
0012166
mod - core/ldap_api.php Diff File