View Issue Details

IDProjectCategoryView StatusLast Update
0014417mantisbtrelationshipspublic2014-10-03 17:39
Reporterj_schultz Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product Version1.2.11 
Summary0014417: Adding duplicate relationship should not set "modified" date of parent issue
Description

I think it's not very logical that the "last modified" date of the parent issue is modified if I add a "is duplicate of" relationship to another issue.
This behaviour suggests that the parent issue (which might have been fixed already) was updated or is still active as it's pushed to the top of the recently modified issues list.

Steps To Reproduce

Add relationship "is duplicate of" to an issue. Both issues are updated and get a new "last modified" time.

Additional Information

I'm not sure if this action also sends an update email to all people subscribing to the original parent issue, but if it does, this would certainly be a reason not to change the update status of the parent issue. I guess people who previously subscribed to an already fixed issue don't want to be notified if someone else reports the same problem and the new issue is linked with the old one.

TagsNo tags attached.

Relationships

related to 0012628 closedrombert Update last change date for both bugs when updating a relationship 
related to 0007453 new Difference between last_updated in bug_table and date_modified in date_modified 

Activities

j_schultz

j_schultz

2012-07-07 13:25

reporter   ~0032268

The bug summary contains a freudian typo, of course: It should be "Adding duplicate relationship should not set "modified" date of parent issue".

atrol

atrol

2012-07-07 13:28

developer   ~0032269

Removed the freudian

dregad

dregad

2012-07-09 03:45

developer   ~0032272

I tend to disagree with this - from my point of view, adding a relationship is an update of both affected bugs, and as such the last updated date should be bumped.

As a side note, updating only one of the issues has been considered as a bug (0012628, fixed in 1.2.5).

j_schultz

j_schultz

2012-07-09 09:26

reporter   ~0032279

I personally rather see this related to 0007633 - both actions are technically an update, but you probably don't want to see the issue being bumped to the top of the issue list just because someone has edited a note or added a relationship. Especially in the case of issues that have been resolved long ago, it is annoying to see them at the top again just because someone else has reported the same issue again and you want to mark the new issue as a duplicate.

dregad

dregad

2012-07-09 22:54

developer   ~0032287

j_schultz: I'm not sure if I understand your point correctly, your statement sounds contradictory: "both actions are technically an update" vs "don't want to see the issue being bumped to the top" - kinda hard to have one without the other, no ?

I can understand the "annoying" bit, but if we accept the fact that adding a relationship (or editing a note) is an update, then how do you propose to handle things ?

atrol

atrol

2012-07-10 03:09

developer   ~0032292

j_schultz, sometimes editing a note is worth to bump the issue (user added valuable content, removed a freudian typo) sometimes not (user removed a typo).
Something which is not easy to distingiush by MantisBT.

j_schultz

j_schultz

2012-07-10 06:47

reporter   ~0032293

Sorry, I misread the bug description, so it is not related to the behaviour I suggest at all.

But I'd like to hear your reason why exactly it is necessary to bump a (maybe already closed) issue to the top if someone reports a similar issue and send a mail to all people who subscribed to the issue.

Would it be agreeable that the current behaviour remains for open issues, but not bumping the original issue for closed/resolved issues?

atrol

atrol

2012-07-10 07:39

developer   ~0032295

Last edited: 2012-07-10 07:54

Would it be agreeable that the current behaviour remains for open issues, but not bumping the original issue for closed/resolved issues?

I am quite sure this will introduce even more confusion and another round of discussions with other users.

Maybe 0007840 is what you really want + a plugin which allows you to define your additional rules to the filter.
This is possible but will not have the best performance because you have to look at the history of every issue.

[UPDATE 1]
You would not need the plugin, filtering by "Hide Status" "Resolved and above" is enough and works also for the "View Issues" page in 1.2.11

[UPDATE 2]
Maybe setting $g_hide_status_default = RESOVLED; is able to get what you want for some of your use cases

j_schultz

j_schultz

2012-07-14 09:16

reporter   ~0032326

Honestly I think all of that are just workarounds which do not address the core problem in my opinion. If you don't agree that it would be more logical to just update one issues, that's okay, but I don't really see the neccessity behind it.

atrol

atrol

2012-07-14 11:24

developer   ~0032330

OK, back to the core problem:
"Adding duplicate relationship should not set "modified" date of parent issue"

It's a solution for you if MantisBT would not set the date in future versions.
But it's a regression for other users, see 0012268 0008911 0007453.

Do we need another configuration option?
Something like $g_update_modified_date_for_relationships = ON;

atrol

atrol

2012-07-14 11:25

developer   ~0032331

Reminder sent to: rombert

You opened 0012628, what do you think?

j_schultz

j_schultz

2012-07-14 11:27

reporter   ~0032332

I think a configuration option would be a great solution, since I can imagine that there are more people who agree with me but I can also understand if people prefer it to stay as it is.

rombert

rombert

2012-07-15 07:30

reporter   ~0032337

(In reply to comment 0014417:0032331)

You opened 0012628, what do you think?

I did that specifically for the SOAP API, not for the core api. The SOAP API now follows the core api in this respect.

I can see why you want to have a more restrictive definition of bug change, but I don't have a strong opinion regarding the configuration option . However, it would add quite a bit more complexity to our code so we should be 100% certain we want to add this feature and support it.

grangeway

grangeway

2014-10-03 17:39

reporter   ~0041338

Have submitted PR https://github.com/mantisbt/mantisbt/pull/366 that would ensure that last update is changed for both bugs when changing a relationship that would generate a history entry (and therefore we've argued in the past constitute an update to a bug)