0014887: time tracking on bug_change_status_page.php depends on private_bugnote_threshold

ID	Project	Category	View Status	Date Submitted	Last Update
0014887	mantisbt	time tracking	public	2012-10-30 12:09	2012-11-12 07:09

Reporter	riks	Assigned To
Priority	normal	Severity	minor	Reproducibility	always
Status	new	Resolution	open
Product Version	1.2.11

Summary	0014887: time tracking on bug_change_status_page.php depends on private_bugnote_threshold
Description	On bug_change_status_page.php, the input field for time tracking is only shown if the private_bugnote_threshold value matches. I can't see any reason why this dependency exists and I'm assuming a bug (you have to make all private notes visible to reporters for let them insert their time trackings on updating an issue??).
Additional Information	bug_change_status_page.php: 339 <?php if ( config_get('time_tracking_enabled') ) { echo config_get( 'private_bugnote_threshold' ). '-'.$f_bug_id ; ?> 340 <?php if ( access_has_bug_level( config_get( 'private_bugnote_threshold' ), $f_bug_id ) ) { ?> 341 <?php if ( access_has_bug_level( config_get( 'time_tracking_edit_threshold' ), $f_bug_id ) ) { ?> 342 <tr <?php echo helper_alternate_class() ?>> 343 <td class="category"> 344 <?php echo lang_get( 'time_tracking' ) ?> (HH:MM) 345 </td> 346 <td> 347 <input type="text" name="time_tracking" size="5" value="0:00" /> 348 </td> 349 </tr> 350 <?php } ?> 351 <?php } ?> 352 <?php } ?>
Tags	No tags attached.

dregad 2012-10-30 19:54 developer ~0033373	Looking at code history, commit fe2bc7bc introduced this check for private bugnotes back in 2006 as part of the initial implementation of time tracking (0004428). At that point, there was no check for 'time_tracking_edit_threshold', it was added a couple weeks later (commit f02da959). I am not sure why the author included the check for private_bugnote_threshold in the first place; I can only assume, since the time_tracking_edit_threshold did not exist, that it was a way to restrict access to time tracking entry to developers. I agree that the ability to view private bugnotes has nothing to do with adding time tracking info, and in my opinion the private_bugnote_threshold should have been replaced by time_tracking_edit_threshold when it was introduced.

dregad 2012-10-31 04:26 developer ~0033378	For issue reproduction and testing purposes, what are your settings for private_bugnote_threshold and time_tracking_edit_threshold ?

riks 2012-11-12 07:09 reporter ~0034298	From Database Configuration: All Users : All Projects : private_bugnote_threshold : integer : 70 All Users : All Projects : time_tracking_edit_threshold : integer : 25