View Issue Details

IDProjectCategoryView StatusLast Update
0016481mantisbtbugtrackerpublic2014-12-08 02:07
Reporteratrol Assigned Todregad  
PriorityimmediateSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Product Version1.3.0dev 
Target Version1.3.0-beta.1 
Summary0016481: Broken category API following removal of legacy db_prepare_int calls
Description

Commit a61aed3b0b1f89e7e978be486beeac97492a83c0 introduced a major regression.
The function category_add uses undefined variable $query instead of using $t_query

TagsNo tags attached.

Relationships

related to 0016480 closeddregad Broken installer following removal of legacy db_prepare_int calls 

Activities

govind

govind

2013-12-01 22:04

reporter   ~0038715

sdfgdf

govind

govind

2013-12-01 22:05

reporter   ~0038755

xdfjghjgh

Related Changesets

MantisBT: master 059da7ce

2013-10-14 04:38

dregad


Details Diff
Fix 0016481: system notice in category_api Affected Issues
0016481
mod - core/category_api.php Diff File

MantisBT: master 3bd0e1ba

2013-10-14 04:39

dregad


Details Diff
Fix category_get_id_by_name() doesn't find category

Commit ef0bbb87aecdc54e2b9112bf9f3a11a592dfdc4d introduced a regression.
Testing on the return value as if it were a boolean triggers an error
ERROR_CATEGORY_NOT_FOUND_FOR_PROJECT even if the category exists.

Now we do a strict check === false to ensure the error is only triggered
when the query returns no rows.
Affected Issues
0016481
mod - core/category_api.php Diff File