View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0016575 | mantisbt | plug-ins | public | 2013-11-04 02:36 | 2013-11-10 19:18 |
Reporter | kigsf | Assigned To | |||
Priority | normal | Severity | minor | Reproducibility | always |
Status | acknowledged | Resolution | open | ||
Summary | 0016575: New Plugin: Calendar export | ||||
Description | FUNCTION:Export selected MantisBT bug reports as calendar tasks (i.e. TODOs) in a iCal The plugin uses the iCalcreator class, included (license LGPL), for the iCal Perform a database backup before installing the plugin! When installing the REQUIREMENTS:Made for and tested against PHP >= 5.2 and MantisBT version 1.2.0. INSTALLATION:Extract the iCalExport plugin in the 'plugins' directory, sub-directory More info in the docs/README.txt file. | ||||
Tags | No tags attached. | ||||
related to | 0010212 | acknowledged | ICAL plugin |
Thanks for your contribution. There was already a plugin offering similar functionality (see 0010212), maybe you want to review it and evaluate whether the two can be merged ? Also if you're hosting your plugin's source code on Github we can fork and add it to the mantisbt-plugins organization for better visibility. |
|
The ICAL plugin creates a very basic iCal calendar file.
You will find it at https://github.com/iCalcreator/iCalExport I would very much appreciate a test and a code review! |
|
I have forked your plugin into the mantisbt-plugins organization on Github [1] and granted you push access to it. Your responsibility to keep the fork up-to-date :-) Don't have time for a proper test or review atm, but I had a quick look through the code and here are some comments
I do have a MAJOR objection to your altering of the MantisBT core schema. A plugin must NEVER do that, as it has the potential to completely screw up the upgrade path for the users of the plugin. You need to store plugin-specific data in your own tables, i.e. use plugin_table() and not of db_get_table(). Check the source-integration plugin as an example. Hope this helps. |
|
Oh, and when I tried to uninstall your plugin, I got APPLICATION ERROR 401 You're missing 'TABLE' after ALTER. |
|
I'll look over your issues and especially the table one! |
|
I've fixed the table issue, created a plugin table instead. However.. . |
|
I believe it's normal that this row remains however it should not prevent reinstall. I'll try to have a look later. As a side note considering your plugin is at github, i suggest you stop uploading zip files here; you should also reference it on our wiki if not done already. |
|
I've updated the 'Plugins list' at But when accessing |
|
I created the page. |
|
Fixed the wiki page. Thanks for help, guidelines and directions!! :) |
|
In reply to 0016575:0038514
Depends on how you look at it...
That's one way to do it. However, on principle plugins should not delete data when uninstalling, so IMO the correct solution is to not drop the table when uninstalling. I created an issue on your repo and sent a pull request with the fix. A few more things, unrelated to this issue:
|
|