View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0016890mantisbtadministrationpublic2014-01-27 10:062014-12-08 02:07
Reporterdregad Assigned Todregad  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.3.0dev 
Target Version1.3.0-beta.1 
Summary0016890: Admin checks fail to detect deprecated db extension
Description

Running PHP 5.5 with 'mysql' database type triggers an E_DEPRECATED warning (should be using 'mysqli' instead) which is not properly captured by the database admin check.

Consequently, the checks continue as if nothing happened, and we get a failure further down instead of a warning.

If possible, E_DEPRECATED should not trigger a failure but a warning.

Steps To Reproduce
  • PHP 5.5
  • $g_db_type = 'mysql';
  • $g_log_level = LOG_EMAIL; # anything other than LOG_NONE actually
  • run admin checks

==> it fails on log level check, instead of issuing a warning

Showing passed tests displays the error in the expected location 

: mysql_connect(): The mysql extension is deprecated and will be removed in the future: use mysqli or PDO instead

Raised in file /home/dregad/dev/mantisbt/library/adodb/drivers/adodb-mysql.inc.php on line 458

TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

MantisBT: master 323deb3b

2014-01-27 06:47

dregad


Details Diff		 Proper processing of unhandled errors

Sometimes the execution of a test itself can trigger an error, and in
some cases the test can be successful despite of that (e.g. a PHP notice
or use of deprecated functionality). The code was not handling these
situations properly when $g_show_all = true, causing the test to
continue silently instead of reporting the problem.

Added a case for E_DEPRECATED and clarified description for unhandled
error types in check_print_error_rows(). Also made sure the error is
properly captured when hiding passed tests and/or verbose error
messages are not shown.

Fixes 0016890		 Affected Issues
0016890
mod - admin/check/check_api.php Diff File

MantisBT: master 26877d24

2014-01-27 06:50

dregad


Details Diff		 Improve handling of E_DEPRECATED unhandled errors

The check_unhandled_errors_exist() function now returns the (lowest)
error type instead of true, so the caller can capture this information
to trigger a warning instead of a hard failure.

Issue 0016890		 Affected Issues
0016890
mod - admin/check/check_api.php Diff File