View Issue Details

IDProjectCategoryView StatusLast Update
0017292mantisbtcode cleanuppublic2014-12-05 18:33
Reporterdregad Assigned Todregad  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.18 
Target Version1.2.18Fixed in Version1.2.18 
Summary0017292: Use of deprecated PREG_REPLACE_EVAL ('e') pattern modifier
Description

string_insert_hrefs() relies on PREG_REPLACE_EVAL ('e') pattern modifier for preg_replace() to apply rtrim() function to subpatterns.

In PHP 5.5, this feature has been deprecated for security reasons [1] so we should rely on preg_replace_callback() instead.

[1] http://php.net/reference.pcre.pattern.modifiers.php#reference.pcre.pattern.modifiers.eval

TagsNo tags attached.

Activities

dregad

dregad

2014-05-13 05:47

developer   ~0040273

Pull request https://github.com/mantisbt/mantisbt/pull/175

Related Changesets

MantisBT: master-1.2.x c0d9b81a

2014-05-07 07:28

dregad


Details Diff
Remove use of deprecated pattern modifier in string_insert_hrefs()

string_insert_hrefs() relied on PREG_REPLACE_EVAL ('e') pattern modifier
for preg_replace() to apply rtrim() function to subpatterns.

In PHP 5.5, this feature has been deprecated for security reasons [1] so
we rely on preg_replace_callback() instead.

Fixes 0017292

Backporting the fix from master branch, replacing the closure with an
anonymous function for compatibility with PHP < 5.3.

[1] http://php.net/reference.pcre.pattern.modifiers.php#reference.pcre.pattern.modifiers.eval
Affected Issues
0017292
mod - core/string_api.php Diff File

MantisBT: master fb76435b

2014-05-07 07:28

dregad


Details Diff
Remove use of deprecated pattern modifier in string_insert_hrefs()

string_insert_hrefs() relied on PREG_REPLACE_EVAL ('e') pattern modifier
for preg_replace() to apply rtrim() function to subpatterns.

In PHP 5.5, this feature has been deprecated for security reasons [1] so
we rely on preg_replace_callback() instead.

Fixes 0017292

[1] http://php.net/reference.pcre.pattern.modifiers.php#reference.pcre.pattern.modifiers.eval
Affected Issues
0017292
mod - core/string_api.php Diff File