View Issue Details

IDProjectCategoryView StatusLast Update
0017661mantisbtadministrationpublic2014-12-08 02:07
Reporteratrol Assigned Tovboctor  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version1.3.0dev 
Target Version1.3.0-beta.1 
Summary0017661: Marking of settings on "E-mail Notifications" broken.
Description

There is no longer a green or blue background for values that differ from default or "All Project" setting.

TagsNo tags attached.

Activities

vboctor

vboctor

2014-10-21 01:11

manager   ~0041621

Here is the pull request:
https://github.com/mantisbt/mantisbt/pull/514

Related Changesets

MantisBT: master 06b19e32

2014-10-20 21:10

vboctor


Details Diff
Fix marking of settings on "E-mail Notifications"

This includes multiple fixes to get the scenario working again after recent regressions.

This bug was introduced as part of to move highlighting coloring from config to css.

- Don't generate multiple class attributes per td tag. Introduced by 7094372255c5aa89787cc105c31c9e1f7daa649e
- Fix highlighting logic related to overriding caused by saved flags not being complete. This is likely an old bug.
- Fix a bug where null was passed for user_id when calling config_get for global settings rather than ALL_USERS. This could be recent, but it is very hard to tell since blame is polluted by the code style changes.
- Complete renaming 'colour' to 'color'.

I did some testing, but I wouldn't be surprised if we find more corner case bugs due to the complexity of the layers of configurations and checks involved.

Fixes 0017661
Affected Issues
0017661
mod - manage_config_email_page.php Diff File
mod - manage_config_email_set.php Diff File