View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0020372 | mantisbt | html | public | 2015-12-10 08:11 | 2016-12-11 12:44 |
| Reporter | dregad | Assigned To | dregad | ||
| Priority | low | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 1.3.0-rc.2 | Fixed in Version | 1.3.0-rc.2 | ||
| Summary | 0020372: Inline error reports should not mess up non-HTML output | ||||
| Description | There are several PHP scripts in Mantis which are used to dynamically generate non-HTML content, e.g. javascript_*.php, css/common_config.php, etc. Outputting HTML code in these files generates invalid ouput, as reported in 0020367. Inline errors are meant to be used to inform the user of a non-critical error when using the application, we should not output them in non-HTML files. | ||||
| Tags | No tags attached. | ||||
|
PR for review https://github.com/mantisbt/mantisbt/pull/687 |
|
|
MantisBT: master ab91f9eb 2015-12-10 03:12 Details Diff |
Do not print inline errors in non-HTML output There are several PHP scripts in MantisBT which are used to dynamically generate non-HTML content, e.g. javascript_*.php, css/common_config.php, etc. Printing HTML code in these files generates invalid ouput. This commit allows these special scripts to prevent inline errors messages from being printed by defining a constant prior to including core.php (or the Error API), as follows: define( 'DISABLE_INLINE_ERROR_REPORTING', true ); Fixes 0020372 |
Affected Issues 0020372 |
|
| mod - browser_search_plugin.php | Diff File | ||
| mod - core/error_api.php | Diff File | ||
| mod - css/common_config.php | Diff File | ||
| mod - css/status_config.php | Diff File | ||
| mod - csv_export.php | Diff File | ||
| mod - excel_xml_export.php | Diff File | ||
| mod - file_download.php | Diff File | ||
| mod - javascript_config.php | Diff File | ||
| mod - javascript_translations.php | Diff File | ||