View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0021291||mantisbt||api soap||public||2016-07-15 18:29||2017-08-17 16:18|
|Summary||0021291: Remove mc_issue_checkin from MantisConnect|
Hello, I think that <b>mc_issue_checkin</b> should be removed from MantisConnect: https://www.mantisbt.org/bugs/api/soap/mantisconnect.php?wsdl#op.id0x1ba6d3a0
The functionality was removed in this commit: https://github.com/mantisbt/mantisbt/commit/9527e0ef9c84b87d3d01ec646d55ff56ba85c9ac
But it is still present in mantisconnect.wsdl: https://github.com/mantisbt/mantisbt/blob/45fcf1dc46fab398a5996b3ad061cc67688152ea/api/soap/mantisconnect.wsdl#L1218
Yesterday, after upgrading to 1.3.0, my C++ app that was using mc_issue_checkin stopped working so I am now using <b>mc_issue_note_add</b> (view_state = private) and <b>mc_issue_update</b> (status + resolution) to replace the old behavior.
I'm not a SOAP expert so I did not want to change the file on GitHub and do a Push Request.
If this is not right, just close the issue.
|Tags||No tags attached.|
@rombert, is complete removal the right way?
@atrol, no we should rather return a meaningful error message.
@Crayon - would you be able to submit a PR which returns an error instead of removing the method outright?
@rombert, I am not really familiar with SOAP / WSDL. I am using a WSDL Importer (http://docwiki.embarcadero.com/RADStudio/Berlin/en/Using_the_WSDL_Importer) which will generate all the methods I can use in C++. So using that tool will generate the <b>mc_issue_checkin</b> function.
If I decide to call it, I will get this exception: <i>Project raised exception class ERemotableException with message 'Function 'mc_issue_checkin' doesn't exist'.</i>
I find it odd to retrieve a function that should not be used.
From what I understand from this post (https://stackoverflow.com/questions/9327408/changing-soap-interfaces-and-deprecating-web-methods-in-java) there is no real way to deprecate a SOAP method.
Hmm, it seems that this function was removed in https://github.com/mantisbt/mantisbt/commit/9527e0ef9c84b87d3d01ec646d55ff56ba85c9ac , more than 7 years ago :-) . Good catch @Crayon.
So indeed the WSDL should be adjusted to take this into account