Using the latest CVS code I added a news item with a link to hotmail and it rendered fine. Is this what you are trying to do? Are you testing with the latest code or with 0.17.3?

I couldn't get exactly the same problem but I got something similar by entering the anchor tags myself rather than letting mantis just spot the uri.

The regexp's used in string_strip_hrefs() has a few problems:

1. ...[^\"]>... should read ...[^>]>... so that attributes are matched
2. .../s',... should read .../si',...so that upper case is matched
3. the call to preg_replace() removes the tags but doesn't ensure that the whitespace etc. required by subsequent calls to string_insert_href() are present

I've put the following at the top of string_strip_hrefs() to fix 3:
# ensure any anchor tags are preceded by expected whitespace etc.
$p_string = preg_replace( '/(?<!^|<|[\s\:<\n\r])(<\/?a[^>]*>)/si',
' \1',
$p_string);

$p_string = preg_replace( '/(<\/?a[^>]*>)(?!$|>|[\s\,>\n\r])/si',
'\1 ',
$p_string);

edited on: 04-19-03 16:46

I've applied the first two fixes... I'm not happy with your solution for the third so I need to think about it and see if I can come up with a better one

The regexp in string_strip_hrefs has another problem:

it recognizes only double-quoted href attributes, whereas single-quoted attributes are also legal.

Here is a modified function, which is also more efficient (one call to preg_replace instead of two):

function string_strip_hrefs( $p_string ) {

$p_string = preg_replace( '/<a\s[^>]href=' .

'(?:' .

'"(?:mailto:)?([^\"]+)"' . # doublequoted, or

'|' .

"'(?:mailto:)?([^\']+)'" . # singlequoted

')' .

'[^>]>[^\<]*<\/a>/si',

exactly one of sub-patterns 1 and 2 matched, so
                        # one is empty, the other is what we want
                        '\\1\\2',
                        $p_string);
return $p_string;

}

Why does the function decline to match anchors with subtags?
For example:

<a href="mailto:john@example.com">my good friend</a>

I see no reason why it shouldn't, in which case replace the

[^<]

.?

I'm resolving this issue as "no change required" - please do not hesitate to reopen the issue if you believe that this issue should still be looked into.

We've been considering deprecating removing the news feature for a while.

In addition, the string_api regex code has been rewritten/tweaked multiple times since 2002 and the descriptions entered into this tracker have been rendered so it makes it hard to understand the raw data.

If there's still an issue here with the parsing can you:

1) Reopen and update this issue with a raw example that needs fixing
2) Email me directly at paul@mantisforge.org the same raw example that needs fixing (in case the parser being used on notes changes the text)
3) if you are on the mantisbt-dev/user mailing list, email that instead so everyone can have a look.

Thanks
Paul (paul@mantisforge.org)